From 6e41ef3b027ac1e5d9f2ca92a2508d2b5a707518 Mon Sep 17 00:00:00 2001
From: wxy521 <40495740+yuqing521@users.noreply.github.com>
Date: Sun, 16 May 2021 21:06:53 +0800
Subject: [PATCH 1/3] docs:fix example
fix HelloElement example , There may be event binding error, data.abc props are not defined
---
README.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/README.md b/README.md
index 5ff80d932..5a68dea0c 100644
--- a/README.md
+++ b/README.md
@@ -724,7 +724,7 @@ import { define, WeElement } from 'omi'
define('hello-element', class extends WeElement {
onClick = evt => {
// trigger CustomEvent
- this.fire('abc', { name: 'dntzhang', age: 12 })
+ this.fire('Abc', { name: 'dntzhang', age: 12 })
evt.stopPropagation()
}
@@ -771,10 +771,10 @@ define('my-app', class extends WeElement {
color: green;
}`
- render(props, data) {
+ render(props) {
return (
- Hello {data.abc}
+ Hello {this.data.abc}
Date: Sun, 16 May 2021 21:12:06 +0800
Subject: [PATCH 2/3] docs:fix example
fix HelloElement example , There may be event binding error, data.abc props are not defined
---
README.CN.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/README.CN.md b/README.CN.md
index deb27b2e3..cf570161e 100644
--- a/README.CN.md
+++ b/README.CN.md
@@ -793,7 +793,7 @@ import { define, WeElement } from 'omi'
define('hello-element', class extends WeElement {
onClick = evt => {
// trigger CustomEvent
- this.fire('abc', { name: 'dntzhang', age: 12 })
+ this.fire('Abc', { name: 'dntzhang', age: 12 })
evt.stopPropagation()
}
@@ -840,10 +840,10 @@ define('my-app', class extends WeElement {
color: green;
}`
- render(props, data) {
+ render(props) {
return (
- Hello {data.abc}
+ Hello {this.data.abc}
Date: Sun, 16 May 2021 21:19:30 +0800
Subject: [PATCH 3/3] fix:fix omi-cli ts template
---
packages/omi-cli/template/app-ts/src/hello-omi.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packages/omi-cli/template/app-ts/src/hello-omi.tsx b/packages/omi-cli/template/app-ts/src/hello-omi.tsx
index 5db1a955b..2f5d6215d 100755
--- a/packages/omi-cli/template/app-ts/src/hello-omi.tsx
+++ b/packages/omi-cli/template/app-ts/src/hello-omi.tsx
@@ -23,7 +23,7 @@ export default class extends WeElement {
onClick = (evt: Event) => {
// trigger CustomEvent
- this.fire('abc', { name: 'dntzhang & f & xcatliu', age: 12 })
+ this.fire('Abc', { name: 'dntzhang & f & xcatliu', age: 12 })
evt.stopPropagation()
}