Reduce noise about zero port peers
This commit is contained in:
parent
313adf1d2f
commit
0113776f1d
1
TODO
1
TODO
|
@ -9,3 +9,4 @@
|
|||
* data/blob: Deleting incomplete data triggers io.ErrUnexpectedEOF that isn't recovered from.
|
||||
* UL/DL rate-limiting.
|
||||
* Handle Torrent being dropped before GotInfo.
|
||||
* Punish sources of bad peers? Some trackers, PEX, and DHT give port 0s, which seems lousy. The spec suggests maybe to not worry about it, but some sources are very persistent.
|
||||
|
|
|
@ -1657,10 +1657,6 @@ func (me *Client) connectionLoop(t *torrent, c *connection) error {
|
|||
me.mu.Lock()
|
||||
me.addPeers(t, func() (ret []Peer) {
|
||||
for i, cp := range pexMsg.Added {
|
||||
if cp.Port == 0 {
|
||||
log.Printf("peer gave zero port peer over PEX\n\t%s", c)
|
||||
continue
|
||||
}
|
||||
p := Peer{
|
||||
IP: make([]byte, 4),
|
||||
Port: int(cp.Port),
|
||||
|
@ -1846,7 +1842,7 @@ func (me *Client) addPeers(t *torrent, peers []Peer) {
|
|||
continue
|
||||
}
|
||||
if p.Port == 0 {
|
||||
log.Printf("got bad peer: %v", p)
|
||||
// The spec says to scrub these yourselves. Fine.
|
||||
continue
|
||||
}
|
||||
t.addPeer(p)
|
||||
|
|
Loading…
Reference in New Issue