dlss
/
FedP2P
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Implement go vet recommendations

This commit is contained in:
Matt Joiner 2018-02-02 19:28:09 +11:00
parent 7a95714df2
commit 6441e98f62
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
reader_test.go
View File

@ -17,7 +17,8 @@ func TestReaderReadContext(t *testing.T) {
tt, err := cl.AddTorrent(testutil.GreetingMetaInfo())
require.NoError(t, err)
defer tt.Drop()
ctx, _ := context.WithDeadline(context.Background(), time.Now().Add(time.Millisecond))
ctx, cancel := context.WithDeadline(context.Background(), time.Now().Add(time.Millisecond))
defer cancel()
r := tt.Files()[0].NewReader()
defer r.Close()
_, err = r.ReadContext(ctx, make([]byte, 1))

9
storage/mmap.go
View File

@ -46,7 +46,7 @@ func (s *mmapClientImpl) Close() error {
type mmapTorrentStorage struct {
infoHash metainfo.Hash
span mmap_span.MMapSpan
span *mmap_span.MMapSpan
pc PieceCompletion
}
@ -55,8 +55,8 @@ func (ts *mmapTorrentStorage) Piece(p metainfo.Piece) PieceImpl {
pc: ts.pc,
p: p,
ih: ts.infoHash,
ReaderAt: io.NewSectionReader(&ts.span, p.Offset(), p.Length()),
WriterAt: missinggo.NewSectionWriter(&ts.span, p.Offset(), p.Length()),
ReaderAt: io.NewSectionReader(ts.span, p.Offset(), p.Length()),
WriterAt: missinggo.NewSectionWriter(ts.span, p.Offset(), p.Length()),
}
}
@ -92,7 +92,8 @@ func (sp mmapStoragePiece) MarkNotComplete() error {
return nil
}
func mMapTorrent(md *metainfo.Info, location string) (mms mmap_span.MMapSpan, err error) {
func mMapTorrent(md *metainfo.Info, location string) (mms *mmap_span.MMapSpan, err error) {
mms = &mmap_span.MMapSpan{}
defer func() {
if err != nil {
mms.Close()