0b15fda7a8
NewClient nil ClientConfig should use dynamic port
...
It's pretty hard to test otherwise, if something's already on the default port.
2019-07-30 17:19:14 +10:00
cbc98e17aa
Fix race spewing Client stats
2019-07-30 17:18:09 +10:00
3c0588d661
Add some commented out logging
2019-07-19 16:17:38 +10:00
338287486f
Always return errors when handshakes or dialing fails
...
I intend to use xerrors-style error handling for special cases.
2019-07-19 16:15:46 +10:00
76513bfe0b
Restart dial timeout for fallback header obfuscation attempt
2019-07-19 14:46:48 +10:00
5774859701
Try with the non-preferred header obfuscation if there's an error
...
The function called was more selective about what it returned as an error, but that style is outdated (should use xerrors), and no longer returns as expected.
2019-07-19 14:13:42 +10:00
1d8873552a
Rework header obfuscation and add tests for fallbacks
2019-07-19 13:23:36 +10:00
90355b3dc7
Add dummy code for emulating the bug in #114
...
Useful for ensuring that the test can still reproduce the issue with changes to encryption handling.
2019-07-19 13:07:40 +10:00
12958ad384
Refactor Client.dialFirst
2019-06-21 14:50:49 +10:00
06ada2ef0f
Remove unnecessary import alias
2019-06-21 14:49:43 +10:00
30c705f2f8
Count client listener accepts
2019-06-21 14:49:21 +10:00
60e215aa81
Add OnQuery Hook
2019-05-29 15:08:46 +10:00
bc249730aa
Fix segfault on nil conntrack.EntryHandle instance when dialing
...
Fixes https://github.com/anacrolix/torrent/issues/314 . Comments were added to the the conntrack package master, but have no functional change required here.
2019-04-10 18:27:54 +10:00
485d6bb6e7
Fix leaked conntrack.EntryHandle
2019-03-29 08:48:56 +11:00
5829c30146
Make use of the new context parameter in conntrack Wait
2019-03-11 10:46:06 +11:00
ee5a941203
Switch entirely to anacrolix/log
2019-01-15 18:18:30 +00:00
cc531b8c4a
Improve bootstrap result log message
2018-11-29 18:33:33 +11:00
d9fe3f50d3
Discount dial errors that won't affect connection tracking
...
This will reduce pressure on the conntrack instance.
2018-11-28 10:32:08 +11:00
d9e1ebde70
Improve network handling and only listen networks we will use
...
Fixes #290 .
2018-11-28 10:30:21 +11:00
70f63b2991
Remove unused type
2018-11-28 10:26:13 +11:00
3ba991e38a
Remove unused code
2018-11-27 23:57:17 +11:00
33006eeb20
Use new conntrack priorities
...
Fixes #295
2018-11-27 23:22:24 +11:00
40d7a709ee
Log initial DHT bootstrap results
2018-11-21 17:05:56 +11:00
f4e30656d6
Add initial connection tracking
2018-11-21 17:02:22 +11:00
1dc406c81c
Move IpPort to missinggo
2018-11-16 10:35:30 +11:00
0032b45a02
Store remoteAddr with each connection
...
It would appear net.Conns returned from proxies don't have a RemoteAddr the client expects.
2018-11-04 21:15:51 +11:00
1a4950ad4a
Add default DHT servers when UTP disabled
...
Also ensures that UDP and TCP sockets are reserved, even if not used, and fixes tests. Fixes #289 .
2018-11-04 17:43:47 +11:00
9a49f4b37e
Add establish outgoing connection expvar
2018-11-04 16:12:16 +11:00
c50e59166d
Add dial rate limiting
...
Fixes #273 .
2018-11-02 23:09:52 +11:00
9dc89ab6dc
reverting usage of proxy for http requests
2018-10-31 10:54:10 +11:00
a8787e6632
Revert "Make requestStrategy 3 the default"
...
This reverts commit 60dd0eed53
2018-08-25 16:43:28 +10:00
81e6061a53
When Accept gives an error, don't use the Conn
2018-07-27 10:18:56 +10:00
2f14e5dbc0
Track received handshake encryption activity
2018-07-25 17:11:56 +10:00
2940f27f9f
Use the new firewall callback support in go-libutp
2018-07-25 17:11:09 +10:00
6dd3b9c12c
Law of Demeter Client.mu
2018-07-25 13:42:28 +10:00
8479f215e0
Don't return if there's an error accepting
...
This happens if there's too many file descriptors, and left the client unresponsive.
2018-07-22 12:58:41 +10:00
d4d3e24c6f
Track metadata chunks read with its own Count
2018-07-15 10:09:58 +10:00
d4d8f78906
Send extended message before fast/bitfield
...
This is how Transmission does it.
2018-07-14 11:28:54 +10:00
f5bd377941
Change pieceIndex to peer_protocol.Integer
2018-07-12 09:15:15 +10:00
ba8ec1a787
Move back to net.IP for extended handshake message IPs
2018-07-12 00:00:07 +10:00
2685ef6aa9
Use half open limit directly from Config
2018-07-10 12:23:00 +10:00
1f6ba94882
Make extended handshake a struct, and move a bunch of extended stuff into peer_protocol
2018-07-10 12:20:36 +10:00
e3cb94006c
Reinstate the reduce dial timeout and update some values
...
Fixes #263
2018-07-10 11:19:14 +10:00
fad06c7ddf
sortimports
2018-07-07 11:36:58 +10:00
e1d6fc2341
Add torrent.InfoHash type alias
2018-07-07 11:32:52 +10:00
76a3c0891a
Expose handshake stuff in peer_protocol
2018-07-07 11:31:29 +10:00
5f20a21c9d
Change the duplicateRequestTimeout to 1s
2018-06-30 21:10:48 +10:00
60dd0eed53
Make requestStrategy 3 the default
...
Fixes #253 .
2018-06-28 12:06:21 +10:00
7619994ef5
Remove premature initialization of Torrent.lastRequested
2018-06-25 14:03:22 +10:00
195695042d
Add requestStrategy 3, which duplicates requests only after a timeout
...
Possible solution for #253 .
2018-06-24 20:04:31 +10:00
159c4a0e28
Ensure 64-bit alignment of ConnStats fields
...
Fixes #262 .
2018-06-23 18:33:56 +10:00
70093a4db3
Update accept limit parameters
2018-06-22 17:43:02 +10:00
f137bfdd61
Use RLock for Client.WriteStatus
2018-06-17 16:11:50 +10:00
70dfc1f518
Allow disabling accept limiting and modify some constants
2018-06-16 16:37:13 +10:00
0854161e99
Clear accept limits when adding a new torrent
2018-06-16 16:34:35 +10:00
e97f487d2e
Rename Config->ClientConfig and change how defaults work
...
This is a very breaking change.
2018-06-16 16:30:04 +10:00
ad5e44eaf5
Add lots of new expvars and perf timers
2018-06-15 22:42:05 +10:00
81dcb9b779
Remove old Client.dialTCP
2018-06-15 22:39:37 +10:00
8acfc5149b
Rate limit incoming IP prefixes
...
Lots of bad or dishonest incoming handshakes for unwanted torrents.
2018-06-15 22:38:11 +10:00
fd0fb0051b
Update dial expvars
2018-06-15 14:30:31 +10:00
da4a6503c2
Fix race condition in Client.ListenAddrs
2018-06-13 10:53:38 +10:00
856d5083b5
Update log call
2018-06-12 20:22:54 +10:00
360e1dbdd1
Track ConnStats with atomics
2018-06-12 20:21:53 +10:00
b024e1cff6
Remove unnecessary use of go keyword
2018-06-12 20:16:17 +10:00
cea5584d6b
Track outgoing through a new field on connection, and rework duplicate connection preferencing
2018-06-12 20:14:00 +10:00
ab48d4731c
Include rate limiting and stats in BenchmarkConnectionMainReadLoop
2018-06-11 12:20:51 +10:00
5a53d29c75
Minimize lock time in Client.acceptConnections
2018-06-10 10:29:19 +10:00
ac6ba9f021
Add ConnStats at Client level
...
ConnStats management is refactored to make this less tedious.
2018-06-10 09:20:33 +10:00
f6ed514c3b
added proxy support to the library, using ProxyURL parameter. ( #256 )
2018-06-08 20:52:36 +10:00
15b828515e
Don't listen on IPv6 if DisableIPv6 is set
...
Fixes #250
2018-05-02 19:24:46 +10:00
df38775630
A few adjustments to prioritized peers usage
2018-04-14 21:44:41 +10:00
610dbd17ba
Fix #244
2018-04-14 21:43:08 +10:00
5c81c6c70a
Include connection network in log message
2018-04-14 11:24:06 +10:00
0290a1610a
Merge branch 'circleci'
...
# Conflicts:
# client.go
2018-04-12 17:28:13 +10:00
e38216a472
Add comment
2018-04-12 16:12:27 +10:00
485d8cdf61
Use new DHT stats fields
2018-04-12 16:11:22 +10:00
8a8fe378d4
Improve DHT status output
2018-04-12 15:12:15 +10:00
b5df073217
Support different hosts for each network
...
CircleCI's localhost hostname doesn't resolve for IPv6.
2018-04-12 15:06:53 +10:00
319e57d1c6
Rework conns to/and allow multiple DHT servers
...
This will help with #229 , and IPv6 support.
2018-04-12 11:41:07 +10:00
92f6209c5f
Prioritize pending nodes with BEP 40
2018-04-04 17:59:28 +10:00
8f7408b1f9
IPv6 tracker support
2018-02-19 16:19:18 +11:00
fc03dcb859
Set the connection.cryptoMethod
...
It was unwittingly dropped from received connections, and may never have been set for initiated connections.
2018-02-16 10:59:56 +11:00
b92e8b7814
Add support for disabling IPv4 and IPv4 peers
2018-02-16 10:46:11 +11:00
066cdd520b
Add mse.CryptoMethod type
2018-02-16 10:36:29 +11:00
0aad14afd1
Add a check for a strange panic in production
2018-02-15 16:03:44 +11:00
39bde7237e
Try to count IPv6 connections
2018-02-13 00:48:21 +11:00
dd9244c01d
bencode: Unmarshal now returns an error on unused trailing bytes
2018-02-13 00:21:28 +11:00
57216bd299
Standardize on krpc types, and extend PEX message type for IPv6
2018-02-11 15:13:00 +11:00
8d1995c4d4
Support IPv6 blocklists
...
Existing packed blocklists need to be regenerated.
2018-02-11 15:11:26 +11:00
924b916b2a
Expose Client.Closed
2018-02-08 23:57:53 +11:00
f57437201e
Send bitfield messages before other initial messages
2018-02-05 17:41:53 +11:00
e0c2265cb0
Support sending HaveAll
2018-02-04 19:10:25 +11:00
ea8659c951
Move initiateConn and openNewConns onto Torrent
2018-02-04 12:59:23 +11:00
efecf88d3c
Use flip buffering for connection writing
2018-02-03 15:09:38 +11:00
085e676ef0
Generate default peerExtensionBytes using helpers
2018-02-03 13:36:17 +11:00
9567aa901c
Add missing increments to some stats
2018-02-03 11:53:11 +11:00
fe991128ed
Rework connection stat reconciliation with Torrent and refactor doppleganger handling
2018-02-02 19:07:20 +11:00
b0c1f99509
Merge a bunch of stuff into ConnStats and refactor connection.upload
2018-02-02 19:04:56 +11:00
97ffe39561
Move sendChunk onto connection
2018-02-02 13:26:04 +11:00
1a7708b484
sortimports
2018-01-31 16:42:40 +11:00
77806c1f49
More development of the new logging interface
2018-01-29 18:22:21 +11:00
53e32ca9dd
Start using new log package
2018-01-28 16:07:11 +11:00
e08d11a4b9
Update Client.newConnection with changed rateLimitedReader interface
2018-01-28 15:42:37 +11:00
51b3374015
Add very tentative UPnP NAT traversal
...
Relates to #230
2018-01-25 13:14:20 +11:00
9285470cc6
Improve some log messages
2018-01-25 13:10:52 +11:00
56109b387d
Formatting and comments
2018-01-06 16:37:40 +11:00
e13b0eccbf
Make peerID a public type
...
Wanted it applied to Client Status output
2018-01-06 15:50:45 +11:00
c44ee5fec4
Use peerID type more, and make its Stringer output nicer
2018-01-06 12:34:31 +11:00
8f7720edb2
Merge commit '6ab65a49a8a72dea1a28968b2ab42a85fd4566ec'
...
# Conflicts:
# config.go
2017-11-08 20:23:15 +11:00
3aa1e8f3ef
Add a test for behaviour after getting metadata_size and before GotInfo
...
#208
2017-11-08 19:31:10 +11:00
8712cc25d0
Make Client.PeerID return [20]byte
2017-11-08 19:28:37 +11:00
7eb62eec0d
Move some code around
2017-11-08 15:00:18 +11:00
6ab65a49a8
feat(config): Allows the torrent client to customise the client identity and connection config
2017-11-07 20:14:13 +02:00
9757f04cf8
Apply megacheck to torrent package
2017-11-07 16:11:59 +11:00
82093937d5
Ignore expected error
2017-11-06 14:01:07 +11:00
6aad8041ab
Implement new request strategy
...
The new strategy, 2, has the fastest connection download by priority in order, and all other pieces stick to a randomized ordering that's stable per connection.
2017-09-23 15:25:47 +10:00
bb53c97d38
Move uploading to the connection writer
2017-09-18 12:09:08 +10:00
ed0fa62340
Comment and formatting
2017-09-17 00:45:12 +10:00
b39df82fbc
Include peer data with half open connections
2017-09-15 19:10:09 +10:00
846ac2d33e
Herp
2017-09-15 12:56:54 +10:00
d4576a56d9
Add some expvars to track uTP/TCP and PHE fallbacks for outgoing connections
2017-09-15 12:56:15 +10:00
881f1a7e35
Support plaintext crypto method for protocol header encryption
2017-09-13 18:20:20 +10:00
110764480e
Avoid triggering writer cond where possible
2017-09-01 12:09:41 +10:00
13e79039f2
Generate requests, cancels and interest state in the connection writer
2017-08-31 23:48:52 +10:00
986b9093a0
Make connection.writer pull from a buffer
2017-08-31 16:26:45 +10:00
0388ec1eee
Synchronize Torrent.Info
2017-08-29 15:16:53 +10:00
a8a1ea755d
Remove unused functions
2017-08-26 13:23:04 +10:00
401974dd8d
dht.ServerConfig.StartingNodes is now a function
...
Additionally cmd/torrentfs uses the global bootstrap nodes for its DHT. Aids with https://github.com/anacrolix/torrent/issues/180
2017-08-25 16:28:27 +10:00
97cb41a5c9
Provide default starting nodes to DHT if default torrent client config is used
...
https://github.com/anacrolix/torrent/issues/178
2017-08-18 11:14:28 +10:00
76c60ffa77
Try a state-delta function for updating request state
...
Also adds Torrent.networkingEnabled, though it isn't yet useful.
2017-08-18 01:51:02 +10:00
170bb72c34
Augment dialed connection timeouts with context.Context
...
Works toward a dial timeout for half open connections. https://github.com/anacrolix/torrent/issues/169
2017-08-16 17:05:05 +10:00
9bec8f6a95
Use net.Dialer for TCP
2017-08-16 15:48:30 +10:00
8317417910
Use DialContext instead of DialTimeout with utp
2017-08-16 15:35:17 +10:00
2d59d48015
Some tidying in Client.dialFirst
2017-08-16 10:32:25 +10:00
5099d8e33f
DHT bootstrap is not asynchronous
2017-08-10 11:18:48 +10:00
2624281842
Changes for dht-cleanup
2017-07-21 00:40:49 +10:00
6286c11bed
Do not add nodes if dht is disabled
2017-06-29 14:28:07 +08:00
ae8b03d586
Use go-libutp if cgo is enabled
2017-06-16 18:08:24 +10:00
49648b9ae1
Close implicit Client default storage on Client.Close
...
Fixes #158
2017-06-01 22:57:08 +10:00
d8023a5e39
bug fix: race condition between outgoing connection and incoming connection
2017-05-10 18:31:19 +08:00
40b96d0e4e
Avoid allocating skeys for receiving encrypted handshakes
2017-04-04 18:41:08 +10:00
9d96cd659f
fix `Spec.Storage` and allow per-torrent dir
...
`TorrentSpec.Storage` was not honored when calling `Client.AddTorrentSpec`
and the configured `cfg.DefaultStorage` was always used. Now if you construct
your `TorrentSpec` you can specify any `StorageImpl`
Also, the most common use case for custom storage being per-torrent paths for
FileStorage, this adds a `pathMaker` function to the File implementation that
allows customization, along with the default (always use base path) and my use
case (which seemed common enough from the Gitter chat) which is infohash based
subdirectories.
All Public methods have not changed signature, but 1 private method did, hence
the test update.
2017-03-16 14:40:21 +00:00
9cf09dba8a
Remove unused funcs and idents
2017-01-01 11:03:02 +11:00
186b5073d2
Move method queuePieceCheck
2017-01-01 11:02:37 +11:00
d48c7c8e36
sort imports
2017-01-01 11:01:41 +11:00
b68d7cd08e
dht/… moved to github.com/anacrolix/dht
2016-12-14 11:43:37 +11:00
8b50f5fa7a
Fix deadlock in Client.onDHTAnnouncePeer
2016-11-27 14:43:21 +11:00
f451a39b69
Fix harmless race conditions in Client.WriteStatus introduced way back
2016-11-27 14:26:45 +11:00
4a7fbf6170
Add peers received from received announce_peer DHT messages to the Client
...
Addresses #133
2016-11-27 00:05:19 +11:00
aa697794cc
Remove unused function
2016-11-25 17:24:29 +11:00
4807c9e29a
Make Torrent.conns a map
...
Can't remember if I've tried this before. But dropping arbitrary connections while iterating established conns will become much simpler.
2016-11-23 11:48:44 +11:00
ebbd555e7b
Move a bunch of Client methods onto more appropriate types
2016-11-22 21:12:53 +11:00
0d9348c5d1
Move Client.downloadedChunk to connection.go
2016-11-22 14:16:18 +11:00
d4cbdc5c38
Add download rate limiting
...
Fixes #121 .
2016-10-10 17:29:39 +11:00
ed0dbba384
Make newConnection a method on Client
2016-10-10 16:55:56 +11:00
c34234bf34
Split connection.rw into separate Reader and Writer
...
This will make it easier to write hooks for Read and Write separately.
2016-10-10 16:30:51 +11:00
836bb344f3
Add really simple upload rate limiting and test
2016-10-10 14:58:29 +11:00
76c24e70b5
Improve code comments
2016-10-10 14:57:34 +11:00
510c03770b
Reorder the fields of struct Client
2016-10-10 00:04:14 +11:00
de761fb506
Do chunk pooling at Torrent instead of connection level
2016-10-05 15:57:00 +11:00
3b5f123645
Fix Client.receiveSkeys
...
Fixes #114 . Loop variables in Go are ****ed.
2016-09-21 21:04:52 +10:00
7856cc6329
Add some more debug logging
2016-09-21 21:00:18 +10:00
9126db177b
Add Config.{Force,PreferNo}Encryption
2016-09-16 12:42:41 +10:00
2fc814b5eb
Move Client.connectionLoop to connection.mainReadLoop
2016-09-11 14:32:56 +10:00
5d7882a79d
Remove unused trackerTier and shuffleTier
2016-09-11 14:12:03 +10:00
f47fd8c969
Move TorrentSpec stuff into its own file
2016-09-11 14:09:40 +10:00
1e919dd6b1
Rework storage interfaces to make them simpler to implement
...
This allows lots of behaviour to be baked into the new Client, Torrent and Piece wrappers, rather than duplicating (badly) them in all the backend implementations.
2016-09-02 15:10:57 +10:00
8b17d2a63a
Rework Reader position changes affecting piece priorities
...
Torrent.updatePiecePriorities is always followed by Torrent.piecePriorityChanged, so move it into the former function. Also drop the separate mutex for Reader, and add a missing Reader.posChanged call.
2016-08-30 15:41:26 +10:00
7557c9bd4e
Only parse the config listen addr if we have to
...
This fixes a broken benchmark
2016-08-30 14:19:29 +10:00
2a1cef7c9e
Remove the InfoEx type, and don't generate its infohash on the fly
...
Fixes #106 .
2016-08-26 20:29:05 +10:00
00f406753a
Fix build error with missinggo.Sorted
2016-07-30 00:48:15 +10:00
4143b7470d
Begin exposing all the magic that Client.WriteStatus has so people can parse Client state their own way
...
It wasn't possible to move Client.WriteStatus to an external package to verify it doesn't depend on same-package access to data because then it can't be used in the tests, and it's extremely useful there. So I've settled for not locking the Client, and trying to use all the public methods. It's a work in progress.
2016-07-30 00:37:52 +10:00
3c75f68413
Kick connections that contribute the final piece of missing metadata that fails to validate
...
Failing to get metainfo was resetting Torrent.metadataBytes, which caused arriving metadata data to appear to belong to nonexistent pieces, despite passing the check that we'd in fact requested them from the sending connection. This was unnecessarily noisy. Instead return an error if we got all the data, but couldn't set the Torrent's info bytes, that should propagate out and cause the connection that contributed the final missing piece to be dropped. This will at least provide some improved resistance to unfriendly behaviour on the network.
2016-07-24 00:34:40 +10:00
14e10ad58d
Use utp.Socket.CloseNow to close a Client's uTP socket on Close
...
Fixes https://github.com/anacrolix/utp/issues/15 .
2016-07-24 00:24:44 +10:00
980cd69ab2
Break up the DHT announcer code into smaller functions, and add a 5 minute delay between announces
2016-07-23 22:38:31 +10:00
f5d58b3dc6
Unused *Client argument to Torrent.writeStatus
2016-07-12 21:23:20 +10:00
fbe0ded844
Add connection read stats
2016-07-12 16:42:04 +10:00
a4e140b939
New slices package
2016-07-12 16:40:14 +10:00
838c35f3ea
Solve the mystery bug with TestMaxEstablishedConns
...
Adding Torrent by infohash wasn't triggering connections to be accepted, when both TCP and uTP were enabled.
2016-07-07 14:49:18 +10:00
40a78b7cdd
Improve logging heuristic for sending chunks of pieces that go missing
2016-07-06 14:03:11 +10:00
38048672a7
Rework locking in Client.acceptConnections
2016-07-06 00:38:43 +10:00
326b36545b
Prepare to allow max conns per torrent to be configured
2016-07-05 16:23:17 +10:00
6b447c8d2b
Track closing of outbound TCP connections
...
Got all inbound and outbound UTP, missed this one I think.
2016-06-20 17:51:40 +10:00
cee200a5a2
Add piece completion storage
...
Toward fixing https://github.com/anacrolix/torrent/issues/50 .
2016-06-20 17:51:05 +10:00
b84298351a
Move a few methods to Torrent, and track how many DHT announces occur
...
I suspect that DHT announces may occur too regularly, or without a break for torrents that aren't able to get over the lower water pending peer mark.
2016-06-15 15:29:47 +10:00
c2bdb31bb3
Client.announceTorrentDHT -> Torrent.announceDHT
2016-06-15 15:13:53 +10:00
060ff72175
Improve the logic for which address to use for DHT
2016-05-24 19:46:24 +10:00
7a4b491ede
Tidy up the listen function
2016-05-24 19:45:42 +10:00
ca8d9de944
add return when utpsock's err is not nil
2016-05-24 13:24:29 +08:00
0b36de4be9
Merge branch 'master' of https://github.com/lovedboy/torrent
2016-05-24 13:19:55 +08:00
fd1b4dc489
listenedAddr fix when TCP or UDP bind dynamic port
2016-05-24 13:18:04 +08:00
b55e67dc22
Ban IPs that contribute to failed piece checks
2016-05-24 02:09:47 +10:00
c6ec935e53
Update Torrent.wantPeersEvent in several places
2016-05-23 10:19:14 +10:00
7a60873ec8
Don't create an empty tracker URL if both AnnounceList and Announce are empty
2016-05-22 23:43:55 +10:00
20870ec4ff
Rework torrent tracker scraping
...
New scrapers are added anytime trackers are added to a torrent. In the future they will also be stopped as soon as they're removed. All trackers are concurrently scraped, the old-style of sticking to one tracker that works is abandoned for now.
2016-05-22 22:45:08 +10:00
8cdcbe9d40
Fix the tracker method receivers and names
2016-05-19 23:58:00 +10:00
7600ac70e3
Move torrent tracker methods into torrent.go
2016-05-19 22:49:37 +10:00
73a648fb32
Torrent.writeStatus: Include human readable torrent size
2016-05-19 17:15:10 +10:00
a69044b9ea
Break out KRPC stuff from dht into new package
2016-05-17 16:40:08 +10:00
cf55055d12
Improve the note about chunk writing concurrency
...
Everytime I see memory spike I suspect this, and it isn't it.
2016-05-17 02:12:06 +10:00
Matt Joiner