f448f55e88
Coalesce piece state change notifications on client unlock
...
Reported by Craig Campbell <iamcraigcampbell@gmail.com>.
2019-12-13 15:55:56 +11:00
da2d174fc9
Include piece index in log message
2019-11-20 20:04:47 +11:00
289293f3cc
Rename peer source constants
2019-10-17 17:46:35 +11:00
5af5e10640
In the torrent status, sort trackers by the scheme last
2019-10-15 14:59:23 +11:00
2a5488f723
Add missing debug level to log statement
2019-08-22 10:20:13 +10:00
4850ce6ab3
Restrict the number of concurrent piece hashes
...
This fixes bad behaviour where running out of file descriptors, and overloading the system with goroutines and concurrent I/O may cause newly started torrents to fail to hash data.
2019-08-22 10:17:06 +10:00
ee5e459ea3
Tidy up piece completion change handling
2019-08-21 21:06:39 +10:00
14fbacd024
Include the piece number when logging piece hash errors
2019-08-21 21:00:47 +10:00
cb1bf0f413
goimports -local
2019-08-21 20:58:40 +10:00
5a2c1c9b76
Upgrade to simplified logger
2019-08-21 20:44:12 +10:00
9224303c1e
Update all imports of dht to v2
2019-08-10 18:46:07 +10:00
e9b10f774d
Comments on the VerifyData methods
2019-07-25 14:13:42 +10:00
bbeb69bb5f
Ignore cached piece completion state when verifying data
...
Forcing data to be checked via VerifyData, and probably other places where piece checks are queued were being short-circuited due to cached piece completion. If a piece check is queued, or verifyData called, the cached completion state should be ignored.
2019-07-25 14:10:21 +10:00
27b7fbe3f3
Fix announcing to S3 HTTP trackers
2019-07-17 18:12:11 +10:00
5b44954223
Send tracker stopped event from the tracker scraper routine
...
Fixes potential blocking on the announce while the client lock is held, as well as differing arguments to the other announces introduced by #321 .
2019-07-17 11:56:25 +10:00
d27b304dfc
Remove "Sending stopped event to trackers" log
2019-06-18 10:27:17 +10:00
7ce45366f5
Adding Started and Stopped events
2019-06-03 09:45:34 +10:00
d478888231
When failing to read stored data, try updating only the completion state for the failed piece
...
On rare occasions, reads are failing in a loop, exhausting all the available file descriptors. It's not clear why, it could be an error in the filecache storage backend I'm using, or some logic error regarding when it's okay to try to read.
2019-04-09 12:57:54 +10:00
499b2d8725
Fix race condition in Torrent.SetDisplayName
2019-03-20 11:01:56 +11:00
3920c6c325
Fix race in Torrent.String
2019-03-12 11:22:25 +11:00
b102ce901a
Reduce allocations for Piece.hash
2019-01-30 17:54:02 +11:00
1749152065
Reorder some code in dht announcer
2019-01-22 01:41:07 +01:00
a65784374b
Fix cancellation of dht announce when peers are wanted
2019-01-22 01:16:41 +01:00
69c39f0036
Restart DHT announces at regular intervals
...
The existing implementation would crawl the DHT until the address bloom filter was full. This could take ages unless enough peers were found to fill the pending nodes for the torrent to the high water mark. Fixes #301 .
2019-01-21 22:54:03 +01:00
7fa29b9e4d
Fix build error
2019-01-16 10:11:47 +00:00
ee5a941203
Switch entirely to anacrolix/log
2019-01-15 18:18:30 +00:00
3ba991e38a
Remove unused code
2018-11-27 23:57:17 +11:00
9bb8a327c0
Remove log that used missinggo.CryHeard
2018-11-21 17:05:30 +11:00
1dc406c81c
Move IpPort to missinggo
2018-11-16 10:35:30 +11:00
0032b45a02
Store remoteAddr with each connection
...
It would appear net.Conns returned from proxies don't have a RemoteAddr the client expects.
2018-11-04 21:15:51 +11:00
fc4fab91f5
Switch to goimports import sorting
...
Used to use sortimports, but it's old, and goimports seems to have an opinion now.
2018-11-02 23:12:01 +11:00
6dd3b9c12c
Law of Demeter Client.mu
2018-07-25 13:42:28 +10:00
631e18d231
Set Torrent.pieces cap too
...
We know exactly how many we want, and don't want to use any more memory.
2018-07-23 10:28:11 +10:00
6d6197b0a1
Switch pieceIndex back to an int
...
I suspect that interface conversions using packet iter are causing a lot of allocation. Either way, with the casting this adds, we should be able to change pieceIndex's type alias now with minimal code change.
2018-07-17 21:28:01 +10:00
f5bd377941
Change pieceIndex to peer_protocol.Integer
2018-07-12 09:15:15 +10:00
2685ef6aa9
Use half open limit directly from Config
2018-07-10 12:23:00 +10:00
1f6ba94882
Make extended handshake a struct, and move a bunch of extended stuff into peer_protocol
2018-07-10 12:20:36 +10:00
e3cb94006c
Reinstate the reduce dial timeout and update some values
...
Fixes #263
2018-07-10 11:19:14 +10:00
316640f921
Fix panic when failing to parse tracker URL
2018-07-07 11:35:47 +10:00
b2117bc571
Use timers for duplicate requests
...
Nothing was triggering request updates when timeouts expired. This is the simplest fix, no performance considered.
2018-06-30 00:10:31 +10:00
8255194c64
Fix racy Torrent.wantConns check when adding connections
2018-06-26 20:47:21 +10:00
c921242f30
Do requests synchronously, and don't request from hashing or queued pieces
...
Calculating the desired state was a nice idea, but too hard to debug. This way should also be faster.
2018-06-26 14:51:55 +10:00
7dd532d46f
Check that chunks we request aren't being hashed or queued for hash
2018-06-26 13:04:15 +10:00
85dc3c204a
Rework stats for receiving chunks
...
Related to #253 .
2018-06-25 14:06:30 +10:00
195695042d
Add requestStrategy 3, which duplicates requests only after a timeout
...
Possible solution for #253 .
2018-06-24 20:04:31 +10:00
159c4a0e28
Ensure 64-bit alignment of ConnStats fields
...
Fixes #262 .
2018-06-23 18:33:56 +10:00
96050948c2
Use scope timer in Torrent.writeChunk
2018-06-21 23:22:13 +10:00
4fafad46b2
Log and handle error with bad tracker URLs
2018-06-17 16:19:24 +10:00
174120e1e8
Rework Torrent pending requests assertions
...
Should provide more info, and sooner for #249 .
2018-06-16 17:00:50 +10:00
0caafd8e87
Allow dropping connections to the same peer ID
...
Necessary for a test that expects one connection to each other Client.
2018-06-16 16:40:37 +10:00
0f90af85f1
Torrent.Stats: RLock instead of Lock
2018-06-16 16:38:14 +10:00
ad5e44eaf5
Add lots of new expvars and perf timers
2018-06-15 22:42:05 +10:00
90f84bda71
Allow adding duplicate connections
...
I believe this fixes a long-standing race condition when dropping connections to the same peer ID where Clients assume the peer has added connections in the same order. Further commits may address duplicate connections further.
2018-06-13 10:53:11 +10:00
224522545b
Fix build error with recent go version
2018-06-12 21:51:34 +10:00
360e1dbdd1
Track ConnStats with atomics
2018-06-12 20:21:53 +10:00
a287d069a4
Fix crash adding peers when Torrent is closed
2018-06-12 20:17:15 +10:00
cea5584d6b
Track outgoing through a new field on connection, and rework duplicate connection preferencing
2018-06-12 20:14:00 +10:00
ac6ba9f021
Add ConnStats at Client level
...
ConnStats management is refactored to make this less tedious.
2018-06-10 09:20:33 +10:00
df38775630
A few adjustments to prioritized peers usage
2018-04-14 21:44:41 +10:00
ed75065f76
Reinstate Uploaded and Downloaded values in tracker announces
...
Fixes followup comment in #71 .
2018-04-12 16:12:14 +10:00
319e57d1c6
Rework conns to/and allow multiple DHT servers
...
This will help with #229 , and IPv6 support.
2018-04-12 11:41:07 +10:00
92f6209c5f
Prioritize pending nodes with BEP 40
2018-04-04 17:59:28 +10:00
8f7408b1f9
IPv6 tracker support
2018-02-19 16:19:18 +11:00
9513270c06
Trackers shown are just the enabled ones
2018-02-17 11:13:48 +11:00
377cb62da9
Make half-open connection limit more dynamic
2018-02-16 12:15:07 +11:00
dbb2936cdf
TODO
2018-02-16 11:03:21 +11:00
70010ce691
Support IPv6 peers over PEX
2018-02-13 00:50:32 +11:00
fadbd68d99
Count peers not added because of bad addresses and rearrange method
2018-02-08 23:55:28 +11:00
898e878c69
Aggressively wake Readers
2018-02-04 22:47:01 +11:00
44e44637bf
TODOs and comments
2018-02-04 19:14:07 +11:00
e0c2265cb0
Support sending HaveAll
2018-02-04 19:10:25 +11:00
ec7b90db45
connections should not be added if the Torrent is closed
2018-02-04 13:00:08 +11:00
ea8659c951
Move initiateConn and openNewConns onto Torrent
2018-02-04 12:59:23 +11:00
e67b85215c
Piece.everHashed is replaced by storageCompletionOk
2018-02-03 12:14:39 +11:00
f23d097502
Include closed connections in dirtiers
2018-02-03 12:08:16 +11:00
9567aa901c
Add missing increments to some stats
2018-02-03 11:53:11 +11:00
5a4e8cd4c5
Rename and rearrange some conn stats
2018-02-03 00:41:13 +11:00
fe991128ed
Rework connection stat reconciliation with Torrent and refactor doppleganger handling
2018-02-02 19:07:20 +11:00
b0c1f99509
Merge a bunch of stuff into ConnStats and refactor connection.upload
2018-02-02 19:04:56 +11:00
8a43910e2d
connection.writer wasn't checking closed state
2018-02-02 13:36:18 +11:00
2166bf1ec0
Some changes to status output
2018-02-01 18:45:58 +11:00
9387e60999
Track concurrent requests across connections
...
In preparation for some more request strategy options
2018-02-01 14:46:03 +11:00
1a7708b484
sortimports
2018-01-31 16:42:40 +11:00
ceaf5a2360
Add some sanity checks to priorities extracted from Torrent.pendingPieces
2018-01-29 18:22:21 +11:00
77806c1f49
More development of the new logging interface
2018-01-29 18:22:21 +11:00
ef4c0f1413
Add Torrent.Stats.ConnectedSeeders
...
Fixes #231
2018-01-29 18:22:21 +11:00
53e32ca9dd
Start using new log package
2018-01-28 16:07:11 +11:00
5ef22a978b
Synchronize piece completion on piece hash failure
...
Pieces that were unknown, remained unknown despite hashing for that very reason.
2018-01-28 16:02:14 +11:00
906d3bc5bb
Include completion known in PieceState
2018-01-28 15:58:55 +11:00
de928be582
Remove premature update to piece priority after piece is completed
...
This should have prevented Torrent.piecePriorityChanged from being called, meaning requests for the completed piece were not canceled, and the piece remained in connection's piece request queue, which meant wasted effort downloading chunks for an already acquired piece.
Thanks to @elgatito for discovering the issue.
2018-01-28 15:52:14 +11:00
1725fc9a36
Include torrent stats in status
2018-01-27 14:31:46 +11:00
52524925d2
Add separate piece priorities, and cache pending pieces
...
Should fix a bug where prioritizing files is not alone sufficient to trigger downloading.
2018-01-25 17:18:36 +11:00
e3c098441a
Add Torrent.setInfo
2018-01-25 17:10:37 +11:00
4807d05018
Improve some comments
2018-01-25 17:02:52 +11:00
21108bf6ec
Fix file piece index offset calculations
2018-01-25 17:01:29 +11:00
0b553b296f
Add File priorities
...
Fixes #220 .
2018-01-21 22:49:12 +11:00
696595a76e
Add comment explaining Torrent.requestStrategy
2018-01-12 12:24:51 +11:00
ed7e3f6ec0
Make Torrent.pendingPieces a priority bitmap in preparation for #220
2018-01-12 12:24:37 +11:00
87a033e074
Readers obtained from File.NewReader should not readahead into other Files
...
Fixes #221 . Additionally Torrent.length is a pointer and isn't set until the info is available to avoid it defaulting to zero.
2018-01-06 23:15:41 +11:00
9b718566ba
Add File.NewReader
...
Fixes #222
2018-01-06 16:37:13 +11:00
25cf92502d
Improve a log message
2017-12-28 23:58:07 +11:00
54a7d83c45
Log dropping of bad peers in debug mode only
2017-12-03 13:44:37 +11:00
27253eb0d0
Fix panic in Torrent.addrActive if there are closed connections
...
Fixes #214
2017-12-02 10:01:27 +11:00
47622fad36
Fix the Stats panic in #214
2017-12-02 09:58:08 +11:00
d77e939944
Synchronize access to storage
2017-12-01 23:09:07 +11:00
afa9d2ba28
Torrent.bytesLeft was taking a copy instead of pointer to Piece
2017-12-01 17:58:42 +11:00
2daa604eb2
Publish piece state changes after verifying piece
2017-12-01 14:03:05 +11:00
8f7720edb2
Merge commit '6ab65a49a8a72dea1a28968b2ab42a85fd4566ec'
...
# Conflicts:
# config.go
2017-11-08 20:23:15 +11:00
163a63f9a7
Torrent.Metainfo: Don't return incomplete metadata bytes
...
Fixes #208
2017-11-08 19:56:20 +11:00
3aa1e8f3ef
Add a test for behaviour after getting metadata_size and before GotInfo
...
#208
2017-11-08 19:31:10 +11:00
6ab65a49a8
feat(config): Allows the torrent client to customise the client identity and connection config
2017-11-07 20:14:13 +02:00
ff1bd84e7e
Fix #205
2017-11-08 00:34:59 +11:00
9757f04cf8
Apply megacheck to torrent package
2017-11-07 16:11:59 +11:00
2c6b842bbf
Remove noisy log message
2017-11-05 15:39:36 +11:00
361c8654c7
Add some TODOs
2017-11-05 15:39:35 +11:00
3e74396c66
Aggressive Upload ( #203 )
...
* Aggressive Upload Config
* Aggressive Upload
* Flip config option.
* Flip Aggressive Upload Config Option
2017-11-05 14:04:33 +11:00
5d133ea387
Remove debug log message
2017-10-12 17:52:26 +11:00
dd083a4e11
Track completion known to implementation state
...
Addresses #193
2017-10-12 16:09:32 +11:00
17ea4f7fdd
Performance optimizations to calculating bytes left in Torrent
...
Was generating significant overhead in cmd/torrent
2017-09-23 15:28:13 +10:00
2c91d1e3fb
Changes to Bitmap referencing
2017-09-23 15:27:10 +10:00
6aad8041ab
Implement new request strategy
...
The new strategy, 2, has the fastest connection download by priority in order, and all other pieces stick to a randomized ordering that's stable per connection.
2017-09-23 15:25:47 +10:00
1f6a7eb810
It looks like Torrent.worstBadConn was returning an arbitrary bad connection, it wasn't the worst
...
heap.Init got lost somewhere along the way? Need a unit test for this.
2017-09-21 19:32:03 +10:00
bb53c97d38
Move uploading to the connection writer
2017-09-18 12:09:08 +10:00
ed0fa62340
Comment and formatting
2017-09-17 00:45:12 +10:00
69ffb9bc8d
Fix build error
2017-09-17 00:44:09 +10:00
846da66103
Merge pull request #188 from boramalper/KnownSwarm
...
added the initial version of the (t *Torrent) KnownSwarm() function
2017-09-17 00:20:00 +10:00
a66b0e83f3
added support for half-open peers in KnownSwarm() function
2017-09-16 11:48:16 +01:00
b3137b1ede
Make type piece public
2017-09-15 19:35:16 +10:00
2aa20b3e22
Don't verify data at startup, add Torrent.Piece.VerifyData and Torrent.VerifyData for this purpose
...
This has the side effect of deflaking a lot of tests that race to verify data when a torrent is added.
2017-09-15 19:22:32 +10:00
b39df82fbc
Include peer data with half open connections
2017-09-15 19:10:09 +10:00
f87b732959
added the initial version of the (t *Torrent) KnownSwarm() function
2017-09-12 15:22:53 +01:00
bad6f07f5e
Wrap writerCond in tickleWriter and be more selective about using it
2017-09-01 15:26:50 +10:00
13e79039f2
Generate requests, cancels and interest state in the connection writer
2017-08-31 23:48:52 +10:00
0388ec1eee
Synchronize Torrent.Info
2017-08-29 15:16:53 +10:00
a8a1ea755d
Remove unused functions
2017-08-26 13:23:04 +10:00
76c60ffa77
Try a state-delta function for updating request state
...
Also adds Torrent.networkingEnabled, though it isn't yet useful.
2017-08-18 01:51:02 +10:00
493916c279
Rename Torrent.connHasWantedPieces->connection.peerHasWantedPieces
2017-08-18 01:48:19 +10:00
824441efa0
Move logging inside client lock, for Torrent.String
...
Fixes #163
2017-07-01 16:01:38 +10:00
a3d231cb92
signal an event when torrent closed
2017-06-05 08:46:50 +08:00
296ef76c36
Tidy up the duplicate conn selection code
2017-05-26 13:00:28 +10:00
5bde8de95d
perf.Timer.Stop renamed
2017-05-26 13:00:28 +10:00
d8023a5e39
bug fix: race condition between outgoing connection and incoming connection
2017-05-10 18:31:19 +08:00
0d19c72ea5
Added peer count stats to TorrentStats struct
2017-04-22 23:29:10 -04:00
ba3e798b5f
Fix a logging of metainfo.Hash
2017-02-24 21:56:23 +11:00
aa74d992d3
Don’t track the empty string, and ditch Torrent.announceList
2017-02-19 15:57:30 +11:00
350dd01ab9
Fix torrent status info hash hex
2017-02-16 20:10:32 +11:00
a959bdd0f8
Revert "Quick fix for missing MetaInfo.Announce everywhere with trackers"
...
This reverts commit b7a8d08bbf
2017-02-15 18:40:30 +11:00
b7a8d08bbf
Quick fix for missing MetaInfo.Announce everywhere with trackers
2017-02-13 22:28:42 +11:00
b868a6b9e2
dht.Server.Announce now takes [20]byte
2017-02-07 15:01:02 +11:00
79d800fe92
Trivial logging, comment, Stringer changes
2017-02-02 16:53:19 +11:00
Matt Joiner