4258ff7c60
Add missing request updates on cancels, rejects
2021-10-19 14:08:56 +11:00
7f236506cb
Don't automatically delete requests if we're choked with fast extension
2021-10-19 14:08:56 +11:00
198a938700
Optimize Peer.peerHasWantedPieces
2021-10-19 14:08:56 +11:00
5e8f61abb5
Optimize request updates due to conn and reader state changes
2021-10-19 14:08:56 +11:00
4f87eed81a
Extend nominal max requests upper bound to 2048
2021-10-19 14:08:56 +11:00
9aff9f3592
Extract pendingRequests
2021-10-19 14:08:56 +11:00
16c571b58b
Add pprof labels for request updates and remove Client-wide requester
2021-10-19 14:08:13 +11:00
30b99e7102
Remove peer piece inclination and piece request order
...
These are vestigial data structures used with old request strategy implementations.
2021-10-19 14:08:13 +11:00
0f53cbf07e
Change peer requesting to spread requests out evenly
2021-10-19 14:08:13 +11:00
1b78a9bcc6
Update requests on unchoke
2021-10-07 17:20:04 +11:00
eab111dd84
Switch Peer.PieceAllowedFast and several request strategy inputs to raw roaring.Bitmaps
...
This is in preparation to support encoding request strategy run inputs for benchmarking.
2021-10-05 20:06:23 +11:00
da1221dd50
Change Peer._peerPieces to use raw roaring Bitmap type
...
The wrapper type was from when roaring didn't support zero-alloc initialization.
2021-10-05 17:48:34 +11:00
719d5c6400
Wrap error with %w in mainReadLoop
2021-09-30 12:01:56 +10:00
63b3d2d211
Track dirty chunks in a single bitmap on Torrent
2021-09-20 18:52:54 +10:00
510877ea43
Reduce the diff to master and add peerRequesting feature const
2021-09-20 15:09:28 +10:00
1d2d1a9cde
Store peer requests in a bitmap
2021-09-19 15:16:37 +10:00
cd49f75cb9
When updating requests, only tickle writer if there are no requests pending
...
Just a quick attempt to reduce load for now. There'll be a much better way to do this.
2021-09-18 21:01:06 +10:00
21358ba458
Do peer requests separately for each peer
2021-09-18 20:34:14 +10:00
d90c41c534
Add choking/allowed fast checks to Peer.shouldRequest
2021-09-18 19:00:21 +10:00
a8db640c62
Drop bradfitz/iter dependency ( #605 )
...
* Drop bradfitz/iter dependency
`range iter.N` looks nice and doesn't allocate, but unfortunately using a `range` expression blocks a function from being inlined wherever it's used (for now). It's not that we need inlining in all cases, but I do think a C-style for loop looks just as nice and is probably clearer to the majority. There also aren't any clear disadvantages to changing (unless you just happen to dislike the look of C)
* Update misc_test.go
* Update rlreader_test.go
* Update torrent_test.go
* Update bench_test.go
* Update client_test.go
* Update iplist_test.go
* Update mse_test.go
* Update peerconn_test.go
* Update peerconn.go
* Update order_test.go
* Update decoder_test.go
* Update main.go
* Update bench-piece-mark-complete.go
* Update main.go
* Update torrent.go
* Update iplist_test.go
* Update main.go
2021-09-14 13:46:50 +10:00
62c6fbc8f8
Clarify ownership of (*Torrent).chunkPool ( #583 )
...
Basically bind the lifetime of chunkPool to the torrent by using `sync.Pool` in lieu of `*sync.Pool`. Gives the GC ever so slightly less work to do.
2021-09-09 22:27:16 +10:00
72c74f7800
Remove unused code
2021-08-19 16:06:46 +10:00
22c5a94a6a
Use roaring.Bitmap directly for completed pieces
...
Looking at improving the performance around this per https://github.com/anacrolix/torrent/discussions/547#discussion-3522317 .
2021-08-16 11:07:10 +10:00
d42f2516a4
Increase request update interval if there's no signalling
2021-08-01 22:52:51 +10:00
15f8e77519
Add explicit metadata extension types
2021-06-21 12:14:06 +10:00
7d9e2b18d6
Extract chansync to github.com/anacrolix/chansync
2021-06-07 13:01:40 +10:00
c895a21a16
Track chunks read for webseed peers too
2021-06-07 13:01:40 +10:00
36f52d7a14
Apply next request state asynchronously
2021-06-07 13:01:40 +10:00
d37dea1f61
Move peerConnMsgWriter into its own file
2021-06-07 13:01:40 +10:00
24ceed61da
Break out peerConnWriter
2021-06-07 13:01:40 +10:00
b43987fcc8
Fix up some crashes around piece availability
2021-06-07 13:01:40 +10:00
95d808d3c5
Use rejiggered missinggo bitmap
2021-06-07 13:01:39 +10:00
a26e7f9933
Determine peer max requests based on receive speed
2021-06-07 13:01:39 +10:00
86524214f5
Merge maxRequests into localClientReqq
2021-06-07 13:01:39 +10:00
233135493f
Improve num requests per piece status output
2021-06-07 13:01:39 +10:00
09823b9e36
Rework to improve work stealing and try to thread peers through all request pieces
2021-06-07 13:01:39 +10:00
b508877d82
Track peer availability at the Torrent-level
2021-06-07 13:01:39 +10:00
9c9ba1aeac
PeerConn.post becomes PeerConn.write
2021-06-07 13:01:39 +10:00
56e2a8a3a6
Fix download rate, status output
2021-06-07 13:01:39 +10:00
6e97ce952f
Tidy up request and cancel
2021-06-07 13:01:39 +10:00
b2c68b314b
Limit outstanding requests
2021-06-07 13:01:39 +10:00
0830589b0a
Pass tests with new full-client request strategy implementation
2021-06-07 13:01:39 +10:00
a44f9921aa
Remove github.com/pkg/errors use in peerconn.go
...
Was contributing to unexpected CPU use, and it's way out of date.
2021-05-14 15:42:07 +10:00
f01d93cee0
Track chunks received in nexted expvar.Map
2021-05-14 15:42:02 +10:00
ee572c5822
Track peers supporting extension in a nested expvar.Map
2021-05-14 15:41:14 +10:00
1080c837b9
Remove separate postedKeepalives expvar
2021-05-14 15:38:38 +10:00
95d72a452a
Reduce allocations in iterBitmapsDistinct
2021-05-08 10:35:23 +10:00
0cc655deed
Fix closing of webseed peers
2021-02-09 19:21:54 +11:00
68d8604c20
We're not expecting chunks if we have no outstanding requests
2021-01-29 16:14:08 +11:00
43a2942b98
Set not interested when we have no pending requests
2021-01-29 16:13:46 +11:00
1ac5811990
Remove requests as soon as chunk data is received
...
Note that this breaks the backpressure on webseed responses again, and should be fixed shortly.
2021-01-28 16:36:35 +11:00
ca1497ad58
Add peer upload order analysis
2021-01-28 16:31:13 +11:00
47d6282e54
Don't cancel request on current peer when receiving chunk
2021-01-28 14:26:10 +11:00
456a2f7c5d
Expose more callbacks and Request and ChunkSpec
2021-01-28 14:23:22 +11:00
b5215ea7e8
Expose Peer.Network to replace Peer.RemoteAddr.Network
2021-01-25 15:49:48 +11:00
9f9953be52
Don't expose Peer network through RemoteAddr
2021-01-25 15:49:48 +11:00
669905e203
Add ReceivedUsefulData Callback
2021-01-25 15:49:48 +11:00
27108bd2f7
Export Peer
2021-01-25 15:49:48 +11:00
bbfc38c44a
Fix call to wrong postCancel?
...
Looks like this would forget to also cancel the request on the peer, and only send the message.
2021-01-19 10:55:13 +11:00
ded6c19edb
Add the DropMutuallyCompletePeers ClientConfig field
2021-01-05 16:58:45 +11:00
133cc17c00
Some peerImpl observations
2021-01-04 15:51:23 +11:00
de964db3c2
Don't send keepalives if a connection isn't useful to us
...
This might help break the situation where anacrolix/torrent Clients that are connected to each other never release a connection until there's new connections that look more promising.
2020-12-10 11:13:45 +11:00
0d40c4bac2
Read peer request data without Client lock
2020-11-16 16:37:11 +11:00
b020b8c2b6
Add support for the x.pe magnet link parameter
2020-11-16 16:37:11 +11:00
dcb2c0bb41
Fix piece getting queued for hash multiple times
...
Pieces could get queued for hash multiple times when we receive chunks if the piece starts getting hashed before we're done writing all the chunks out. This was only found because piece hashing currently only checks the incomplete data, which is missing after the first piece hash passes, the data is marked complete, then the subsequently queued hash has nothing to read.
2020-11-06 08:39:56 +11:00
7b2a7a667d
Remove old comment
2020-11-04 11:34:24 +11:00
c28e9aaeae
Don't delete requests until after they're written to disk
...
This prevents too many pending writes building up. Webseed peers re-request synchronously, and the writes are done asynchronously, so they download too quickly and there was no backpressure. The backpressure now is provided by the upper limit on outstanding requests per connection.
2020-10-30 12:19:53 +11:00
7410e28329
Fix peer request sleepiness
...
New requests weren't being issued to the current peer when being deleted. For webseeds, this would cause them to not bother issuing new requests indefinitely.
(cherry picked from commit 146a16df4ea26d33b0ce0391c8220de14c9e18f4)
2020-10-30 09:13:39 +11:00
845d3fbe8f
Remove some unused code
2020-10-27 17:56:55 +11:00
c1d189ed31
Performance improvements to PEX
2020-10-23 08:58:55 +11:00
635ec27fb3
Don't update requests for the current connection first when a request is deleted
2020-10-15 12:56:06 +11:00
4a4cb5dc58
Ensure PeerConn._close is called for incoming connections
...
This fixes missing calls to PeerConnClosed callback.
2020-10-14 15:11:45 +11:00
02f82131ea
Move pexConnState from peer to PeerConn
2020-10-13 13:33:22 +11:00
152d8715ff
Add PeerConnClosed callback
2020-10-13 13:02:39 +11:00
6ed1062176
Fix some log levels
2020-10-12 17:12:34 +11:00
417d7d1d48
Tweaks to storage error and completion handling
2020-10-11 12:54:03 +11:00
a9102abf1d
Tidy up some logging
2020-10-10 10:24:58 +11:00
014cb3986b
Fix PeerConn conn status string
2020-10-06 09:50:47 +11:00
1cdae13700
Fix conn status string for WebRTC connections
2020-09-29 16:21:54 +10:00
4dee11efe9
Fix panic for unexpected piece rejections
...
Should fix #419 .
2020-09-03 14:34:06 +10:00
dd906f8fa7
Add ReadExtendedHandshake callback
2020-07-15 16:16:14 +10:00
9d0ea15044
Expose peer.RemoteAddr
2020-07-15 16:16:14 +10:00
7ee0fdafe3
Add some client callbacks
2020-07-15 16:16:14 +10:00
8606385985
Merge pull request #410 from anacrolix/webseeds
...
* Rename Peer to PeerInfo, and unexport PeerInfos
* Break peer out from PeerConn
* Abstract out segments mapping and use it in mmap storage
* Got file storage working with segment index
* Fix race in webtorrent.TrackerClient.Run
* storage file implementation: Error on short writes
* Remove debug logging from storage file implementation
* cmd/torrent-verify: Fix piece hash output
* Support disabling webtorrent
* Further progress on webseeding
* Handle webseed Client events
* Rename fastestConn->fastestPeer
* Add webseeds from magnet links
* Remove events from webseed
Manage this stuff inside the webseed peer instead.
* Make use of magnet source fields and expose Torrent.MergeSpec
* Add option to disable webseeds
* Fix webseeds when info isn't available immediately
* Handle webseed request errors
* Tidy up the interface changes
2020-06-03 11:25:08 +10:00
8a2ff43246
Tidy up the interface changes
2020-06-02 17:41:59 +10:00
d5a482e209
Handle webseed request errors
2020-06-02 16:41:49 +10:00
7909084a17
Fix webseeds when info isn't available immediately
2020-06-02 16:18:25 +10:00
d7627143bc
Add per-torrent ability to disable uploading
2020-06-02 11:20:39 +10:00
eb8688a902
Rename fastestConn->fastestPeer
2020-06-01 19:09:17 +10:00
ff53ab860c
Further progress on webseeding
2020-06-01 18:25:45 +10:00
317146dec9
Export PeerImpl and all its methods
2020-05-31 13:22:36 +10:00
3f8f6e1733
Got things compiling
2020-05-31 13:09:56 +10:00
3d1f08b12f
Save progress
2020-05-30 17:52:27 +10:00
de88c620bc
Seperate peer and PeerConn
2020-05-30 15:18:28 +10:00
02adc3f2ee
Break peer out from PeerConn
2020-05-30 10:14:20 +10:00
9edd98ad78
Close PeerConn.conn synchronously
2020-05-03 18:40:40 +10:00
a7b665873c
Propagate and log more connection read/write errors now that logging is a bit fancier
2020-05-03 18:40:09 +10:00
dad5ab89a5
Limit the write buffer to work around a webrtc datachannel issue
...
https://github.com/pion/datachannel/issues/59 . Fixes https://github.com/anacrolix/torrent/issues/402 .
2020-05-03 18:39:16 +10:00
3e9a5a4aec
Expose ClientConfig.Extensions
...
Also run the storage failure test with fast disabled for the seeder. This probably would have tickled some issues in the past, so it seems like a good place to try it out.
2020-04-23 13:03:40 +10:00
86d5ad4b2c
Don't delete requests if we're choked per BEP 6
...
This should make the expected receive chunk counts match up more correctly. It doesn't seem to affect tests at the moment, but then we don't verify the expected receive chunk counts are correct either.
2020-04-23 12:36:19 +10:00
Matt Joiner