00f406753a
Fix build error with missinggo.Sorted
2016-07-30 00:48:15 +10:00
4143b7470d
Begin exposing all the magic that Client.WriteStatus has so people can parse Client state their own way
...
It wasn't possible to move Client.WriteStatus to an external package to verify it doesn't depend on same-package access to data because then it can't be used in the tests, and it's extremely useful there. So I've settled for not locking the Client, and trying to use all the public methods. It's a work in progress.
2016-07-30 00:37:52 +10:00
3c75f68413
Kick connections that contribute the final piece of missing metadata that fails to validate
...
Failing to get metainfo was resetting Torrent.metadataBytes, which caused arriving metadata data to appear to belong to nonexistent pieces, despite passing the check that we'd in fact requested them from the sending connection. This was unnecessarily noisy. Instead return an error if we got all the data, but couldn't set the Torrent's info bytes, that should propagate out and cause the connection that contributed the final missing piece to be dropped. This will at least provide some improved resistance to unfriendly behaviour on the network.
2016-07-24 00:34:40 +10:00
14e10ad58d
Use utp.Socket.CloseNow to close a Client's uTP socket on Close
...
Fixes https://github.com/anacrolix/utp/issues/15 .
2016-07-24 00:24:44 +10:00
980cd69ab2
Break up the DHT announcer code into smaller functions, and add a 5 minute delay between announces
2016-07-23 22:38:31 +10:00
f5d58b3dc6
Unused *Client argument to Torrent.writeStatus
2016-07-12 21:23:20 +10:00
fbe0ded844
Add connection read stats
2016-07-12 16:42:04 +10:00
a4e140b939
New slices package
2016-07-12 16:40:14 +10:00
838c35f3ea
Solve the mystery bug with TestMaxEstablishedConns
...
Adding Torrent by infohash wasn't triggering connections to be accepted, when both TCP and uTP were enabled.
2016-07-07 14:49:18 +10:00
40a78b7cdd
Improve logging heuristic for sending chunks of pieces that go missing
2016-07-06 14:03:11 +10:00
38048672a7
Rework locking in Client.acceptConnections
2016-07-06 00:38:43 +10:00
326b36545b
Prepare to allow max conns per torrent to be configured
2016-07-05 16:23:17 +10:00
6b447c8d2b
Track closing of outbound TCP connections
...
Got all inbound and outbound UTP, missed this one I think.
2016-06-20 17:51:40 +10:00
cee200a5a2
Add piece completion storage
...
Toward fixing https://github.com/anacrolix/torrent/issues/50 .
2016-06-20 17:51:05 +10:00
b84298351a
Move a few methods to Torrent, and track how many DHT announces occur
...
I suspect that DHT announces may occur too regularly, or without a break for torrents that aren't able to get over the lower water pending peer mark.
2016-06-15 15:29:47 +10:00
c2bdb31bb3
Client.announceTorrentDHT -> Torrent.announceDHT
2016-06-15 15:13:53 +10:00
060ff72175
Improve the logic for which address to use for DHT
2016-05-24 19:46:24 +10:00
7a4b491ede
Tidy up the listen function
2016-05-24 19:45:42 +10:00
ca8d9de944
add return when utpsock's err is not nil
2016-05-24 13:24:29 +08:00
0b36de4be9
Merge branch 'master' of https://github.com/lovedboy/torrent
2016-05-24 13:19:55 +08:00
fd1b4dc489
listenedAddr fix when TCP or UDP bind dynamic port
2016-05-24 13:18:04 +08:00
b55e67dc22
Ban IPs that contribute to failed piece checks
2016-05-24 02:09:47 +10:00
c6ec935e53
Update Torrent.wantPeersEvent in several places
2016-05-23 10:19:14 +10:00
7a60873ec8
Don't create an empty tracker URL if both AnnounceList and Announce are empty
2016-05-22 23:43:55 +10:00
20870ec4ff
Rework torrent tracker scraping
...
New scrapers are added anytime trackers are added to a torrent. In the future they will also be stopped as soon as they're removed. All trackers are concurrently scraped, the old-style of sticking to one tracker that works is abandoned for now.
2016-05-22 22:45:08 +10:00
8cdcbe9d40
Fix the tracker method receivers and names
2016-05-19 23:58:00 +10:00
7600ac70e3
Move torrent tracker methods into torrent.go
2016-05-19 22:49:37 +10:00
73a648fb32
Torrent.writeStatus: Include human readable torrent size
2016-05-19 17:15:10 +10:00
a69044b9ea
Break out KRPC stuff from dht into new package
2016-05-17 16:40:08 +10:00
cf55055d12
Improve the note about chunk writing concurrency
...
Everytime I see memory spike I suspect this, and it isn't it.
2016-05-17 02:12:06 +10:00
02ea8b1081
Rename storage.I->Client
2016-05-16 21:50:43 +10:00
cbac2ecaff
Stop returning errors from the 2 callstacks to connectionLoop where errors are expected
2016-05-16 19:50:10 +10:00
c0283d3314
Return an error from Torrent.setMetadataSize
...
This should mean connections sending ridiculous metadata sizes get dropped.
2016-05-16 18:48:56 +10:00
d2951c6c4b
Move requestPendingMetadata onto connection from Client
2016-05-16 18:46:38 +10:00
2b46a17b39
Bit of a tidy in the tracker code
2016-05-12 12:43:37 +10:00
528836ab4c
Get rid of obsoleted Torrent.ceaseNetworking, and clean up Torrent.closing
2016-05-11 21:44:55 +10:00
dce3a7f675
Rework Client listeners
...
In particular, if the ListenAddr used a dynamic port ":0", and both TCP and uTP were enabled. If the TCP listen succeeded, and the uTP did not, the TCP listener was leaked, and another port number was not tried.
2016-05-11 21:11:52 +10:00
948552b282
Remove unused Client.pruneTimer
2016-05-11 21:08:55 +10:00
715a74985f
Wasn't using ChunkSize from TorrentSpec
2016-05-09 23:00:20 +10:00
a45a09b877
Rework setting of info bytes
2016-05-09 15:47:39 +10:00
cee49435e0
Add Client.AddTorrentInfoHash, and some other tidying
...
Remove Client.bannedTorrents, which shouldn't have been in use anymore. Also fix Client.newTorrent.
2016-05-09 14:37:29 +10:00
69643860ea
Move some behaviour into Client.newConnection
2016-05-07 18:57:38 +10:00
0fd73396fd
missinggo.Event changed, connection.writeOptimizer changes
2016-05-07 18:56:44 +10:00
b5812bb0b7
Remove the last of the "config dir" stuff
...
This just conflates the Client. It should be done orthogonally.
2016-05-05 23:05:28 +10:00
2d160b0419
metainfo.InfoEx.Hash becomes a function, UpdateBytes is added, and Bytes used in marshalling
...
Fixes #80 .
2016-05-05 22:40:38 +10:00
f6b83130c9
Move a bunch of Torrent methods from client.go
2016-05-03 16:47:11 +10:00
d47ba4a08f
Rework handling of metadata data messages
...
There are some dubious logs probably resulting from poor ordering of some code for handling incoming metadata data messages.
2016-05-03 14:59:54 +10:00
726e763c46
Doc and logging improvements
2016-05-03 14:58:26 +10:00
9f4bf70e17
refactor struct identifiers to follow conventional go names
2016-04-18 23:11:11 -05:00
da4d40ed7e
Merge all our global consts and vars into global.go
...
For easier referral to other parties.
2016-04-14 17:19:07 +10:00
f83771b660
Apply ineffassign linter
2016-04-04 15:39:26 +10:00
82ee860e8d
Apply unconvert linter
2016-04-04 15:28:25 +10:00
1566e2afdc
Remove deadcode
2016-04-04 15:18:51 +10:00
8f164ae956
Remove some of the magic ConfigDir stuff
...
This might become a helper. Torrent file cache still remains.
2016-04-04 14:04:48 +10:00
fa511154e4
Move Magnet and friends into metainfo package
2016-04-04 13:48:39 +10:00
b80bb6393a
Use metainfo.Hash for piece and info hashes
2016-04-04 13:01:31 +10:00
00f33c848e
Adding a torrent without info after waitAccept has blocked wouldn't trigger further accepts immediately
2016-04-03 22:06:25 +10:00
22ad654420
Fix deadlocks in WriteStatus due to incomplete renaming
2016-04-03 20:54:14 +10:00
d3a1c79c79
Merge Torrent and torrent types
2016-04-03 18:40:43 +10:00
08830b97a1
Make everything on type torrent private
2016-04-03 16:50:53 +10:00
bc8fb2a165
If we fail to write to a piece, check its completion state
2016-04-03 16:36:57 +10:00
44f5bb73c5
Improve log messages
2016-04-03 16:36:24 +10:00
5856b91af0
Fix missinggo import
2016-03-30 19:11:55 +11:00
a5b54f21a1
Make opening a torrent in storage an explicit method
...
This is storage types where opening can fail, like mmap
2016-03-28 22:40:29 +11:00
775cf53809
Get mmap storage working
2016-03-28 21:57:04 +11:00
b97b50aca9
New storage interface
2016-03-28 20:38:30 +11:00
01bef851ed
Log connection errors when debug mode
2016-03-22 13:10:18 +11:00
bfd0b86441
Tidy up the peer have{,all,none},bitfield handling
2016-03-22 12:07:03 +11:00
e2ffcd008b
Add t.bytesLeftAnnounce
...
Now it's safe to remove tracker specific bytesLeft contract
2016-03-22 09:06:48 +11:00
782589e2b9
Client.WriteStatus: Raise the precision of the completion percentage
2016-03-22 08:33:08 +11:00
99109e636b
Use missinggo.AddrPort directly
2016-03-21 16:02:36 +11:00
99fa0c26aa
Make peerGotPiece a method on connection
2016-03-21 14:19:51 +11:00
1508e02935
Move peerGotPiece
2016-03-21 14:17:15 +11:00
b6cd456779
Use new missinggo.SplitHostMaybePort implementation
2016-03-15 21:32:47 +11:00
0d5502932d
Track accepted connections
2016-03-06 17:26:04 +11:00
f436c9c955
Use missinggo.Event to track Client closed
2016-03-05 19:36:21 +11:00
c175fab5a6
Fix a UTP Conn leak, on unencrypted followup dial attempts
...
I would guess that TCP ones were cleaned up by GC.
2016-03-02 23:27:46 +11:00
e33006a419
Ignore the corner case when a piece is dropped from storage
2016-02-26 22:12:13 +11:00
976510db60
Add DHT nodes from metainfo when added to Client
2016-02-24 21:56:50 +11:00
c371502cb3
Fix failure to request data from peers if it goes missing after being downloaded during the same session
...
The chunks remained marked dirty, even after the piece was marked complete. So when the piece was not complete, there was nothing to do.
2016-02-22 03:23:49 +11:00
99e9f41a33
Choke peers when we lose pieces they requested, and drop them if they request pieces we don't have
2016-02-21 17:22:55 +11:00
e20858a1e8
Move dataReadAt to torrent.readAt, and do the waitNoPendingWrites check there
2016-02-21 03:32:59 +11:00
dcdf85a474
Ditch the torrent stateMu for the client mutex
2016-02-21 03:31:50 +11:00
f76d86da4f
Use new error handling philosophy
2016-02-20 14:40:28 +11:00
b6a1a685cd
Remove pointless code
2016-02-17 17:20:43 +11:00
0f9f7ba01b
Add torrent.completedPieces bitmap
...
Reduce load on data.PieceComplete for torrents with lots of pieces, when reader position changes. Not sure of the improvement yet.
2016-02-17 00:00:55 +11:00
be6052912f
Improve error message when piece fails to be completed
...
Happens occasionally on some servers, can't work out why.
2016-02-16 23:35:19 +11:00
b514434581
Trigger piece request order changes on connections in a few spots
...
The client was requesting already obtained data in certain circumstances. This fixes it.
2016-02-11 17:57:57 +11:00
26fa2c4af8
Track posted message type counts
2016-02-10 00:45:47 +11:00
317783091d
When we're choked, just forget the requests, we don't need to delete them individually anymore
2016-02-08 21:39:15 +11:00
c674e0a65f
Add some missing calls to torrent.updatePiecePriority
2016-02-08 21:38:30 +11:00
24b8b13d2d
Fix pending of already completed pieces when pending ranges of pieces
2016-02-08 21:36:50 +11:00
096c870029
Fix overpublishing of piece state change during hashing
2016-02-07 21:56:59 +11:00
0c28a0f1b1
Use new tracker package interface
2016-02-07 18:49:35 +11:00
814daf6420
Publish changes in piece hashing state
2016-02-07 01:21:12 +11:00
2e3bc1090b
Speed up torrent.needData, and use new missinggo iterator interface
2016-02-07 01:20:40 +11:00
9b9a3fb20a
Fix the mess that is the connectionLoop after messages are decoded
2016-02-05 01:17:06 +11:00
3acdcc3b45
Tidy code
2016-02-04 15:04:46 +11:00
430f26f726
Recalculate all piece priorities more efficiently
2016-02-01 22:06:13 +11:00
afa264e6c5
Reintroduce connection piece inclinations, and begin caching piece priorities
2016-02-01 21:11:41 +11:00
Matt Joiner