1ca2e7e95a
Add some extra conditions to prevent network activity when a torrent is closed
...
From suggestions by @axet, this might be a thing sometimes.
2016-07-30 00:41:45 +10:00
4143b7470d
Begin exposing all the magic that Client.WriteStatus has so people can parse Client state their own way
...
It wasn't possible to move Client.WriteStatus to an external package to verify it doesn't depend on same-package access to data because then it can't be used in the tests, and it's extremely useful there. So I've settled for not locking the Client, and trying to use all the public methods. It's a work in progress.
2016-07-30 00:37:52 +10:00
49315045a0
it is actually sha1 hash size
2016-07-29 22:50:58 +10:00
3c75f68413
Kick connections that contribute the final piece of missing metadata that fails to validate
...
Failing to get metainfo was resetting Torrent.metadataBytes, which caused arriving metadata data to appear to belong to nonexistent pieces, despite passing the check that we'd in fact requested them from the sending connection. This was unnecessarily noisy. Instead return an error if we got all the data, but couldn't set the Torrent's info bytes, that should propagate out and cause the connection that contributed the final missing piece to be dropped. This will at least provide some improved resistance to unfriendly behaviour on the network.
2016-07-24 00:34:40 +10:00
980cd69ab2
Break up the DHT announcer code into smaller functions, and add a 5 minute delay between announces
2016-07-23 22:38:31 +10:00
f5d58b3dc6
Unused *Client argument to Torrent.writeStatus
2016-07-12 21:23:20 +10:00
29844b8b6c
Few slices name changes
2016-07-12 17:49:00 +10:00
507daba528
Rework tracker scraper code to allow tracker stats
...
Inspired by @axet's work.
2016-07-12 16:44:06 +10:00
6e399e8f50
Add test for issue #97
2016-07-12 16:42:54 +10:00
fbe0ded844
Add connection read stats
2016-07-12 16:42:04 +10:00
a4e140b939
New slices package
2016-07-12 16:40:14 +10:00
a6cecc6b5f
missinggo.Sort->SortSlice
2016-07-07 14:14:59 +10:00
240abaf512
Add Torrent.SetMaxEstablishedConns
2016-07-06 00:42:16 +10:00
326b36545b
Prepare to allow max conns per torrent to be configured
2016-07-05 16:23:17 +10:00
12191dbfa3
Add counters for uploads
...
Fixes #71 .
2016-07-05 15:52:33 +10:00
12486412b3
Remove redundant check in Torrent.SetInfoBytes
2016-06-27 15:46:43 +10:00
afc76861e0
Throw away Torrent display name when info becomes available
2016-06-27 15:46:27 +10:00
b84298351a
Move a few methods to Torrent, and track how many DHT announces occur
...
I suspect that DHT announces may occur too regularly, or without a break for torrents that aren't able to get over the lower water pending peer mark.
2016-06-15 15:29:47 +10:00
c2bdb31bb3
Client.announceTorrentDHT -> Torrent.announceDHT
2016-06-15 15:13:53 +10:00
d8dc3ad239
Torrent.MetaInfo: don't crash if info isn't available yet
2016-05-23 20:08:18 +10:00
56a89905b6
Update Torrent.wantPeersEvent when info is obtained
2016-05-23 11:11:56 +10:00
c6ec935e53
Update Torrent.wantPeersEvent in several places
2016-05-23 10:19:14 +10:00
512aa7ede4
Don't start tracker scrapers if trackers are disabled
2016-05-22 23:44:08 +10:00
20870ec4ff
Rework torrent tracker scraping
...
New scrapers are added anytime trackers are added to a torrent. In the future they will also be stopped as soon as they're removed. All trackers are concurrently scraped, the old-style of sticking to one tracker that works is abandoned for now.
2016-05-22 22:45:08 +10:00
8cdcbe9d40
Fix the tracker method receivers and names
2016-05-19 23:58:00 +10:00
7600ac70e3
Move torrent tracker methods into torrent.go
2016-05-19 22:49:37 +10:00
02ea8b1081
Rename storage.I->Client
2016-05-16 21:50:43 +10:00
6f470a2d02
Don't log missing files during hashing
2016-05-16 19:50:46 +10:00
c0283d3314
Return an error from Torrent.setMetadataSize
...
This should mean connections sending ridiculous metadata sizes get dropped.
2016-05-16 18:48:56 +10:00
d2951c6c4b
Move requestPendingMetadata onto connection from Client
2016-05-16 18:46:38 +10:00
2b46a17b39
Bit of a tidy in the tracker code
2016-05-12 12:43:37 +10:00
528836ab4c
Get rid of obsoleted Torrent.ceaseNetworking, and clean up Torrent.closing
2016-05-11 21:44:55 +10:00
a45a09b877
Rework setting of info bytes
2016-05-09 15:47:39 +10:00
2d160b0419
metainfo.InfoEx.Hash becomes a function, UpdateBytes is added, and Bytes used in marshalling
...
Fixes #80 .
2016-05-05 22:40:38 +10:00
f6b83130c9
Move a bunch of Torrent methods from client.go
2016-05-03 16:47:11 +10:00
28c9ec2bd1
Some changes to metainfo.InfoEx and testutil
2016-04-30 11:07:29 +10:00
9f4bf70e17
refactor struct identifiers to follow conventional go names
2016-04-18 23:11:11 -05:00
da4d40ed7e
Merge all our global consts and vars into global.go
...
For easier referral to other parties.
2016-04-14 17:19:07 +10:00
48871324f4
Comments and logs around bad metadata size
2016-04-07 19:13:51 +10:00
49a3c87a53
Fix possible deadlock
2016-04-04 20:39:57 +10:00
82ee860e8d
Apply unconvert linter
2016-04-04 15:28:25 +10:00
1566e2afdc
Remove deadcode
2016-04-04 15:18:51 +10:00
b80bb6393a
Use metainfo.Hash for piece and info hashes
2016-04-04 13:01:31 +10:00
d3a1c79c79
Merge Torrent and torrent types
2016-04-03 18:40:43 +10:00
501ae0c98c
Comments
2016-04-03 16:52:52 +10:00
08830b97a1
Make everything on type torrent private
2016-04-03 16:50:53 +10:00
bc8fb2a165
If we fail to write to a piece, check its completion state
2016-04-03 16:36:57 +10:00
a5b54f21a1
Make opening a torrent in storage an explicit method
...
This is storage types where opening can fail, like mmap
2016-03-28 22:40:29 +11:00
775cf53809
Get mmap storage working
2016-03-28 21:57:04 +11:00
b97b50aca9
New storage interface
2016-03-28 20:38:30 +11:00
bb04cb8843
Tidy up bytesLeft calculations
...
This should fix a bug where completion is shown as negative in WriteStatus
2016-03-22 13:11:36 +11:00
e2ffcd008b
Add t.bytesLeftAnnounce
...
Now it's safe to remove tracker specific bytesLeft contract
2016-03-22 09:06:48 +11:00
61af11fddc
Off by one error in torrent.pieceLength?
2016-02-21 17:25:47 +11:00
5b443fb63d
Refresh all piece completion states when data is missing
2016-02-21 17:24:59 +11:00
e20858a1e8
Move dataReadAt to torrent.readAt, and do the waitNoPendingWrites check there
2016-02-21 03:32:59 +11:00
dcdf85a474
Ditch the torrent stateMu for the client mutex
2016-02-21 03:31:50 +11:00
f6472fc1fd
Code comment
2016-02-20 14:41:04 +11:00
d5f888069f
Ditch Data.WriteSectionTo, and fix cmd/torrent-verify
2016-02-18 11:45:31 +11:00
589ab02dc4
Ensure piece completion state is correct at startup
2016-02-17 17:20:21 +11:00
73208b97ca
Code comments
2016-02-17 17:09:43 +11:00
0f9f7ba01b
Add torrent.completedPieces bitmap
...
Reduce load on data.PieceComplete for torrents with lots of pieces, when reader position changes. Not sure of the improvement yet.
2016-02-17 00:00:55 +11:00
b514434581
Trigger piece request order changes on connections in a few spots
...
The client was requesting already obtained data in certain circumstances. This fixes it.
2016-02-11 17:57:57 +11:00
034c816934
torrent.piecePartiallyDownloaded incorrectly returned true when all the chunks were dirty
2016-02-10 00:46:54 +11:00
24b8b13d2d
Fix pending of already completed pieces when pending ranges of pieces
2016-02-08 21:36:50 +11:00
dab95b5431
Remove unreachable code
2016-02-08 03:01:54 +11:00
623d9e0e06
Rework requesting of shuffled pending pieces
2016-02-07 21:58:48 +11:00
dc215d083e
Export PieceStateChange through piece state change pubsub
2016-02-07 21:55:47 +11:00
0c28a0f1b1
Use new tracker package interface
2016-02-07 18:49:35 +11:00
77d6e9e5cb
Use new missinggo iterator style, and speed up torrent.connHasWantedPieces()
2016-02-07 01:22:31 +11:00
1b8bc1498c
Use missinggo.bitmap for tracking dirty chunks
2016-02-05 15:45:32 +11:00
6942f3e6d5
Changes to piece priority need to be published as a piece state change
...
This occurs because we're now able to deprioritize pieces after readers seek or close
2016-02-05 01:19:42 +11:00
63c73e18b3
Add File.Cancel
2016-02-05 01:18:54 +11:00
89f23c226c
Fix bug in readahead
2016-02-02 04:45:57 +11:00
430f26f726
Recalculate all piece priorities more efficiently
2016-02-01 22:06:13 +11:00
afa264e6c5
Reintroduce connection piece inclinations, and begin caching piece priorities
2016-02-01 21:11:41 +11:00
3ed628356b
Use missinggo.Event for connection closing event
2016-02-01 21:08:52 +11:00
b90dacd324
Abstract the pendingPieces as a bitmap
2016-02-01 01:46:28 +11:00
ae9bba2611
Fix downloading of unwanted chunks, and write out downloaded chunks using the connection loop goroutine
...
Doing the writes with the connection loop goroutine prevents memory use blowing out when chunks aren't written out quickly enough.
2016-01-28 05:54:48 +11:00
90348f6a48
Add pending write helpers
2016-01-25 07:22:33 +11:00
94d764e6be
Readers changing wasn't triggering waitAccept
...
Caused occasional stall in TestSeedAfterDownloading.
2016-01-25 04:14:19 +11:00
0ad4dda9fc
Move fillRequests and replenishConnRequests into connection.go
2016-01-24 15:21:17 +11:00
2f40c48d37
Fix the download/prioritize piece functions
...
This involves adding a pendingPieces field to torrent.
2016-01-19 01:28:56 +11:00
06445f2a1e
It's working and the tests are usually passing
...
I still need to handle "prefetch"-style downloading, and some functions haven't been committed to force this issue.
2016-01-18 18:35:14 +11:00
89a6a20af6
Finally make Torrent.torrent private
...
A lot of code was using unintentionally exported stuff from the embedded *torrent in Torrent.
2016-01-17 00:14:15 +11:00
2beb5f8bd4
Track dirty chunks, instead of pending chunk specs
...
This is the first step toward having purely Reader-based priorities. If a chunk is pending, that currently implies that we want to download it. I want to move that kind of state out to the readers.
2016-01-13 17:11:59 +11:00
153c13db43
Revert "Merge pull request #54 from zhulik/master"
...
This reverts commit 5cf75b869c09050ff2c5
2016-01-06 12:19:49 +11:00
8637086ef9
Merge branch 'master' of https://github.com/anacrolix/torrent
2016-01-04 15:39:08 +03:00
8346ff81f7
Switch to int from peer_protocol.Integer for piece index in a lot of places
2016-01-04 22:34:24 +11:00
be8e44da3c
peersKey is a public type now
2015-12-27 15:27:32 +03:00
86c4c609f1
Expose Torrent.SetDisplayName
2015-12-12 14:03:04 +11:00
79eb1ca0d5
torrent.DisplayName should not be exported
2015-11-22 18:44:08 +11:00
d01c6221e6
Remove sync.Cond from piece
...
It's not trivial to ensure that anyone waiting on the piece Cond will wake on events like the torrent being dropped from the client.
2015-11-06 00:40:16 +11:00
c7cb1009a5
Fix #33 .
2015-10-20 17:53:12 +11:00
b3a8020401
Store pieces inplace in torrent.Pieces
...
This should save some allocation overhead, especially for torrents that have 20k+ pieces.
2015-10-16 22:10:03 +11:00
b0b5794890
Create a pieceStore interface, and merge in my httpfile backend, and replace data/blob
...
data/blob was aging, and had severe performance problems. It's now possible to use missinggo/filecache as a data backend to pieceStore which is better tested and performs excellently.
2015-10-04 00:22:46 +10:00
b7a8bb7570
Simplify the torrent Data interface
...
None of the methods are optional anymore. Removed the nasty wrappers for some data implementations. Moved data.Data back into the main torrent package. Should make it much easier to understand for people implementing their own Data implementations.
2015-10-02 00:09:04 +10:00
58c997210e
Track peer sources with a dict, and don't exceed high water mark
2015-09-28 15:30:13 +10:00
53259397fc
Initialize connection piece priorities lazily, and using a pool
2015-09-26 17:27:35 +10:00
52b0705956
Include num pieces in torrent status
2015-09-25 22:05:32 +10:00
f9ed9c4c04
Avoid frequent allocation of piece request order iterator
2015-09-20 11:29:52 +10:00
eebd09c0fe
Allow subscribing to torrent piece state changes
2015-09-06 12:33:22 +10:00
ef098c47ac
Needlessly convoluted
2015-08-19 13:29:01 +10:00
085be622a0
Replacing pendingWrites WaitGroup with Mutex/Cond/int
...
Apparently I've been using WaitGroups wrong all along.
2015-08-05 02:40:46 +10:00
85a0fe6b61
Drop peers for sending too many unwanted pieces
...
So the algorithm is now, drop the worst half if they get too old, and drop any connection if it's ratio is poor.
2015-08-04 01:32:45 +10:00
d077fed72d
Some utils moved to missinggo
2015-08-04 00:29:01 +10:00
0600c3b5e3
Several speedups in logic
2015-07-17 21:07:01 +10:00
7e9fe4f447
Store chunk data without holding client lock
2015-07-15 16:00:59 +10:00
c018c660f0
Allow chunk size to be specified per torrent
2015-07-15 15:31:18 +10:00
500f51d232
Some changes to writing torrent status
2015-06-30 00:46:24 +10:00
bb28ff7492
Replace pruning timer with as-required connection dropping
2015-06-30 00:45:26 +10:00
ced5733c88
Improve uploading/seeding
2015-06-16 16:57:47 +10:00
af127dfd0f
Add some metainfo validation
2015-06-03 00:17:58 +10:00
a2df9f8b01
Miscellaneous changes
2015-06-03 00:03:43 +10:00
21fb4933fc
Change the way piece state is exposed to give more detail
2015-06-01 18:22:12 +10:00
1cf591dc3d
Switch to using a slice for tracking pending chunks. Saves massive amounts of memory.
2015-05-16 10:51:48 +10:00
0863f8ba2c
go vet
2015-05-15 08:41:42 +10:00
0ec0302d1c
Publicly expose Torrent.GotInfo
2015-04-28 15:24:17 +10:00
526d9d738e
Rewrite imports to local bencode and metainfo
2015-04-27 14:55:01 +10:00
28b299e7c8
Rework the Torrent Reader interface, to allow reader options, and add "responsive" as one such option
...
Had several weeks of testing. Removes a lot of the "helper" reading methods, but this was necessary to allow per-Torrent reading options.
2015-04-14 23:59:41 +10:00
ade6087b2f
Move torrentOffsetRequest and torrentRequestOffset, fixing a bug in former, and test it
2015-04-08 02:20:01 +10:00
60d8ea75a2
Prevent bad metadata_size in extended handshakes from stalling completion of metadata
...
Occasionally bad peers send ridiculous or incorrect metadata_size in their handshakes. If the first acceptable size is wrong, and too small, we'll keep failing metadata completion. If it's too large, honest peers will never send us the pieces we're asking for and we'll never complete the metadata. Now we just adjust the expected metadata size, and keep retrying until we finish. Additionally, we can now request metadata after sending initial messages.
2015-03-27 15:36:59 +11:00
3aa78763aa
Use rogpeppe's sortimports to fix this goimports ordering madness
2015-03-26 17:18:08 +11:00
87690e4c4c
Show metadata state in status output
...
This is help verify the cause for an occasional stall obtaining metadata from peers.
2015-03-25 15:50:31 +11:00
03e69c5464
Fix crash from bad metadata_size in extended handshake
2015-03-24 16:47:02 +11:00
67f90ed886
More public interface tidying
2015-03-20 23:52:53 +11:00
842a32ae0c
Rewrite import paths for migration from Bitbucket
2015-03-20 16:37:44 +11:00
0c63952353
More cleaning up of public interface
2015-03-20 10:52:01 +11:00
a07eb8d720
Misc, some encryption related
2015-03-18 18:37:26 +11:00
28455fb817
Speed up stuff relating to checking piece completion
2015-03-18 18:34:35 +11:00
29238ff23f
Change the interface to add torrents to a Client
2015-03-18 18:32:31 +11:00
a7dddd9be6
Rewrite handshaking and connection management
2015-03-18 18:28:13 +11:00
203da0aab0
Tidy up extension bytes handling; don't close conn from handshake writer; force protocol encryption for now
2015-03-13 06:21:13 +11:00
e85b7e228b
Add support for Fast Extension
2015-03-12 20:06:23 +11:00
e6fbde0dc6
Rework piece completion
2015-03-11 02:41:21 +11:00
914bc12bb6
Harmless improvements
2015-03-11 02:39:01 +11:00
d7695c4585
Change torrent.Name()
2015-03-09 17:35:29 +11:00
ad6ac3f2cd
More cleaning of public interface
2015-03-08 17:28:14 +11:00
3e753bb8ad
Change up the data storage interfaces a bit
2015-03-07 17:11:45 +11:00
779f4d3b97
Implement Handle.ReadAt
2015-03-04 13:06:33 +11:00
4eb70e0673
Support opening handles to Torrent and File
2015-03-01 14:32:54 +11:00
a2d69b4931
Make blob data stateful
2015-02-27 12:45:55 +11:00
315c703456
Rename TorrentData->Data
2015-02-27 01:43:37 +11:00
22746dda23
Ditch the intermediate MetaInfo type
2015-02-26 22:17:58 +11:00
c75dbccea3
Hide a whole bunch of functions seen via torrent
2015-02-25 15:42:47 +11:00
0eb418360b
Allow configuring Client torrent data opener, config dir, disabling metainfo cache, and prune with a timer instead of goroutine
2015-02-25 14:48:39 +11:00
9fb7934d0c
Comments
2015-02-25 01:34:57 +11:00
4b1b009049
Encapsulate torrent data, and provide os.File and mmap-based implementations
2015-02-10 00:14:52 +11:00
029d6939f8
Hide some methods that shouldn't be public
2015-02-10 00:12:29 +11:00
4ca6b4e2c7
Fix some stuff Rob Clifford broke through stress testing
2015-02-06 14:54:59 +11:00
89fc37d46f
Expose PieceStatusCharSequence
2015-01-26 20:52:59 +11:00
78caa4533b
Scale readahead with unchoked connections
2015-01-11 00:16:57 +11:00
d54c5ddf24
Remove a bunch of dead code
2014-12-28 12:51:09 +11:00
3a221dc57d
Rip out the pieces by bytes left and responsive download strategy stuff
2014-12-26 17:15:17 +11:00
262f045fd1
Fixes due to not pending chunk specs prematurely
2014-12-09 00:22:05 -06:00
a081ad63d9
Save memory by not pending chunks prematurely
2014-12-08 21:57:13 -06:00
bacb1af357
Write piece status as counts of contiguous identical states
2014-12-06 21:16:02 -06:00
b6ae4caa6a
Set priorities ahead of the current read position
2014-12-05 00:56:28 -06:00
ac1afa19b8
mmap_span: Avoid allocating the span slice on every use
2014-12-05 00:54:55 -06:00
91c2c1f5c7
Piece priorities, torrent read interface and many fixes
2014-12-03 01:07:50 -06:00
a87e753572
When metadata arrives, we also need to init request ordering
2014-12-02 18:42:22 -06:00
c41919807e
Reuse the info bytes when marshalling torrent metainfo
2014-12-01 23:33:38 -06:00
5c8de6dd7c
Skip mapping files with length 0
2014-12-01 19:13:08 -06:00
c7283182b6
Trivial
2014-12-01 16:40:18 -06:00
fb2b626175
Don't send constructed MetaInfo down a channel when it's available, build it on demand
2014-12-01 16:37:40 -06:00
cb75f49bf7
torrent.String, if the name isn't available, use the info hash
2014-12-01 14:29:30 -06:00
db0232e03f
Not ever hashed takes higher priority than partially downloaded
2014-12-01 03:28:25 -06:00
06aff91f8c
Don't open new connections or announce when new connections aren't wanted
2014-11-21 00:09:55 -06:00
9c37205dde
Include trackers in WriteStatus
2014-11-21 00:07:42 -06:00
06e240e198
Expose a wrapped metainfo type with helper methods
2014-11-18 14:36:27 -06:00
e37d369864
Move half-open tracking into per-torrent
2014-11-16 13:30:44 -06:00
ecf2639856
Add magnet-metainfo, tool to download magnet to torrent file
2014-09-25 18:05:52 +10:00
e30f2777fc
Missing torrent functions
2014-09-14 04:06:17 +10:00
97ae59dfaf
Improve the data waiter system
2014-09-14 03:50:15 +10:00
0217bc6163
Improvements to written status
2014-09-14 03:43:11 +10:00
dcc3de7a70
New worst conn algorithm that incorporates useful/unwanted chunk download rates
2014-09-14 03:40:35 +10:00
ced8a7b78f
New worst conns algorithm that takes into account connection useful chunk hit rate
2014-09-11 20:31:31 +10:00
ed08bd2837
Introduce socket/torrent limits, work in progress
2014-08-28 10:06:36 +10:00
c33b889b5e
Cease networking on a torrent if it's finished and we're not going to seed
2014-08-28 09:39:27 +10:00
7dd932bd5a
Fix a few crashes
2014-08-25 22:15:45 +10:00
2d9c22ae1e
Misc trivial improvements
2014-08-25 22:14:10 +10:00
6aa459dc0d
Stop announcing on DHT if a torrent is removed
2014-08-25 06:01:05 +10:00
c8f335182f
Improve incomplete piece ordering, responsive download strategy
2014-08-25 05:31:34 +10:00
6dce2cbf76
Add piece length to torrent status
2014-08-24 03:11:35 +10:00
ed8ee625c9
Optimize torrent.Length()
2014-08-24 03:09:02 +10:00
95d5d4a30c
Improve status and logging
2014-08-22 17:33:17 +10:00
2410c3eddd
Extract function generating all chunk specs for a piece
2014-08-22 03:42:38 +10:00
00a4e9bc11
Fix crash in metadata requests beyond available info bytes
2014-08-22 03:42:00 +10:00
e8f184a7bf
Store pending peers in a dict to prevent duplicates
2014-08-21 21:10:19 +10:00
74f05db2ea
Clean up imports
2014-08-21 21:08:56 +10:00
5c1492bffe
Add CopyExact util function
2014-08-21 18:24:19 +10:00
ef7c4f4120
Move priority management entirely into the download strategies
2014-07-24 13:42:31 +10:00
6158b1f6ec
torrentfs: Match the active torrents to those found in the given directory
2014-07-23 01:54:11 +10:00
b30f3ba73e
Correct the connection peer bitfields when the metadata becomes available
2014-07-16 17:09:30 +10:00
8910eb660d
Add more information I've needed to the status page
2014-07-16 17:07:28 +10:00
0d27ae7fd1
Make the discovery source for a connection more descriptive
2014-07-16 17:06:18 +10:00
9e8a72ff1d
Invalidating metadata would cause a crash when metadata pieces kept arriving
2014-07-14 23:12:52 +10:00
4c2d07337d
Keep pieces sorted by bytes left
2014-07-10 00:26:58 +10:00
51431c7cfc
Some minor tweaks
2014-06-29 19:10:59 +10:00
f3bd288dd6
Fix crash writing torrent status before priorities are initialized
2014-06-29 19:08:46 +10:00
c96293a111
Can now download from magnet links
2014-06-28 19:38:31 +10:00
Matt Joiner