1d54b1c6d8
Massively reduce CPU when Readers are blocked on unavailable data
2017-02-01 16:28:16 +11:00
74be3d58e5
Reader.Close: Don’t set t to nil, we may still expect it
...
For example in goroutines spawned in ReadContext.
2016-12-05 22:00:26 +11:00
dc7428db54
Reader.Close: Prefer to lock Client in public method
2016-10-31 19:05:33 +11:00
a8e96ce996
When Reader position changes only update piece priorities that may be affected
...
Seems to significantly reduce CPU load reading from torrents with huge piece counts.
2016-10-31 19:00:08 +11:00
559afcd0a9
Reader.SetReadahead can change readahead pieces
2016-10-24 19:35:12 +11:00
0e221dbdcd
Optimize piece priorities when reader position changes
...
Gives a decent boost to throughput and reduces a lot of CPU when reading very quickly from Reader.
2016-10-23 16:33:26 +11:00
8b17d2a63a
Rework Reader position changes affecting piece priorities
...
Torrent.updatePiecePriorities is always followed by Torrent.piecePriorityChanged, so move it into the former function. Also drop the separate mutex for Reader, and add a missing Reader.posChanged call.
2016-08-30 15:41:26 +10:00
9943fc3c58
Improve the log message when piece reads fail
2016-07-10 23:01:17 +10:00
363f042b95
Piece offset computed incorrectly in Reader.readOnceAt
...
Possibly it was only wrong on the last piece in rare circumstances.
2016-07-10 23:00:52 +10:00
c6db777ed4
Bring back log message when a piece read fails unexpectedly
2016-07-10 14:00:25 +10:00
528836ab4c
Get rid of obsoleted Torrent.ceaseNetworking, and clean up Torrent.closing
2016-05-11 21:44:55 +10:00
d2fa0e814d
Ugh, "context" isn't in go 1.6
2016-04-30 11:33:07 +10:00
f62ff2f540
Add Reader.ReadContext
...
Allows cancelling reads etc. Torrents that get stuck can result in Reads that won't return until the torrent is dropped.
2016-04-30 11:08:29 +10:00
d3a1c79c79
Merge Torrent and torrent types
2016-04-03 18:40:43 +10:00
08830b97a1
Make everything on type torrent private
2016-04-03 16:50:53 +10:00
6a8bbc4e14
Suppress piece read errors when data is obtained
2016-04-03 16:35:28 +10:00
4c3fffa097
Fix locks on Reader.SetReadahead
2016-03-19 17:39:56 +11:00
aed2b6b3cb
Add Reader.Torrent()
2016-03-02 23:26:46 +11:00
5cfa8232ed
Fix races in Reader
2016-02-22 02:42:01 +11:00
c184129865
Update Reader pos between reads
2016-02-22 00:32:02 +11:00
5b443fb63d
Refresh all piece completion states when data is missing
2016-02-21 17:24:59 +11:00
400fa1feaf
Fix race updating piece priority when piece being read is unexpectedly unavailable
2016-02-21 03:33:39 +11:00
e20858a1e8
Move dataReadAt to torrent.readAt, and do the waitNoPendingWrites check there
2016-02-21 03:32:59 +11:00
89ec237769
Improve log message
2016-02-20 14:40:55 +11:00
dcce061152
Rework Reader reading, and TestCompletedPieceWrongSize
2016-02-17 18:26:10 +11:00
afa264e6c5
Reintroduce connection piece inclinations, and begin caching piece priorities
2016-02-01 21:11:41 +11:00
9e50da4892
Fix stall if data goes missing during a read
2016-01-28 13:21:50 +11:00
90348f6a48
Add pending write helpers
2016-01-25 07:22:33 +11:00
06445f2a1e
It's working and the tests are usually passing
...
I still need to handle "prefetch"-style downloading, and some functions haven't been committed to force this issue.
2016-01-18 18:35:14 +11:00
89a6a20af6
Finally make Torrent.torrent private
...
A lot of code was using unintentionally exported stuff from the embedded *torrent in Torrent.
2016-01-17 00:14:15 +11:00
153c13db43
Revert "Merge pull request #54 from zhulik/master"
...
This reverts commit 5cf75b869c09050ff2c5
2016-01-06 12:19:49 +11:00
48c3df2d43
Refactorings
2016-01-05 11:48:16 +03:00
bc5d79e1d3
Make torrent.Reader reads fail when the torrent is closed instead of stalling
2015-11-06 00:40:47 +11:00
d01c6221e6
Remove sync.Cond from piece
...
It's not trivial to ensure that anyone waiting on the piece Cond will wake on events like the torrent being dropped from the client.
2015-11-06 00:40:16 +11:00
b3a8020401
Store pieces inplace in torrent.Pieces
...
This should save some allocation overhead, especially for torrents that have 20k+ pieces.
2015-10-16 22:10:03 +11:00
085be622a0
Replacing pendingWrites WaitGroup with Mutex/Cond/int
...
Apparently I've been using WaitGroups wrong all along.
2015-08-05 02:40:46 +10:00
4d3b6e5116
Hold client lock as little as possible in Reader.readAt
2015-07-17 20:59:26 +10:00
7e9fe4f447
Store chunk data without holding client lock
2015-07-15 16:00:59 +10:00
4e80d48692
Add fixes triggered by TestResponsive
2015-07-15 15:54:19 +10:00
0ecd03db32
Retry Reader reads when data is unexpectedly missing
2015-06-03 13:36:27 +10:00
7e8ee950bc
Docs and comments
2015-06-03 13:30:55 +10:00
0ec0302d1c
Publicly expose Torrent.GotInfo
2015-04-28 15:24:17 +10:00
28b299e7c8
Rework the Torrent Reader interface, to allow reader options, and add "responsive" as one such option
...
Had several weeks of testing. Removes a lot of the "helper" reading methods, but this was necessary to allow per-Torrent reading options.
2015-04-14 23:59:41 +10:00
Matt Joiner