6b447c8d2b
Track closing of outbound TCP connections
...
Got all inbound and outbound UTP, missed this one I think.
2016-06-20 17:51:40 +10:00
cee200a5a2
Add piece completion storage
...
Toward fixing https://github.com/anacrolix/torrent/issues/50 .
2016-06-20 17:51:05 +10:00
b84298351a
Move a few methods to Torrent, and track how many DHT announces occur
...
I suspect that DHT announces may occur too regularly, or without a break for torrents that aren't able to get over the lower water pending peer mark.
2016-06-15 15:29:47 +10:00
c2bdb31bb3
Client.announceTorrentDHT -> Torrent.announceDHT
2016-06-15 15:13:53 +10:00
060ff72175
Improve the logic for which address to use for DHT
2016-05-24 19:46:24 +10:00
7a4b491ede
Tidy up the listen function
2016-05-24 19:45:42 +10:00
ca8d9de944
add return when utpsock's err is not nil
2016-05-24 13:24:29 +08:00
0b36de4be9
Merge branch 'master' of https://github.com/lovedboy/torrent
2016-05-24 13:19:55 +08:00
fd1b4dc489
listenedAddr fix when TCP or UDP bind dynamic port
2016-05-24 13:18:04 +08:00
b55e67dc22
Ban IPs that contribute to failed piece checks
2016-05-24 02:09:47 +10:00
c6ec935e53
Update Torrent.wantPeersEvent in several places
2016-05-23 10:19:14 +10:00
7a60873ec8
Don't create an empty tracker URL if both AnnounceList and Announce are empty
2016-05-22 23:43:55 +10:00
20870ec4ff
Rework torrent tracker scraping
...
New scrapers are added anytime trackers are added to a torrent. In the future they will also be stopped as soon as they're removed. All trackers are concurrently scraped, the old-style of sticking to one tracker that works is abandoned for now.
2016-05-22 22:45:08 +10:00
8cdcbe9d40
Fix the tracker method receivers and names
2016-05-19 23:58:00 +10:00
7600ac70e3
Move torrent tracker methods into torrent.go
2016-05-19 22:49:37 +10:00
73a648fb32
Torrent.writeStatus: Include human readable torrent size
2016-05-19 17:15:10 +10:00
a69044b9ea
Break out KRPC stuff from dht into new package
2016-05-17 16:40:08 +10:00
cf55055d12
Improve the note about chunk writing concurrency
...
Everytime I see memory spike I suspect this, and it isn't it.
2016-05-17 02:12:06 +10:00
02ea8b1081
Rename storage.I->Client
2016-05-16 21:50:43 +10:00
cbac2ecaff
Stop returning errors from the 2 callstacks to connectionLoop where errors are expected
2016-05-16 19:50:10 +10:00
c0283d3314
Return an error from Torrent.setMetadataSize
...
This should mean connections sending ridiculous metadata sizes get dropped.
2016-05-16 18:48:56 +10:00
d2951c6c4b
Move requestPendingMetadata onto connection from Client
2016-05-16 18:46:38 +10:00
2b46a17b39
Bit of a tidy in the tracker code
2016-05-12 12:43:37 +10:00
528836ab4c
Get rid of obsoleted Torrent.ceaseNetworking, and clean up Torrent.closing
2016-05-11 21:44:55 +10:00
dce3a7f675
Rework Client listeners
...
In particular, if the ListenAddr used a dynamic port ":0", and both TCP and uTP were enabled. If the TCP listen succeeded, and the uTP did not, the TCP listener was leaked, and another port number was not tried.
2016-05-11 21:11:52 +10:00
948552b282
Remove unused Client.pruneTimer
2016-05-11 21:08:55 +10:00
715a74985f
Wasn't using ChunkSize from TorrentSpec
2016-05-09 23:00:20 +10:00
a45a09b877
Rework setting of info bytes
2016-05-09 15:47:39 +10:00
cee49435e0
Add Client.AddTorrentInfoHash, and some other tidying
...
Remove Client.bannedTorrents, which shouldn't have been in use anymore. Also fix Client.newTorrent.
2016-05-09 14:37:29 +10:00
69643860ea
Move some behaviour into Client.newConnection
2016-05-07 18:57:38 +10:00
0fd73396fd
missinggo.Event changed, connection.writeOptimizer changes
2016-05-07 18:56:44 +10:00
b5812bb0b7
Remove the last of the "config dir" stuff
...
This just conflates the Client. It should be done orthogonally.
2016-05-05 23:05:28 +10:00
2d160b0419
metainfo.InfoEx.Hash becomes a function, UpdateBytes is added, and Bytes used in marshalling
...
Fixes #80 .
2016-05-05 22:40:38 +10:00
f6b83130c9
Move a bunch of Torrent methods from client.go
2016-05-03 16:47:11 +10:00
d47ba4a08f
Rework handling of metadata data messages
...
There are some dubious logs probably resulting from poor ordering of some code for handling incoming metadata data messages.
2016-05-03 14:59:54 +10:00
726e763c46
Doc and logging improvements
2016-05-03 14:58:26 +10:00
9f4bf70e17
refactor struct identifiers to follow conventional go names
2016-04-18 23:11:11 -05:00
da4d40ed7e
Merge all our global consts and vars into global.go
...
For easier referral to other parties.
2016-04-14 17:19:07 +10:00
f83771b660
Apply ineffassign linter
2016-04-04 15:39:26 +10:00
82ee860e8d
Apply unconvert linter
2016-04-04 15:28:25 +10:00
1566e2afdc
Remove deadcode
2016-04-04 15:18:51 +10:00
8f164ae956
Remove some of the magic ConfigDir stuff
...
This might become a helper. Torrent file cache still remains.
2016-04-04 14:04:48 +10:00
fa511154e4
Move Magnet and friends into metainfo package
2016-04-04 13:48:39 +10:00
b80bb6393a
Use metainfo.Hash for piece and info hashes
2016-04-04 13:01:31 +10:00
00f33c848e
Adding a torrent without info after waitAccept has blocked wouldn't trigger further accepts immediately
2016-04-03 22:06:25 +10:00
22ad654420
Fix deadlocks in WriteStatus due to incomplete renaming
2016-04-03 20:54:14 +10:00
d3a1c79c79
Merge Torrent and torrent types
2016-04-03 18:40:43 +10:00
08830b97a1
Make everything on type torrent private
2016-04-03 16:50:53 +10:00
bc8fb2a165
If we fail to write to a piece, check its completion state
2016-04-03 16:36:57 +10:00
44f5bb73c5
Improve log messages
2016-04-03 16:36:24 +10:00
5856b91af0
Fix missinggo import
2016-03-30 19:11:55 +11:00
a5b54f21a1
Make opening a torrent in storage an explicit method
...
This is storage types where opening can fail, like mmap
2016-03-28 22:40:29 +11:00
775cf53809
Get mmap storage working
2016-03-28 21:57:04 +11:00
b97b50aca9
New storage interface
2016-03-28 20:38:30 +11:00
01bef851ed
Log connection errors when debug mode
2016-03-22 13:10:18 +11:00
bfd0b86441
Tidy up the peer have{,all,none},bitfield handling
2016-03-22 12:07:03 +11:00
e2ffcd008b
Add t.bytesLeftAnnounce
...
Now it's safe to remove tracker specific bytesLeft contract
2016-03-22 09:06:48 +11:00
782589e2b9
Client.WriteStatus: Raise the precision of the completion percentage
2016-03-22 08:33:08 +11:00
99109e636b
Use missinggo.AddrPort directly
2016-03-21 16:02:36 +11:00
99fa0c26aa
Make peerGotPiece a method on connection
2016-03-21 14:19:51 +11:00
1508e02935
Move peerGotPiece
2016-03-21 14:17:15 +11:00
b6cd456779
Use new missinggo.SplitHostMaybePort implementation
2016-03-15 21:32:47 +11:00
0d5502932d
Track accepted connections
2016-03-06 17:26:04 +11:00
f436c9c955
Use missinggo.Event to track Client closed
2016-03-05 19:36:21 +11:00
c175fab5a6
Fix a UTP Conn leak, on unencrypted followup dial attempts
...
I would guess that TCP ones were cleaned up by GC.
2016-03-02 23:27:46 +11:00
e33006a419
Ignore the corner case when a piece is dropped from storage
2016-02-26 22:12:13 +11:00
976510db60
Add DHT nodes from metainfo when added to Client
2016-02-24 21:56:50 +11:00
c371502cb3
Fix failure to request data from peers if it goes missing after being downloaded during the same session
...
The chunks remained marked dirty, even after the piece was marked complete. So when the piece was not complete, there was nothing to do.
2016-02-22 03:23:49 +11:00
99e9f41a33
Choke peers when we lose pieces they requested, and drop them if they request pieces we don't have
2016-02-21 17:22:55 +11:00
e20858a1e8
Move dataReadAt to torrent.readAt, and do the waitNoPendingWrites check there
2016-02-21 03:32:59 +11:00
dcdf85a474
Ditch the torrent stateMu for the client mutex
2016-02-21 03:31:50 +11:00
f76d86da4f
Use new error handling philosophy
2016-02-20 14:40:28 +11:00
b6a1a685cd
Remove pointless code
2016-02-17 17:20:43 +11:00
0f9f7ba01b
Add torrent.completedPieces bitmap
...
Reduce load on data.PieceComplete for torrents with lots of pieces, when reader position changes. Not sure of the improvement yet.
2016-02-17 00:00:55 +11:00
be6052912f
Improve error message when piece fails to be completed
...
Happens occasionally on some servers, can't work out why.
2016-02-16 23:35:19 +11:00
b514434581
Trigger piece request order changes on connections in a few spots
...
The client was requesting already obtained data in certain circumstances. This fixes it.
2016-02-11 17:57:57 +11:00
26fa2c4af8
Track posted message type counts
2016-02-10 00:45:47 +11:00
317783091d
When we're choked, just forget the requests, we don't need to delete them individually anymore
2016-02-08 21:39:15 +11:00
c674e0a65f
Add some missing calls to torrent.updatePiecePriority
2016-02-08 21:38:30 +11:00
24b8b13d2d
Fix pending of already completed pieces when pending ranges of pieces
2016-02-08 21:36:50 +11:00
096c870029
Fix overpublishing of piece state change during hashing
2016-02-07 21:56:59 +11:00
0c28a0f1b1
Use new tracker package interface
2016-02-07 18:49:35 +11:00
814daf6420
Publish changes in piece hashing state
2016-02-07 01:21:12 +11:00
2e3bc1090b
Speed up torrent.needData, and use new missinggo iterator interface
2016-02-07 01:20:40 +11:00
9b9a3fb20a
Fix the mess that is the connectionLoop after messages are decoded
2016-02-05 01:17:06 +11:00
3acdcc3b45
Tidy code
2016-02-04 15:04:46 +11:00
430f26f726
Recalculate all piece priorities more efficiently
2016-02-01 22:06:13 +11:00
afa264e6c5
Reintroduce connection piece inclinations, and begin caching piece priorities
2016-02-01 21:11:41 +11:00
3ed628356b
Use missinggo.Event for connection closing event
2016-02-01 21:08:52 +11:00
eb838a894c
newTorrent doesn't need to return error
2016-02-01 07:05:43 +11:00
b90dacd324
Abstract the pendingPieces as a bitmap
2016-02-01 01:46:28 +11:00
84c34e2c37
TODO
2016-01-28 13:04:25 +11:00
ae9bba2611
Fix downloading of unwanted chunks, and write out downloaded chunks using the connection loop goroutine
...
Doing the writes with the connection loop goroutine prevents memory use blowing out when chunks aren't written out quickly enough.
2016-01-28 05:54:48 +11:00
90348f6a48
Add pending write helpers
2016-01-25 07:22:33 +11:00
9091c0518d
Use pendingPieces in needData
2016-01-24 15:21:31 +11:00
0ad4dda9fc
Move fillRequests and replenishConnRequests into connection.go
2016-01-24 15:21:17 +11:00
cafac95de4
Delete finished pieces from pending
2016-01-19 01:41:53 +11:00
2f40c48d37
Fix the download/prioritize piece functions
...
This involves adding a pendingPieces field to torrent.
2016-01-19 01:28:56 +11:00
06445f2a1e
It's working and the tests are usually passing
...
I still need to handle "prefetch"-style downloading, and some functions haven't been committed to force this issue.
2016-01-18 18:35:14 +11:00
89a6a20af6
Finally make Torrent.torrent private
...
A lot of code was using unintentionally exported stuff from the embedded *torrent in Torrent.
2016-01-17 00:14:15 +11:00
8696f32e58
Make Config.DHTConfig not a pointer
2016-01-17 00:12:53 +11:00
2beb5f8bd4
Track dirty chunks, instead of pending chunk specs
...
This is the first step toward having purely Reader-based priorities. If a chunk is pending, that currently implies that we want to download it. I want to move that kind of state out to the readers.
2016-01-13 17:11:59 +11:00
153c13db43
Revert "Merge pull request #54 from zhulik/master"
...
This reverts commit 5cf75b869c09050ff2c5
2016-01-06 12:19:49 +11:00
48c3df2d43
Refactorings
2016-01-05 11:48:16 +03:00
8637086ef9
Merge branch 'master' of https://github.com/anacrolix/torrent
2016-01-04 15:39:08 +03:00
09050ff2c5
Some missing hunks that fix build
2016-01-04 22:56:36 +11:00
3208fac438
Failure to announce on one tracker isn't very interesting
2016-01-04 22:54:19 +11:00
3c446086af
Add Have and Bitfield connection methods
2016-01-04 22:37:49 +11:00
8346ff81f7
Switch to int from peer_protocol.Integer for piece index in a lot of places
2016-01-04 22:34:24 +11:00
be8e44da3c
peersKey is a public type now
2015-12-27 15:27:32 +03:00
5b790bf874
Torrent structs replaced with Download interface in exported Client methods
2015-12-27 14:49:15 +03:00
f9a04b4f29
Suppress log message regarding bad tracker URLs
2015-12-23 03:32:24 +11:00
86c4c609f1
Expose Torrent.SetDisplayName
2015-12-12 14:03:04 +11:00
672e3c4136
Don't consider a peer to have touched a piece if a chunk isn't written successfully
...
This prevents peers being banned when there are issues with the data service locally.
2015-12-11 03:04:04 +11:00
79eb1ca0d5
torrent.DisplayName should not be exported
2015-11-22 18:44:08 +11:00
9f38d212e4
Blocking IPv6 addresses is not so interesting
2015-11-13 22:33:50 +11:00
d01c6221e6
Remove sync.Cond from piece
...
It's not trivial to ensure that anyone waiting on the piece Cond will wake on events like the torrent being dropped from the client.
2015-11-06 00:40:16 +11:00
f8fb480817
Avoid copying mutex in piece
2015-10-30 01:16:52 +11:00
a4049e179c
Avoid allocation in iplist.Ranger.Lookup
...
It was very expensive for DHT packets.
2015-10-19 00:00:26 +11:00
b3a8020401
Store pieces inplace in torrent.Pieces
...
This should save some allocation overhead, especially for torrents that have 20k+ pieces.
2015-10-16 22:10:03 +11:00
70a307a5ea
fix: added announce to torrent spec
2015-10-10 14:31:02 +02:00
efe294ac35
utp package merged PacketConn with Socket
2015-10-04 00:02:14 +10:00
b7a8bb7570
Simplify the torrent Data interface
...
None of the methods are optional anymore. Removed the nasty wrappers for some data implementations. Moved data.Data back into the main torrent package. Should make it much easier to understand for people implementing their own Data implementations.
2015-10-02 00:09:04 +10:00
58c997210e
Track peer sources with a dict, and don't exceed high water mark
2015-09-28 15:30:13 +10:00
53259397fc
Initialize connection piece priorities lazily, and using a pool
2015-09-26 17:27:35 +10:00
22428da0e3
Add packed IP list
...
This saves a lot of memory by allowing the IP blocklist to be mmap()ed in. In production with the latest level1 blocklist it's 35MB per process.
2015-09-23 18:25:22 +10:00
0fa547e292
Don't warn about zero port peers from trackers
2015-09-20 21:09:10 +10:00
cd96dbcd9d
Tidy
2015-09-17 12:54:03 +10:00
11d703fbf1
Count failed chunk sends against a connection
2015-09-17 12:50:29 +10:00
9f324d04e2
Tweak logging
2015-09-17 12:40:35 +10:00
0113776f1d
Reduce noise about zero port peers
2015-09-17 12:39:51 +10:00
313adf1d2f
Some code missed in the last commit ಠ_ಠ
2015-09-06 12:35:56 +10:00
eebd09c0fe
Allow subscribing to torrent piece state changes
2015-09-06 12:33:22 +10:00
4472a0e27a
Add Debug flag to Config
...
I'll use this to squash the noisy logging for people who don't care.
2015-08-23 12:59:03 +10:00
698181e470
Code comment
2015-08-23 12:49:35 +10:00
1db00a54f0
Redo the compact peer types
2015-08-17 19:52:47 +10:00
6b27e1473d
Upload after a piece completes
2015-08-12 17:11:14 +10:00
6c8c870b28
Log zero ports from trackers
2015-08-06 08:58:13 +10:00
cb00308157
Back off on the kicked connections log
2015-08-06 08:56:36 +10:00
59e50bd614
Log who's giving us zero ports over PEX
...
In the long run this will help determine why this happens.
2015-08-06 08:55:48 +10:00
5d5ee66be4
Clear piece touch flag from connection after a piece is hashed
2015-08-05 02:43:53 +10:00
497d185373
Add an option to disable IPv6
2015-08-05 02:41:50 +10:00
085be622a0
Replacing pendingWrites WaitGroup with Mutex/Cond/int
...
Apparently I've been using WaitGroups wrong all along.
2015-08-05 02:40:46 +10:00
92e1e505b4
Improve log message
2015-08-04 01:33:50 +10:00
da8ac9fe01
Log errant unwanted piece rather than panic
...
Eventually I'll work out what causes this, but for now it's incredibly rare.
2015-08-04 01:29:40 +10:00
bbe58bbd73
Filter out DHT peers with port 0
...
Probably not necessary now we ban the nodes that send them, but it's appropriate to check here too.
2015-08-04 01:20:10 +10:00
f3317322f8
Fix crash if peer sends out of bounds HAVE message
2015-08-04 01:17:32 +10:00
f69c51bea3
Tighten up some potential leaks
...
Based on some observations of lingering goroutines in unit tests.
2015-08-04 01:15:09 +10:00
54339a30e3
Drop connections that contributed to pieces that failed to hash
...
There are peers out there that seem to intentionally spam bad data, and the same pieces will often fail continuously. This really puts a bee in their bonnet.
2015-08-04 01:12:09 +10:00
51aad774ab
Add IPBlocklist option to Config, and test it's inherited by DHT
2015-08-04 01:07:22 +10:00
f9995244c0
If a DHTConfig was provided without a blocklist, the DHT wouldn't inherit the Client's blocklist
2015-08-04 00:43:46 +10:00
68e3b9f666
dht: Block bad nodes, start by banning those that send port=0
2015-08-04 00:31:53 +10:00
1f008fb4f0
Trivial missed changes
2015-08-02 21:00:49 +10:00
06dede5690
Track the connection flags for completed handshakes
2015-08-02 04:06:22 +10:00
34d3d7aca0
Tidy up outbound connection code
...
Preparing to allow alternate dialing logic.
2015-08-02 04:04:42 +10:00
d037e6ee9c
Suppress a lot of noisy logging
2015-08-02 04:01:41 +10:00
e5acfcbb46
Comments
2015-08-02 03:53:37 +10:00
8ce61e911d
Torrent.BytesCompleted was racy
2015-07-21 22:54:02 +10:00
78ec88ad02
Don't probe pieces when setting torrent storage
...
It blocks the caller, for potentially quite some time. I've tested without this for some time now.
2015-07-21 22:52:43 +10:00
346c457e9c
Hashing was blocking prioritization of pieces
2015-07-21 22:51:15 +10:00
84fc3aab0f
client.go: Missing perf import
2015-07-17 21:45:44 +10:00
0600c3b5e3
Several speedups in logic
2015-07-17 21:07:01 +10:00
6c04000644
Downloading a chunk may mean the piece isn't wanted anymore
...
Hopefully this fixes a very rare logic error in replenishing connection requests for a piece that isn't wanted, yet is still in the connection piece request order.
2015-07-17 21:04:43 +10:00
7e9fe4f447
Store chunk data without holding client lock
2015-07-15 16:00:59 +10:00
c018c660f0
Allow chunk size to be specified per torrent
2015-07-15 15:31:18 +10:00
4807f12ea1
When seeding, actually seed beyond 6 chunks
2015-07-15 15:29:53 +10:00
08f89c49f3
Don't raise piece priority while hashing or if piece complete
2015-07-04 13:38:42 +10:00
fd2824f595
Raise socketsPerTorrent to 80
2015-06-30 00:46:43 +10:00
bb28ff7492
Replace pruning timer with as-required connection dropping
2015-06-30 00:45:26 +10:00
1595f65ac2
Adjust some expvars
2015-06-30 00:35:47 +10:00
2277e16dca
Rename and sort some of the expvars
2015-06-28 16:41:51 +10:00
dd34efad57
Comments and update version strings
2015-06-28 16:40:46 +10:00
4f293ca75b
Several trivial fixes
2015-06-28 16:39:04 +10:00
4b6c8b1c39
Move methods to correct file
2015-06-23 02:02:22 +10:00
b5ee4f602d
Document ConfigDir
2015-06-22 19:48:50 +10:00
ad6fec2e77
Clarify downloaded chunk counters
2015-06-22 19:48:30 +10:00
859129fb28
Print peer IDs as escaped ascii
2015-06-22 19:46:26 +10:00
99a06e3f50
Move IP blocklist loading into iplist package
2015-06-22 19:44:59 +10:00
b2b290a589
Small tweak to readahead, and fix the tests
2015-06-16 17:14:15 +10:00
ced5733c88
Improve uploading/seeding
2015-06-16 16:57:47 +10:00
764f5db512
Make readahead always at least 2 blocks.
2015-06-16 16:54:12 +10:00
d63c5e5b98
Don't try to connect again without encryption, if encryption is disabled
2015-06-08 18:16:01 +10:00
5014b62e17
Reduce log noise due to uTP connection timeouts
2015-06-03 22:44:03 +10:00
005ca8124a
Fix rare single-torrent stall due to obsolete ceaseNetworking call
...
Only occurred if you have a data backend that can drop completed pieces, and it happened that you wanted to redownload data that had been dropped after completely downloading the torrent in the past.
2015-06-03 22:43:40 +10:00
7e8ee950bc
Docs and comments
2015-06-03 13:30:55 +10:00
a2df9f8b01
Miscellaneous changes
2015-06-03 00:03:43 +10:00
5de6abd6a7
Fix race to set IPBlocklist on DHT before it bootstraps and serves
2015-06-02 23:58:49 +10:00
5b52769523
Changes to the way piece prioritization affects the piece
2015-06-01 18:23:35 +10:00
21fb4933fc
Change the way piece state is exposed to give more detail
2015-06-01 18:22:12 +10:00
bc4aa06c91
Comments
2015-06-01 18:17:14 +10:00
7f9d6eed78
Relax pedantic listen addr matching
...
Fixes #15 .
2015-05-20 18:14:42 +10:00
085dbaa8ff
Include reason for panic on different listener addresses
2015-05-20 15:45:58 +10:00
1cf591dc3d
Switch to using a slice for tracking pending chunks. Saves massive amounts of memory.
2015-05-16 10:51:48 +10:00
0d13293d71
Support seeding
2015-05-15 08:39:53 +10:00
5eb6b5286e
Rare panic: a piece is requested that shouldn't have been
2015-05-09 11:52:52 +10:00
ca74d8ed33
Made Torrent.GotInfo a function, to avoid use of zero-initialized channel
2015-04-30 00:30:19 +10:00
0ec0302d1c
Publicly expose Torrent.GotInfo
2015-04-28 15:24:17 +10:00
526d9d738e
Rewrite imports to local bencode and metainfo
2015-04-27 14:55:01 +10:00
cc6a52fee0
Remove all the old intermediate config fields from Client
2015-04-27 14:05:27 +10:00
b37f6d6f96
Add the option to disable encryption
2015-04-20 17:30:22 +10:00
Matt Joiner