f8ea50cc7a
Remove unused lock ( #9710 )
2020-01-11 19:06:39 +00:00
0e53a16cca
Missed q.lock.Unlock() will cause panic ( #9706 )
2020-01-11 17:05:24 +00:00
7eaba6ba8a
Never allow an empty password to validate ( #9682 ) ( #9683 )
...
* Restore IsPasswordSet previous value
* Update models/user.go
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-01-11 16:27:03 +02:00
ff16099c6d
Don't attempt to close issue if already closed ( #9699 )
2020-01-11 01:42:11 -05:00
a516a7ba0f
Load milestone in API PR list ( #9671 ) ( #9700 )
2020-01-10 22:58:03 -05:00
11bce6fd3d
eliminate horizontal scroll caused by footer ( #9674 )
...
Co-authored-by: zeripath <art27@cantab.net>
2020-01-10 08:45:59 +08:00
3fb906dc02
remove google font call ( #9668 ) ( #9681 )
2020-01-09 16:40:57 -05:00
3a00a690c9
Prevent redirect to Host ( #9678 ) ( #9679 )
2020-01-09 16:37:37 -05:00
a2b7cc1bb1
Fix nil reference in repo generation ( #9660 ) ( #9666 )
...
* Fix nil reference
Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Tighten
Signed-off-by: jolheiser <john.olheiser@gmail.com>
2020-01-09 16:50:21 +00:00
04a77b1f42
Add HTML URL to API Issues ( #9654 ) ( #9661 )
...
* Add HTML URL to API Issues
Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Swagger
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-01-09 08:07:21 +02:00
f523372d07
Add PR review webhook to Telegram ( #9653 ) ( #9655 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
2020-01-08 21:42:28 +02:00
e39c238ef4
fix #9648 ( #9652 )
2020-01-08 17:32:25 +01:00
bb4476908d
Changelog for 1.11.0-RC1 ( #9636 )
...
* generated Changelog
* cormat, sort, fix
* teamwork :)
Co-Authored-By: techknowlogick <matti@mdranta.net>
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com>
* next()
* Next()
* add last change
* as @jolheiser suggested
* Apply suggestions from code review
Co-Authored-By: techknowlogick <matti@mdranta.net>
* Apply suggestions from code review
* Update CHANGELOG.md
* Update CHANGELOG.md
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com>
* Update CHANGELOG.md
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* add bugfix + topic is plural
* rest
* Apply suggestions from code review
* Apply suggestions from code review
Co-Authored-By: techknowlogick <matti@mdranta.net>
Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com>
Co-authored-by: zeripath <art27@cantab.net>
2020-01-08 10:57:44 +08:00
c181070f9e
Repository teams - disable remove button when have access to all ( #9640 )
...
Co-authored-by: zeripath <art27@cantab.net>
2020-01-08 08:36:39 +08:00
1e9b3d4743
Fix #9530 : admin auth list make readable and admin auth delete bug fix ( #9628 )
2020-01-07 23:41:16 +00:00
b9309e52f0
Move wiki related funtions from models to services/wiki ( #9355 )
...
* Move wiki related funtions from models to services/wiki
2020-01-07 18:27:36 +00:00
e5d8e2d10c
Branches not at ref commit ID should not be listed as Merged ( #9614 )
...
Once a branch has been merged if the commit ID no longer equals that of
the pulls ref commit id don't offer to delete the branch on the pull screen
and don't list it as merged on branches.
Fix #9201
When looking at the pull page we should also get the commits from the refs/pulls/x/head
Fix #9158
2020-01-07 17:06:14 +00:00
9406368633
Fix Issue Unsubscription ( #9634 )
2020-01-07 15:41:35 +00:00
b6fa229dcf
[skip ci] Updated translations via Crowdin
2020-01-07 14:32:33 +00:00
0d515474b8
Remove stray printf ( #9631 )
2020-01-07 14:30:03 +00:00
c88f0fed36
[skip ci] Updated translations via Crowdin
2020-01-07 11:24:19 +00:00
62eb1b0f25
Graceful Queues: Issue Indexing and Tasks ( #9363 )
...
* Queue: Add generic graceful queues with settings
* Queue & Setting: Add worker pool implementation
* Queue: Add worker settings
* Queue: Make resizing worker pools
* Queue: Add name variable to queues
* Queue: Add monitoring
* Queue: Improve logging
* Issues: Gracefulise the issues indexer
Remove the old now unused specific queues
* Task: Move to generic queue and gracefulise
* Issues: Standardise the issues indexer queue settings
* Fix test
* Queue: Allow Redis to connect to unix
* Prevent deadlock during early shutdown of issue indexer
* Add MaxWorker settings to queues
* Merge branch 'master' into graceful-queues
* Update modules/indexer/issues/indexer.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Update modules/indexer/issues/indexer.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Update modules/queue/queue_channel.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Update modules/queue/queue_disk.go
* Update modules/queue/queue_disk_channel.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Rename queue.Description to queue.ManagedQueue as per @guillep2k
* Cancel pool workers when removed
* Remove dependency on queue from setting
* Update modules/queue/queue_redis.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* As per @guillep2k add mutex locks on shutdown/terminate
* move unlocking out of setInternal
* Add warning if number of workers < 0
* Small changes as per @guillep2k
* No redis host specified not found
* Clean up documentation for queues
* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md
* Update modules/indexer/issues/indexer_test.go
* Ensure that persistable channel queue is added to manager
* Rename QUEUE_NAME REDIS_QUEUE_NAME
* Revert "Rename QUEUE_NAME REDIS_QUEUE_NAME"
This reverts commit 1f83b4fc9b9dabda186257b38c265fe7012f90df.
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-01-07 12:23:09 +01:00
f71e1c8e79
[skip ci] Updated translations via Crowdin
2020-01-07 07:40:50 +00:00
143f88d975
More extensive robots.txt docs ( #9566 )
2020-01-07 07:38:22 +00:00
5749b26cdd
[skip ci] Updated translations via Crowdin
2020-01-06 16:52:05 +00:00
abc0f53539
Add a /user/login landing page option ( #9622 )
...
* Add a /user/login landing page option
* Add test case for login landing page
2020-01-06 17:50:44 +01:00
bcac7cb934
fix swagger description of reaction API ( #9617 )
2020-01-06 06:58:13 +02:00
2a1cf5bae9
Add some padding to the shadowed comment box ( #9612 )
...
* Add some padding to the shadowed comment box
* prevent the padding affecting the other comments
2020-01-05 19:25:27 +00:00
133ae18b61
[BugFix] Hide public repos owned by private orgs ( #9609 )
...
* Restrict AllPublic to actually public repos.
* Add new parameter to add in AllLimited Repos
2020-01-05 18:48:47 +00:00
7e4f490482
[Docs] introduce "make help" ( #9604 )
...
* introduce "make help"
* fix + add more routienes
* Update Makefile
* add make vet
Co-authored-by: techknowlogick <matti@mdranta.net>
2020-01-05 12:40:02 -05:00
444c3a1184
[skip ci] Updated translations via Crowdin
2020-01-05 14:30:20 +00:00
a5a79f702d
update gitea.com/macaron/macaron to 1.4.0 ( #9608 )
2020-01-05 15:27:25 +01:00
4f54a4628a
!important makes me sad ( #9607 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com>
2020-01-05 06:56:06 +02:00
08424648ae
Fix create bugs ( #9606 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com>
2020-01-04 21:39:14 -05:00
03d59bcd1d
Fix access issues on milestone and issue overview pages. ( #9603 )
...
* Fix access issues on milestone and issue overview pages.
* Fix filter algorithm
2020-01-04 20:23:29 -05:00
8b24073713
Only serve attachments when linked to issue/release and if accessible by user ( #9340 )
...
* test: add current attachement responses
* refactor: check if attachement is linked and accessible by user
* chore: clean TODO
* fix: typo attachement -> attachment
* revert un-needed go.sum change
* refactor: move models logic to models
* fix TestCreateIssueAttachment which was wrongly successful
* fix unit tests with unittype added
* fix unit tests with changes
* use a valid uuid format for pgsql int. test
* test: add unit test TestLinkedRepository
* refactor: allow uploader to access unlinked attachement
* add missing blank line
* refactor: move to a separate function repo.GetAttachment
* typo
* test: remove err test return
* refactor: use repo perm for access checking generally + 404 for all reject
2020-01-05 01:20:08 +02:00
6a5a2f493a
[skip ci] Updated translations via Crowdin
2020-01-04 22:21:24 +00:00
fb3a6aba7d
Only show sender if it makes sense ( #9601 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com>
2020-01-04 22:20:15 +00:00
07439d8059
[skip ci] Updated translations via Crowdin
2020-01-04 20:29:45 +00:00
2b8b0f66ed
Add translatable Powered by Gitea text in footer ( #9600 )
2020-01-04 20:27:19 +00:00
ee9b9365be
[Docs] Add guide on howto develop API ( #9587 )
...
* draft 1
* add suggestions
thanks to @bagasme @techknowlogick @davidsvantesson
* http methods
* use permalinks
* Apply suggestions from code review
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com>
* Apply suggestions from code review
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com>
* code format + add to INDEX
Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-01-04 10:23:40 +08:00
bedd7b2833
Fix error logged when repos qs is empty ( #9591 )
...
* Fix error logged when repos qs is empty
* Update routers/user/home.go
Co-Authored-By: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-01-03 23:39:12 +02:00
4a768e1c3e
[skip ci] Updated translations via Crowdin
2020-01-03 18:44:08 +00:00
34c5eee703
Add footer extra links template ( #9576 )
...
* Add footer extra links template
* [Docs] Update to mention extra links footer template
* Commit suggestion from @davidsvantesson
Co-Authored-By: David Svantesson <davidsvantesson@gmail.com>
* Move template placement to right side of footer
Co-authored-by: David Svantesson <davidsvantesson@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-01-03 20:41:56 +02:00
ea707f5a77
Add branch protection option to block merge on requested changes. ( #9592 )
...
* Add branch protection option to block merge on requested changes.
* Add migration step
* Fix check to correct negation
* Apply suggestions from code review
Language improvement.
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com>
* Copyright year.
Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-01-03 19:47:09 +02:00
b39fab41c8
Some more e-mail notification fixes ( #9596 )
...
* Some more e-mail notification fixes
A few more small e-mail notification fixes/changes
* Style footer of notification email to be smaller
* Include text for when pull request is merged
* Don't include original body of issue or PR when merging/closing by
setting issue.Content to "" in these cases
* Set Re: prefix and meessage-ID headers based on actName instead of checking for a
comment. This fixes a bug where certain actions that didn't have a
comment were setting Message-ID instead of In-Reply-To which caused some
mail programs not to show those messages as they would have had the same
Message-ID as a previous message. Also fixes the case where a final
comment and closing message would have been displayed out of order if
you didn't have a copy of the original issue/pr cretion message.
* Update other template footers for consistency
2020-01-03 19:13:22 +02:00
134e3fdf3d
[API] dont reqToken on GetReactions ( fix #9543 ) ( #9548 )
...
* dont reqToken on GetReactions
* ctx.Repo.CanWrite has ctx.User.IsAdmin in It
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-01-02 23:27:31 +02:00
b3c5b4b0d1
Update version in docs ( #9588 )
2020-01-02 17:53:08 +02:00
09bf77bc4f
[skip ci] Updated translations via Crowdin
2020-01-02 12:18:28 +00:00
4ab072d9c2
Changelog for 1.10.2 ( #9586 )
2020-01-02 14:15:30 +02:00
zeripath