From 7eaef74561c27865496505913d19eec7bb3fbcf5 Mon Sep 17 00:00:00 2001 From: Pablo Galindo Salgado Date: Fri, 31 Jan 2025 14:08:48 +0000 Subject: [PATCH] gh-129430: Make walking vm regions more efficient in MacOS (#129494) --- Modules/_testexternalinspection.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Modules/_testexternalinspection.c b/Modules/_testexternalinspection.c index 5a28c0e26622..22074c81b740 100644 --- a/Modules/_testexternalinspection.c +++ b/Modules/_testexternalinspection.c @@ -232,15 +232,15 @@ search_map_for_section(pid_t pid, const char* secname, const char* substr) { &count, &object_name) == KERN_SUCCESS) { - int path_len = proc_regionfilename( - pid, address, map_filename, MAXPATHLEN); - if (path_len == 0) { + if ((region_info.protection & VM_PROT_READ) == 0 + || (region_info.protection & VM_PROT_EXECUTE) == 0) { address += size; continue; } - if ((region_info.protection & VM_PROT_READ) == 0 - || (region_info.protection & VM_PROT_EXECUTE) == 0) { + int path_len = proc_regionfilename( + pid, address, map_filename, MAXPATHLEN); + if (path_len == 0) { address += size; continue; }