Merge r66115 forward to py3k, resolves issue3419

This commit is contained in:
Jesse Noller 2008-09-02 19:12:20 +00:00
parent 9f76e4f127
commit 824f4f3cdc
1 changed files with 14 additions and 7 deletions

View File

@ -378,7 +378,13 @@ def create(self, c, typeid, *args, **kwds):
self.id_to_obj[ident] = (obj, set(exposed), method_to_typeid)
if ident not in self.id_to_refcount:
self.id_to_refcount[ident] = None
self.id_to_refcount[ident] = 0
# increment the reference count immediately, to avoid
# this object being garbage collected before a Proxy
# object for it can be created. The caller of create()
# is responsible for doing a decref once the Proxy object
# has been created.
self.incref(c, ident)
return ident, tuple(exposed)
finally:
self.mutex.release()
@ -400,11 +406,7 @@ def accept_connection(self, c, name):
def incref(self, c, ident):
self.mutex.acquire()
try:
try:
self.id_to_refcount[ident] += 1
except TypeError:
assert self.id_to_refcount[ident] is None
self.id_to_refcount[ident] = 1
self.id_to_refcount[ident] += 1
finally:
self.mutex.release()
@ -641,6 +643,8 @@ def temp(self, *args, **kwds):
token, self._serializer, manager=self,
authkey=self._authkey, exposed=exp
)
conn = self._Client(token.address, authkey=self._authkey)
dispatch(conn, None, 'decref', (token.id,))
return proxy
temp.__name__ = typeid
setattr(cls, typeid, temp)
@ -733,10 +737,13 @@ def _callmethod(self, methodname, args=(), kwds={}):
elif kind == '#PROXY':
exposed, token = result
proxytype = self._manager._registry[token.typeid][-1]
return proxytype(
proxy = proxytype(
token, self._serializer, manager=self._manager,
authkey=self._authkey, exposed=exposed
)
conn = self._Client(token.address, authkey=self._authkey)
dispatch(conn, None, 'decref', (token.id,))
return proxy
raise convert_to_error(kind, result)
def _getvalue(self):