mirrors
/
cpython
mirror of https://github.com/python/cpython.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bpo-37321: Edit IDLE subprocess connection error messages. (#14170) 

Mainly, add a doc reference to message in pyshell.
This commit is contained in:
Terry Jan Reedy 2019-06-17 17:23:28 -04:00 committed by GitHub
parent 5bff3c86ab
commit 8fac122109
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/idlelib/NEWS.txt
View File

@ -3,6 +3,9 @@ Released on 2019-10-20?
====================================== ======================================
bpo-37321: Both subprocess connection error messages now refer to
the 'Startup failure' section of the IDLE doc.
bpo-37039: Adjust "Zoom Height" to individual screens by momemtarily bpo-37039: Adjust "Zoom Height" to individual screens by momemtarily
maximizing the window on first use with a particular screen. Changing maximizing the window on first use with a particular screen. Changing
screen settings may invalidate the saved height. While a window is screen settings may invalidate the saved height. While a window is

8
Lib/idlelib/pyshell.py
View File

@ -824,10 +824,10 @@ def display_port_binding_error(self):
def display_no_subprocess_error(self): def display_no_subprocess_error(self):
tkMessageBox.showerror( tkMessageBox.showerror(
"Subprocess Startup Error", "Subprocess Connection Error",
"IDLE's subprocess didn't make connection. Either IDLE can't " "IDLE's subprocess didn't make connection.\n"
"start a subprocess or personal firewall software is blocking " "See the 'Startup failure' section of the IDLE doc, online at\n"
"the connection.", "https://docs.python.org/3/library/idle.html#startup-failure",
parent=self.tkconsole.text) parent=self.tkconsole.text)
def display_executing_dialog(self): def display_executing_dialog(self):

12
Lib/idlelib/run.py
View File

@ -199,11 +199,13 @@ def show_socket_error(err, address):
root = tkinter.Tk() root = tkinter.Tk()
fix_scaling(root) fix_scaling(root)
root.withdraw() root.withdraw()
msg = f"IDLE's subprocess can't connect to {address[0]}:{address[1]}.\n"\ showerror(
f"Fatal OSError #{err.errno}: {err.strerror}.\n"\ "Subprocess Connection Error",
f"See the 'Startup failure' section of the IDLE doc, online at\n"\ f"IDLE's subprocess can't connect to {address[0]}:{address[1]}.\n"
f"https://docs.python.org/3/library/idle.html#startup-failure" f"Fatal OSError #{err.errno}: {err.strerror}.\n"
showerror("IDLE Subprocess Error", msg, parent=root) "See the 'Startup failure' section of the IDLE doc, online at\n"
"https://docs.python.org/3/library/idle.html#startup-failure",
parent=root)
root.destroy() root.destroy()
def print_exception(): def print_exception():

2
Misc/NEWS.d/next/IDLE/2019-06-17-16-35-30.bpo-37321.zVTTGS.rst Normal file
View File

@ -0,0 +1,2 @@
Both subprocess connection error messages now refer to the 'Startup failure'
section of the IDLE doc.