mirrors
/
cpython
mirror of https://github.com/python/cpython.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bpo-34970: Protect tasks weak set manipulation in asyncio.all_tasks() (GH-9837) 

https://bugs.python.org/issue34970
This commit is contained in:
Andrew Svetlov 2018-10-13 21:12:40 +03:00 committed by Miss Islington (bot)
parent 1a997eb291
commit 97cf082872
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Lib/asyncio/tasks.py
View File

@ -42,7 +42,9 @@ def all_tasks(loop=None):
"""Return a set of all tasks for the loop.""" """Return a set of all tasks for the loop."""
if loop is None: if loop is None:
loop = events.get_running_loop() loop = events.get_running_loop()
return {t for t in _all_tasks # NB: set(_all_tasks) is required to protect
# from https://bugs.python.org/issue34970 bug
return {t for t in list(_all_tasks)
if futures._get_loop(t) is loop and not t.done()} if futures._get_loop(t) is loop and not t.done()}
@ -52,7 +54,9 @@ def _all_tasks_compat(loop=None):
# method. # method.
if loop is None: if loop is None:
loop = events.get_event_loop() loop = events.get_event_loop()
return {t for t in _all_tasks if futures._get_loop(t) is loop} # NB: set(_all_tasks) is required to protect
# from https://bugs.python.org/issue34970 bug
return {t for t in list(_all_tasks) if futures._get_loop(t) is loop}
def _set_task_name(task, name): def _set_task_name(task, name):

1
Misc/NEWS.d/next/Library/2018-10-13-11-14-13.bpo-34970.SrJTY7.rst Normal file
View File

@ -0,0 +1 @@
Protect tasks weak set manipulation in ``asyncio.all_tasks()``