mirrors
/
cpython
mirror of https://github.com/python/cpython.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Removed addbase.__del__ because it can't work. 

If code keeps a reference to self.fp or any of its methods, you don't
want to close self.fp just because no explicit reference is kept to self.
This commit is contained in:
Sjoerd Mullender 1995-08-15 11:33:39 +00:00
parent ebed45fe0f
commit 9c4585acfa
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Lib/urllib.py
View File

@ -442,8 +442,12 @@ def __init__(self, fp):
def __repr__(self): def __repr__(self):
return '<%s at %s whose fp = %s>' % ( return '<%s at %s whose fp = %s>' % (
self.__class__.__name__, `id(self)`, `self.fp`) self.__class__.__name__, `id(self)`, `self.fp`)
def __del__(self): # Removed this __del__ because it can't work like this. If a
self.close() # reference is kept to self.fp or any of its methods, but no reference
# is kept to self, we don't want to close self.fp (which would happen
# if this __del__ still existed).
# def __del__(self):
# self.close()
def close(self): def close(self):
self.read = None self.read = None
self.readline = None self.readline = None