mirror of https://github.com/python/cpython.git
gh-130167: Improve ``difflib.IS_LINE_JUNK`` performance by using string methods (#130170)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Tim Peters <tim.peters@gmail.com>
This commit is contained in:
parent
b99d970bcd
commit
bce45bcaf8
|
@ -1038,11 +1038,9 @@ def _qformat(self, aline, bline, atags, btags):
|
|||
# remaining is that perhaps it was really the case that " volatile"
|
||||
# was inserted after "private". I can live with that <wink>.
|
||||
|
||||
import re
|
||||
|
||||
def IS_LINE_JUNK(line, pat=re.compile(r"\s*(?:#\s*)?$").match):
|
||||
def IS_LINE_JUNK(line, pat=None):
|
||||
r"""
|
||||
Return True for ignorable line: iff `line` is blank or contains a single '#'.
|
||||
Return True for ignorable line: if `line` is blank or contains a single '#'.
|
||||
|
||||
Examples:
|
||||
|
||||
|
@ -1054,6 +1052,11 @@ def IS_LINE_JUNK(line, pat=re.compile(r"\s*(?:#\s*)?$").match):
|
|||
False
|
||||
"""
|
||||
|
||||
if pat is None:
|
||||
# Default: match '#' or the empty string
|
||||
return line.strip() in '#'
|
||||
# Previous versions used the undocumented parameter 'pat' as a
|
||||
# match function. Retain this behaviour for compatibility.
|
||||
return pat(line) is not None
|
||||
|
||||
def IS_CHARACTER_JUNK(ch, ws=" \t"):
|
||||
|
@ -2027,7 +2030,6 @@ def make_table(self,fromlines,tolines,fromdesc='',todesc='',context=False,
|
|||
replace('\1','</span>'). \
|
||||
replace('\t',' ')
|
||||
|
||||
del re
|
||||
|
||||
def restore(delta, which):
|
||||
r"""
|
||||
|
|
|
@ -0,0 +1 @@
|
|||
Improve speed of :func:`difflib.IS_LINE_JUNK`. Patch by Semyon Moroz.
|
Loading…
Reference in New Issue