only use -fno-strict-aliasing when needed by compiler

This commit is contained in:
Benjamin Peterson 2010-06-21 17:04:07 +00:00
parent f7155a38cd
commit c2037d6ec8
2 changed files with 83 additions and 26 deletions

71
configure vendored
View File

@ -5295,33 +5295,72 @@ UNIVERSAL_ARCH_FLAGS=
# tweak BASECFLAGS based on compiler and platform # tweak BASECFLAGS based on compiler and platform
case $GCC in case $GCC in
yes) yes)
# Python violates C99 rules, by casting between incompatible # Python doesn't violate C99 aliasing rules, but older versions of
# pointer types. GCC may generate bad code as a result of that, # GCC produce warnings for legal Python code. Enable
# so use -fno-strict-aliasing if supported. # -fno-strict-aliasing on versions of GCC that support but produce
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC accepts -fno-strict-aliasing" >&5 # warnings. See Issue3326
$as_echo_n "checking whether $CC accepts -fno-strict-aliasing... " >&6; } { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC accepts and needs -fno-strict-aliasing" >&5
$as_echo_n "checking whether $CC accepts and needs -fno-strict-aliasing... " >&6; }
ac_save_cc="$CC" ac_save_cc="$CC"
CC="$CC -fno-strict-aliasing" CC="$CC -fno-strict-aliasing"
if test "$cross_compiling" = yes; then : save_CFLAGS="$CFLAGS"
ac_cv_no_strict_aliasing_ok=no if test "${ac_cv_no_strict_aliasing+set}" = set; then :
$as_echo_n "(cached) " >&6
else else
cat confdefs.h - <<_ACEOF >conftest.$ac_ext cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */ /* end confdefs.h. */
int main() { return 0; }
int
main ()
{
;
return 0;
}
_ACEOF _ACEOF
if ac_fn_c_try_run "$LINENO"; then : if ac_fn_c_try_compile "$LINENO"; then :
ac_cv_no_strict_aliasing_ok=yes
CC="$ac_save_cc -fstrict-aliasing"
CFLAGS="$CFLAGS -Werror -Wstrict-aliasing"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
void f(int **x) {}
int
main ()
{
double *x; f((int **) &x);
;
return 0;
}
_ACEOF
if ac_fn_c_try_compile "$LINENO"; then :
ac_cv_no_strict_aliasing=no
else else
ac_cv_no_strict_aliasing_ok=no
ac_cv_no_strict_aliasing=yes
fi fi
rm -f core *.core core.conftest.* gmon.out bb.out conftest$ac_exeext \ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
conftest.$ac_objext conftest.beam conftest.$ac_ext
else
ac_cv_no_strict_aliasing=no
fi
rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
fi fi
CFLAGS="$save_CFLAGS"
CC="$ac_save_cc" CC="$ac_save_cc"
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_no_strict_aliasing_ok" >&5 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_no_strict_aliasing" >&5
$as_echo "$ac_cv_no_strict_aliasing_ok" >&6; } $as_echo "$ac_cv_no_strict_aliasing" >&6; }
if test $ac_cv_no_strict_aliasing_ok = yes if test $ac_cv_no_strict_aliasing = yes
then then
BASECFLAGS="$BASECFLAGS -fno-strict-aliasing" BASECFLAGS="$BASECFLAGS -fno-strict-aliasing"
fi fi

View File

@ -878,19 +878,37 @@ AC_SUBST(UNIVERSAL_ARCH_FLAGS)
# tweak BASECFLAGS based on compiler and platform # tweak BASECFLAGS based on compiler and platform
case $GCC in case $GCC in
yes) yes)
# Python violates C99 rules, by casting between incompatible # Python doesn't violate C99 aliasing rules, but older versions of
# pointer types. GCC may generate bad code as a result of that, # GCC produce warnings for legal Python code. Enable
# so use -fno-strict-aliasing if supported. # -fno-strict-aliasing on versions of GCC that support but produce
AC_MSG_CHECKING(whether $CC accepts -fno-strict-aliasing) # warnings. See Issue3326
AC_MSG_CHECKING(whether $CC accepts and needs -fno-strict-aliasing)
ac_save_cc="$CC" ac_save_cc="$CC"
CC="$CC -fno-strict-aliasing" CC="$CC -fno-strict-aliasing"
AC_TRY_RUN([int main() { return 0; }], save_CFLAGS="$CFLAGS"
ac_cv_no_strict_aliasing_ok=yes, AC_CACHE_VAL(ac_cv_no_strict_aliasing,
ac_cv_no_strict_aliasing_ok=no, AC_COMPILE_IFELSE(
ac_cv_no_strict_aliasing_ok=no) [
AC_LANG_PROGRAM([[]], [[]])
],[
CC="$ac_save_cc -fstrict-aliasing"
CFLAGS="$CFLAGS -Werror -Wstrict-aliasing"
AC_COMPILE_IFELSE(
[
AC_LANG_PROGRAM([[void f(int **x) {}]],
[[double *x; f((int **) &x);]])
],[
ac_cv_no_strict_aliasing=no
],[
ac_cv_no_strict_aliasing=yes
])
],[
ac_cv_no_strict_aliasing=no
]))
CFLAGS="$save_CFLAGS"
CC="$ac_save_cc" CC="$ac_save_cc"
AC_MSG_RESULT($ac_cv_no_strict_aliasing_ok) AC_MSG_RESULT($ac_cv_no_strict_aliasing)
if test $ac_cv_no_strict_aliasing_ok = yes if test $ac_cv_no_strict_aliasing = yes
then then
BASECFLAGS="$BASECFLAGS -fno-strict-aliasing" BASECFLAGS="$BASECFLAGS -fno-strict-aliasing"
fi fi