mirrors
/
cpython
mirror of https://github.com/python/cpython.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[3.13] gh-120039: Reduce expected timeout in test_siginterrupt_off (GH-120047) (#120060) 

The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
(cherry picked from commit d419d468ff)

Co-authored-by: Sam Gross <colesbury@gmail.com>
This commit is contained in:
Miss Islington (bot) 2024-06-04 20:11:01 +02:00 committed by GitHub
parent 8d74eae4d4
commit fd5428d2d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Lib/test/test_signal.py
View File

@ -698,7 +698,7 @@ def handler(signum, frame):
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()") @unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
class SiginterruptTest(unittest.TestCase): class SiginterruptTest(unittest.TestCase):
def readpipe_interrupted(self, interrupt): def readpipe_interrupted(self, interrupt, timeout=support.SHORT_TIMEOUT):
"""Perform a read during which a signal will arrive. Return True if the """Perform a read during which a signal will arrive. Return True if the
read is interrupted by the signal and raises an exception. Return False read is interrupted by the signal and raises an exception. Return False
if it returns normally. if it returns normally.
@ -746,7 +746,7 @@ def handler(signum, frame):
# wait until the child process is loaded and has started # wait until the child process is loaded and has started
first_line = process.stdout.readline() first_line = process.stdout.readline()
stdout, stderr = process.communicate(timeout=support.SHORT_TIMEOUT) stdout, stderr = process.communicate(timeout=timeout)
except subprocess.TimeoutExpired: except subprocess.TimeoutExpired:
process.kill() process.kill()
return False return False
@ -777,7 +777,7 @@ def test_siginterrupt_off(self):
# If a signal handler is installed and siginterrupt is called with # If a signal handler is installed and siginterrupt is called with
# a false value for the second argument, when that signal arrives, it # a false value for the second argument, when that signal arrives, it
# does not interrupt a syscall that's in progress. # does not interrupt a syscall that's in progress.
interrupted = self.readpipe_interrupted(False) interrupted = self.readpipe_interrupted(False, timeout=2)
self.assertFalse(interrupted) self.assertFalse(interrupted)