mirrors
/
cpython
mirror of https://github.com/python/cpython.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gh-112795: Move the test for ZipFile into the core tests for zipfile. (#116823) 

Move the test for ZipFile into the core tests for zipfile.
This commit is contained in:
Jason R. Coombs 2024-03-14 13:50:24 -04:00 committed by GitHub
parent 61e54bfcee
commit fd8e30eb62
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Lib/test/test_zipfile/_path/test_path.py
View File

@ -577,15 +577,3 @@ def test_getinfo_missing(self, alpharep):
zipfile.Path(alpharep) zipfile.Path(alpharep)
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
alpharep.getinfo('does-not-exist') alpharep.getinfo('does-not-exist')
def test_root_folder_in_zipfile(self):
"""
gh-112795: Some tools or self constructed codes will add '/' folder to
the zip file, this is a strange behavior, but we should support it.
"""
in_memory_file = io.BytesIO()
zf = zipfile.ZipFile(in_memory_file, "w")
zf.mkdir('/')
zf.writestr('./a.txt', 'aaa')
tmpdir = pathlib.Path(self.fixtures.enter_context(temp_dir()))
zf.extractall(tmpdir)

11
Lib/test/test_zipfile/test_core.py
View File

@ -3033,6 +3033,17 @@ def test_create_directory_with_write(self):
self.assertEqual(set(os.listdir(target)), {"directory", "directory2"}) self.assertEqual(set(os.listdir(target)), {"directory", "directory2"})
def test_root_folder_in_zipfile(self):
"""
gh-112795: Some tools or self constructed codes will add '/' folder to
the zip file, this is a strange behavior, but we should support it.
"""
in_memory_file = io.BytesIO()
zf = zipfile.ZipFile(in_memory_file, "w")
zf.mkdir('/')
zf.writestr('./a.txt', 'aaa')
zf.extractall(TESTFN2)
def tearDown(self): def tearDown(self):
rmtree(TESTFN2) rmtree(TESTFN2)
if os.path.exists(TESTFN): if os.path.exists(TESTFN):