51d4bf1e0e
bpo-45325: Add a new 'p' parameter to Py_BuildValue to convert an integer into a Python bool ( #28634 )
2025-02-18 17:14:11 +00:00
46ac85e4d9
gh-129989: Change Py_TAIL_CALL_INTERP ifndef to ! ( #130269 )
...
Change Py_TAIL_CALL_INTERP ifndef to !
2025-02-18 15:48:49 +00:00
c9b1bf302c
gh-130139: always check ast node type in ast.parse() with ast input ( #130140 )
2025-02-16 13:32:39 +00:00
359c7dde3b
gh-129989: Properly disable tailcall interp in configure (GH-129991)
...
Co-authored-by: Zanie Blue <contact@zanie.dev>
2025-02-16 03:01:24 +08:00
1775091dc1
gh-129173: Use `_PyUnicodeError_GetParams` in `PyCodec_SurrogatePassErrors` (GH-129134)
2025-02-14 18:34:32 +01:00
334589f619
gh-126835: Set location for noped out instructions after constant folding in CFG. ( #130109 )
2025-02-14 14:15:08 +00:00
451f291baa
gh-128130: Fix unhandled keyboard interrupt data race (gh-129975)
...
Use an atomic operation when setting
`_PyRuntime.signals.unhandled_keyboard_interrupt`. We now only clear the
variable at the start of `_PyRun_Main`, which is the same function where
we check it.
This avoids race conditions where previously another thread might call
`run_eval_code_obj()` and erroneously clear the unhandled keyboard
interrupt.
2025-02-13 12:29:03 -05:00
0559339ccd
gh-130019: Fix data race in _PyType_AllocNoTrack (gh-130058)
...
The reference count fields, such as `ob_tid` and `ob_ref_shared`, may be
accessed concurrently in the free threading build by a `_Py_TryXGetRef`
or similar operation. The PyObject header fields will be initialized by
`_PyObject_Init`, so only call `memset()` to zero-initialize the remainder
of the allocation.
2025-02-13 11:50:45 -05:00
140e69c4a8
gh-126835: Move const folding of lists & sets from ast_opt.c to flowgraph.c ( #130032 )
2025-02-13 12:11:07 +00:00
e09442089e
gh-130030: Fix crash on 32-bit Linux with free threading (gh-130043)
...
The `gc_get_refs` assertion needs to be after we check the alive and
unreachable bits. Otherwise, `ob_tid` may store the actual thread id
instead of the computed `gc_refs`, which may trigger the assertion if
the `ob_tid` looks like a negative value.
Also fix a few type warnings on 32-bit systems.
2025-02-12 18:09:15 -05:00
1b27f36eb0
gh-129819: Allow tier2/JIT and tailcall (GH-129820)
2025-02-13 02:18:36 +08:00
11bb08e4ec
GH-129715: Don't project traces that return to an unknown caller (GH-130024)
2025-02-12 10:16:43 -08:00
72f56654d0
GH-128682: Account for escapes in `DECREF_INPUTS` (GH-129953)
...
* Handle escapes in DECREF_INPUTS
* Mark a few more functions as escaping
* Replace DECREF_INPUTS with PyStackRef_CLOSE where possible
2025-02-12 17:44:59 +00:00
469d2e416c
gh-129889: Support context manager protocol by contextvars.Token ( #129888 )
2025-02-12 12:32:58 +01:00
e1b38ea82e
Update manpage environment variables and command line arguments ( #129623 )
...
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
2025-02-12 13:00:35 +02:00
00ec781877
gh-129244: Only remove the workaround when MSVC has the bugfix ( #130011 )
2025-02-11 14:49:42 -05:00
5cdd6e5e75
gh-130004: Disable PGO for ceval.c on MSVC for default build (GH-130009)
...
Disable PGO for ceval.c on MSVC on default build
2025-02-12 01:13:05 +08:00
247b50dec8
gh-130004: Revert commit 9e52e55 (GH-130005)
...
Revert commit 9e52e55
2025-02-11 23:23:58 +08:00
91d9544112
gh-126835: Make CFG optimizer skip over NOP's when looking for const sequence construction ( #129703 )
...
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
2025-02-09 18:00:41 +00:00
a56ead089c
gh-129173: Use `_PyUnicodeError_GetParams` in `PyCodec_NameReplaceErrors` (GH-129135)
2025-02-08 16:01:57 +01:00
a1417b211f
gh-100239: replace BINARY_SUBSCR & family by BINARY_OP with oparg NB_SUBSCR ( #129700 )
2025-02-07 22:39:54 +00:00
5fa7e1b7fd
GH-129715: Remove _DYNAMIC_EXIT (GH-129716)
2025-02-07 11:41:17 -08:00
70e387c990
GH-129709: Clean up tier two (GH-129710)
2025-02-07 09:52:49 -08:00
fbaa6c8ff0
GH-129763: Remove the LLTRACE macro (GH-129764)
2025-02-07 08:49:51 -08:00
175844713a
gh-128563: Move assignment of opcode into ifdef (GH-129803)
2025-02-07 21:11:57 +08:00
ae132edc29
gh-129766: Fix crash on calling `warnings._release_lock` with no lock ( #129771 )
2025-02-07 12:59:52 +03:00
b184abf074
gh-129533: Update PyGC_Enable/Disable/IsEnabled to use atomic operation (gh-129563)
2025-02-07 07:41:13 +09:00
0d68b14a0d
gh-128002: use per threads tasks linked list in asyncio ( #128869 )
...
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
2025-02-06 19:51:07 +01:00
b4ff8b22b3
gh-129732: Fix race on `shared->array` in qsbr code under free-threading (gh-129738)
...
The read of `shared->array` should happen under the lock to avoid a race.
2025-02-06 18:49:29 +00:00
cb640b659e
gh-128563: A new tail-calling interpreter (GH-128718)
...
Co-authored-by: Garrett Gu <garrettgu777@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
2025-02-06 23:21:57 +08:00
cdcacec79f
gh-129201: Use prefetch in GC mark alive phase. (gh-129203)
...
For the free-threaded version of the cyclic GC, restructure the "mark alive" phase to use software prefetch instructions. This gives a speedup in most cases when the number of objects is large enough. The prefetching is enabled conditionally based on the number of long-lived objects the GC finds.
2025-02-05 11:38:30 -08:00
a25042e6d2
gh-129354: Use PyErr_FormatUnraisable() function ( #129523 )
...
Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable().
Update tests:
* test_coroutines
* test_exceptions
* test_generators
* test_struct
2025-02-05 10:31:59 +00:00
dc804ffb2f
gh-128911: Use PyImport_ImportModuleAttr() function ( #129657 )
...
* Replace PyImport_ImportModule() + PyObject_GetAttr() with
PyImport_ImportModuleAttr().
* Replace PyImport_ImportModule() + PyObject_GetAttrString() with
PyImport_ImportModuleAttrString().
2025-02-05 11:03:58 +01:00
96ff4c2486
GH-128682: Mark two more macros as escaping. (GH-129645)
...
Expand out SETLOCAL so that code generator can see the decref. Mark Py_CLEAR as escaping
2025-02-04 14:00:51 +00:00
2effea4dab
GH-128682: Spill the stack pointer in labels, as well as instructions (GH-129618)
2025-02-04 12:18:31 +00:00
d3c54f3788
gh-126835: Fix reference leak in `Python/flowgrapc.::optimize_if_const_subscr` ( #129634 )
2025-02-04 10:38:06 +00:00
0664c1af9b
gh-126835: Move constant subscript folding to CFG ( #129568 )
...
Move folding of constant subscription from AST optimizer to CFG.
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
2025-02-04 10:10:55 +02:00
75b628adeb
GH-128563: Generate `opcode = ...` in instructions that need `opcode` (GH-129608)
...
* Remove support for GO_TO_INSTRUCTION
2025-02-03 15:09:21 +00:00
808071b994
GH-128682: Make `PyStackRef_CLOSE` escaping. (GH-129404)
2025-02-03 12:41:32 +00:00
a29a9c0f38
GH-129231: Group executable JIT code in memory (GH-129232)
2025-02-02 15:19:55 -08:00
567394517a
GH-128842: Collect JIT memory stats (GH-128941)
2025-02-02 15:17:53 -08:00
e6c76b947b
GH-128872: Remove unused argument from _PyCode_Quicken (GH-128873)
...
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
2025-02-02 15:09:30 -08:00
7d0521d5fc
gh-126835: Move optimization of constant sequence creation from codegen to CFG ( #129426 )
...
Codegen phase has an optimization that transforms
```
LOAD_CONST x
LOAD_CONST y
LOAD_CONXT z
BUILD_LIST/BUILD_SET (3)
```
->
```
BUILD_LIST/BUILD_SET (0)
LOAD_CONST (x, y, z)
LIST_EXTEND/SET_UPDATE 1
```
This optimization has now been moved to CFG phase to make #128802 work.
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Co-authored-by: Yan Yanchii <yyanchiy@gmail.com>
2025-02-01 11:39:44 +00:00
54f74b80ae
GH-128563: Move some labels, to simplify implementing tailcalling interpreter. (GH-129525)
2025-01-31 17:13:20 +00:00
9ba281d871
gh-128509: Add `sys._is_immortal` for identifying immortal objects ( #128510 )
...
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
2025-01-31 15:27:08 +00:00
fad36bf382
gh-126108: Fix potential null pointer dereference in `PySys_AddWarnOptionUnicode` ( #126118 )
2025-01-31 20:06:30 +05:30
3447f4a56a
gh-129354: Use PyErr_FormatUnraisable() function ( #129514 )
...
Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable().
2025-01-31 14:20:35 +01:00
c3ae5c9e4a
GH-128563: Simplify recursion check in `_PyEval_EvalFrameDefault` (GH-129481)
...
Simplify recursion check in _PyEval_EvalFrameDefault
2025-01-31 12:12:24 +00:00
95504f429e
gh-129354: Fix grammar in PyErr_FormatUnraisable() ( #129475 )
...
Replace "on verb+ing" with "while verb+ing".
2025-01-31 09:45:35 +01:00
4e47e05045
gh-129354: Use PyErr_FormatUnraisable() function ( #129435 )
...
Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable().
2025-01-30 16:09:38 +01:00
3bebe46d34
gh-128911: Add PyImport_ImportModuleAttr() function ( #128912 )
...
Add PyImport_ImportModuleAttr() and
PyImport_ImportModuleAttrString() functions.
* Add unit tests.
* Replace _PyImport_GetModuleAttr()
with PyImport_ImportModuleAttr().
* Replace _PyImport_GetModuleAttrString()
with PyImport_ImportModuleAttrString().
* Remove "pycore_import.h" includes, no longer needed.
2025-01-30 11:17:29 +00:00
5ff2fbc026
gh-129236: Use `stackpointer` in free threaded GC ( #129240 )
...
The stack pointers in interpreter frames are nearly always valid now, so
use them when visiting each thread's frame. For now, don't collect
objects with deferred references in the rare case that we see a frame
with a NULL stack pointer.
2025-01-29 10:40:51 -05:00
4815131910
gh-100239: specialize bitwise logical binary ops on ints ( #128927 )
2025-01-29 09:28:21 +00:00
828b27680f
GH-126599: Remove the PyOptimizer API (GH-129194)
2025-01-28 16:10:51 -08:00
5c930a26fb
gh-115999: Enable free-threaded specialization of LOAD_CONST ( #129365 )
...
Enable free-threaded specialization of LOAD_CONST.
2025-01-29 01:07:56 +01:00
75b4962157
GH-128914: Remove all but one conditional stack effects (GH-129226)
...
* Remove all 'if (0)' and 'if (1)' conditional stack effects
* Use array instead of conditional for BUILD_SLICE args
* Refactor LOAD_GLOBAL to use a common conditional uop
* Remove conditional stack effects from LOAD_ATTR specializations
* Replace conditional stack effects in LOAD_ATTR with a 0 or 1 sized array.
* Remove conditional stack effects from CALL_FUNCTION_EX
2025-01-27 16:24:48 +00:00
ced296d2c0
gh-111178: fix UBSan failures in `Python/traceback.c` (GH-128259)
2025-01-27 15:07:39 +01:00
87fb8b198c
gh-128563: Move labels in ceval.c to bytecodes.c (GH-129112)
2025-01-27 18:30:20 +08:00
c39ae8922b
gh-128799: Add frame of except* to traceback when wrapping a naked exception ( #128971 )
2025-01-25 13:00:23 +00:00
9e52e553f4
gh-129244: Remove workaround for MSVC compiler crash ( #129263 )
...
* Remove compiler workaround
* Remote _Py_USING_PGO
2025-01-25 07:56:13 -05:00
8fecb9fa0b
Remove unused DPRINTF in ceval.c (GH-129282)
...
remove unused DPRINTF in ceval.c
2025-01-25 18:33:26 +08:00
fc6bc1e4e3
gh-129185: Simplify PyTraceMalloc_Track() ( #129256 )
...
Since tracemalloc uses PyMutex, it becomes safe to use TABLES_LOCK()
even after _PyTraceMalloc_Fini(): remove the "pre-check" in
PyTraceMalloc_Track() and PyTraceMalloc_Untrack().
PyTraceMalloc_Untrack() no longer needs to acquire the GIL.
_PyTraceMalloc_Fini() can be called earlier during Python
finalization.
2025-01-24 14:29:36 +01:00
c005ea4951
gh-129185: Use PyMutex in tracemalloc ( #129246 )
2025-01-24 11:25:24 +01:00
36bb229933
gh-129173: Use `_PyUnicodeError_GetParams` in `PyCodec_IgnoreErrors` ( #129174 )
...
We also cleanup `PyCodec_StrictErrors` and the error message rendered
when an object of incorrect type is passed to codec error handlers.
2025-01-24 11:25:03 +01:00
25a614a502
gh-126004: Fix positions handling in `codecs.backslashreplace_errors` ( #127676 )
...
This fixes how `PyCodec_BackslashReplaceErrors` handles the `start` and `end`
attributes of `UnicodeError` objects via the `_PyUnicodeError_GetParams` helper.
2025-01-23 14:28:33 +01:00
e579cdb21e
gh-129185: Remove internal TRACE_RAW_MALLOC macro ( #129218 )
...
Always build tracemalloc with PyMem_RawMalloc() hooks.
2025-01-23 13:49:35 +01:00
46c7e13c05
gh-129185: Fix PyTraceMalloc_Untrack() at Python exit ( #129191 )
...
Support calling PyTraceMalloc_Track() and PyTraceMalloc_Untrack()
during late Python finalization.
* Call _PyTraceMalloc_Fini() later in Python finalization.
* Test also PyTraceMalloc_Untrack() without the GIL
* PyTraceMalloc_Untrack() now gets the GIL.
* Test also PyTraceMalloc_Untrack() in test_tracemalloc_track_race().
2025-01-23 12:07:34 +01:00
225296cd5b
gh-126004: Fix positions handling in `codecs.replace_errors` ( #127674 )
...
This fixes how `PyCodec_ReplaceErrors` handles the `start` and `end` attributes
of `UnicodeError` objects via the `_PyUnicodeError_GetParams` helper.
2025-01-23 11:44:18 +01:00
70dcc847df
gh-126004: Fix positions handling in `codecs.xmlcharrefreplace_errors` ( #127675 )
...
This fixes how `PyCodec_XMLCharRefReplaceErrors` handles the `start` and `end`
attributes of `UnicodeError` objects via the `_PyUnicodeError_GetParams` helper.
2025-01-23 11:42:38 +01:00
a10f99375e
Revert "GH-128914: Remove conditional stack effects from `bytecodes.c` and the code generators (GH-128918)" (GH-129202)
...
The commit introduced a ~2.5-3% regression in the free threading build.
This reverts commit ab61d3f430
2025-01-23 09:26:25 +00:00
d7d066c3ab
gh-127936, PEP 757: Convert marshal module to use import/export API for ints ( #128530 )
...
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
2025-01-23 02:54:23 +00:00
0093a31273
gh-119182: Use public PyUnicodeWriter in Python-ast.c ( #129209 )
...
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API.
Use PyUnicodeWriter_WriteRepr() in ast_repr_list().
2025-01-23 00:57:37 +00:00
8eb9e76b5b
gh-119182: Use public PyUnicodeWriter in ast_unparse.c ( #129208 )
...
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API.
* Add append_char() function.
* Add APPEND_CHAR() and APPEND_CHAR_FINISH() macros.
* Replace APPEND_STR() and APPEND_STR_FINISH() of single character
with APPEND_CHAR() and APPEND_CHAR_FINISH().
2025-01-23 01:44:43 +01:00
960936fe90
gh-128627: Emscripten: Fix address calculation for wasm-gc trampoline ( #128782 )
...
Modifies the memory calculation to divide the entire memory address by 4, not just the base address.
2025-01-23 08:02:04 +08:00
188598851d
GH-91048: Add utils for capturing async call stack for asyncio programs and enable profiling ( #124640 )
...
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
Co-authored-by: Jacob Coffee <jacob@z7x.org>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
2025-01-22 17:25:29 +01:00
9012fa741d
gh-128863: Deprecate private C API functions ( #128864 )
...
Deprecate private C API functions:
* _PyBytes_Join()
* _PyDict_GetItemStringWithError()
* _PyDict_Pop()
* _PyThreadState_UncheckedGet()
* _PyUnicode_AsString()
* _Py_HashPointer()
* _Py_fopen_obj()
Replace _Py_HashPointer() with Py_HashPointer().
Remove references to deprecated functions.
2025-01-22 11:04:19 +00:00
470a0a68eb
GH-128682: Change a couple of functions to only steal references on success. (GH-129132)
...
Change PyTuple_FromStackRefSteal and PyList_FromStackRefSteal to only steal on success to avoid escaping
2025-01-22 10:51:37 +00:00
86c1a60d5a
gh-128563: Move GO_TO_INSTRUCTION and PREDICT to cases generator (GH-129115)
2025-01-22 09:22:25 +08:00
5809b25909
gh-128563: Move lltrace into the frame struct (GH-129113)
2025-01-21 22:17:15 +08:00
31f149d5b3
gh-128679: Use _PyThreadState_GET() in tracemalloc.c ( #129126 )
...
Replace uncommon PyGILState_GetThisThreadState() with common
_PyThreadState_GET().
2025-01-21 14:43:31 +01:00
01de4af3e1
gh-126925: Make PyConfig.use_system_logger read-only ( #129124 )
...
The variable is only used once during early Python initialization, it
doesn't make sense to modify it at runtime.
2025-01-21 12:02:38 +01:00
f5b6356a11
GH-128563: Add new frame owner type for interpreter entry frames (GH-129078)
...
Add new frame owner type for interpreter entry frames
2025-01-21 10:15:02 +00:00
7239da7559
GH-127953: Make line number lookup O(1) regardless of the size of the code object (GH-128350)
2025-01-21 09:33:23 +00:00
ab61d3f430
GH-128914: Remove conditional stack effects from `bytecodes.c` and the code generators (GH-128918)
2025-01-20 17:09:23 +00:00
f0f7b978be
GH-128939: Refactor JIT optimize structs (GH-128940)
2025-01-20 15:49:15 +00:00
8ceb6cb117
gh-129033: Remove _PyInterpreterState_SetConfig() function ( #129048 )
...
Remove _PyInterpreterState_GetConfigCopy() and
_PyInterpreterState_SetConfig() private functions. PEP 741 "Python
Configuration C API" added a better public C API: PyConfig_Get() and
PyConfig_Set().
2025-01-20 16:31:33 +01:00
537296cdcd
gh-111178: Generate correct signature for most self converters ( #128447 )
2025-01-20 12:40:18 +01:00
4d0a6595a0
gh-128360: Add `_Py_AssertHoldsTstate` as assertion for holding a thread state ( #128361 )
...
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
2025-01-20 17:04:35 +05:30
07c3518ffb
gh-129033: Remove _Py_InitializeMain() function ( #129034 )
...
Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
2025-01-20 10:03:22 +00:00
6c52ada551
gh-100239: Handle NaN and zero division in guards for `BINARY_OP_EXTEND` ( #128963 )
...
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
2025-01-19 11:02:49 +00:00
13c4def692
gh-128955: Fix goto if tlbc creation fails when throwing into a generator ( #128957 )
...
We don't have the correct copy of the bytecode and can't update next_instr
appropriately, so just unwind.
2025-01-17 12:53:29 -08:00
d66c08aa75
gh-128923: Use zero to indicate unassigned unique id ( #128925 )
...
In the free threading build, the per thread reference counting uses a
unique id for some objects to index into the local reference count
table. Use 0 instead of -1 to indicate that the id is not assigned. This
avoids bugs where zero-initialized heap type objects look like they have
a unique id assigned.
2025-01-17 16:42:27 +01:00
b44ff6d0df
GH-126599: Remove the "counter" optimizer/executor (GH-126853)
2025-01-16 15:57:04 -08:00
3893a92d95
gh-100239: specialize long tail of binary operations ( #128722 )
2025-01-16 15:22:13 +00:00
3193cb5ef8
gh-128679: Fix tracemalloc.stop() race conditions ( #128893 )
...
tracemalloc_alloc(), tracemalloc_realloc(), tracemalloc_free(),
_PyTraceMalloc_TraceRef() and _PyTraceMalloc_GetMemory() now check
'tracemalloc_config.tracing' after calling TABLES_LOCK().
_PyTraceMalloc_TraceRef() now always returns 0.
2025-01-16 13:53:18 +01:00
36c5e3bcc2
gh-128679: Redesign tracemalloc locking ( #128888 )
...
* Use TABLES_LOCK() to protect 'tracemalloc_config.tracing'.
* Hold TABLES_LOCK() longer while accessing tables.
* tracemalloc_realloc() and tracemalloc_free() no longer
remove the trace on reentrant call.
* _PyTraceMalloc_Stop() unregisters _PyTraceMalloc_TraceRef().
* _PyTraceMalloc_GetTraces() sets the reentrant flag.
* tracemalloc_clear_traces_unlocked() sets the reentrant flag.
2025-01-15 20:22:44 +00:00
080f444a58
gh-128807: Add marking phase for free-threaded cyclic GC (gh-128808)
2025-01-15 11:27:28 -08:00
b5ee0258bf
gh-115999: Specialize `LOAD_ATTR` for instance and class receivers in free-threaded builds ( #128164 )
...
Finish specialization for LOAD_ATTR in the free-threaded build by adding support for class and instance receivers.
2025-01-14 11:56:11 -08:00
1c13c56a34
gh-128384: Add locking to warnings.py. (gh-128386)
...
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
2025-01-14 11:43:42 -08:00
f49a1df6f3
GH-128682: Convert explicit loops closing arrays into `DECREF_INPUTS`. (GH-128822)
...
* Mark Py_DECREF and Py_XDECREF as escaping
* Remove explicit loops for clearing array inputs
2025-01-14 15:08:56 +00:00
Pablo Galindo Salgado