fix(launch): default to non-zero launch timeout (#24440)
When not specified, launch timeout is 3 minutes, taken from the `DEFAULT_LAUNCH_TIMEOUT` constant. Also, use the default launch timeout for `electron.launch()` instead of default regular timeout.
This commit is contained in:
parent
c8b45aa844
commit
e0cbb0882b
|
@ -239,7 +239,7 @@ export class Electron extends SdkObject {
|
|||
app = new ElectronApplication(this, browser, nodeConnection, launchedProcess);
|
||||
await app.initialize();
|
||||
return app;
|
||||
}, TimeoutSettings.timeout(options));
|
||||
}, TimeoutSettings.launchTimeout(options));
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -94,7 +94,6 @@ const playwrightFixtures: Fixtures<TestFixtures, WorkerFixtures> = ({
|
|||
_browserOptions: [async ({ playwright, headless, channel, launchOptions, connectOptions, _artifactsDir }, use) => {
|
||||
const options: LaunchOptions = {
|
||||
handleSIGINT: false,
|
||||
timeout: 0,
|
||||
...launchOptions,
|
||||
};
|
||||
if (headless !== undefined)
|
||||
|
|
Loading…
Reference in New Issue