From fd75b85510e50edb331a97fddbb84b97fd31e6fe Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 23 May 2023 12:04:44 -0700 Subject: [PATCH] Revert "chore: more tree gardening (#23119)" This reverts commit e6bc32b0222d628db6191602ff85ff9801a5a7ec. --- tests/library/inspector/cli-codegen-2.spec.ts | 1 - tests/library/trace-viewer.spec.ts | 3 +-- tests/library/video.spec.ts | 3 +-- tests/playwright-test/playwright.fetch.spec.ts | 1 - tests/playwright-test/ui-mode-trace.spec.ts | 3 --- 5 files changed, 2 insertions(+), 9 deletions(-) diff --git a/tests/library/inspector/cli-codegen-2.spec.ts b/tests/library/inspector/cli-codegen-2.spec.ts index 30f4817b9b..dcd27816fe 100644 --- a/tests/library/inspector/cli-codegen-2.spec.ts +++ b/tests/library/inspector/cli-codegen-2.spec.ts @@ -368,7 +368,6 @@ test.describe('cli codegen', () => { }); test('should not clash pages', async ({ page, openRecorder, browserName }) => { - test.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/23117'); const recorder = await openRecorder(); const [popup1] = await Promise.all([ page.context().waitForEvent('page'), diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.ts index a19f01741d..9d5580459c 100644 --- a/tests/library/trace-viewer.spec.ts +++ b/tests/library/trace-viewer.spec.ts @@ -577,8 +577,7 @@ test('should show action source', async ({ showTraceViewer }) => { await expect(page.getByTestId('stack-trace').locator('.list-view-entry.selected')).toHaveText(/doClick.*trace-viewer\.spec\.ts:[\d]+/); }); -test('should follow redirects', async ({ page, runAndTrace, server, asset, browserName }) => { - test.fixme(browserName === 'chromium', 'https://github.com/microsoft/playwright/issues/23115'); +test('should follow redirects', async ({ page, runAndTrace, server, asset }) => { server.setRoute('/empty.html', (req, res) => { res.writeHead(200, { 'Content-Type': 'text/html' }); res.end(`
`); diff --git a/tests/library/video.spec.ts b/tests/library/video.spec.ts index 54ca41ff2d..03b39b8e84 100644 --- a/tests/library/video.spec.ts +++ b/tests/library/video.spec.ts @@ -674,11 +674,10 @@ it.describe('screencast', () => { expect(files.length).toBe(1); }); - it('should capture full viewport', async ({ browserType, browserName, headless, isWindows, isLinux }, testInfo) => { + it('should capture full viewport', async ({ browserType, browserName, headless, isWindows }, testInfo) => { it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/22411' }); it.fixme(browserName === 'chromium' && !headless, 'The square is not on the video'); it.fixme(browserName === 'firefox' && isWindows, 'https://github.com/microsoft/playwright/issues/14405'); - it.fixme(browserName === 'firefox' && !headless && isLinux, 'https://github.com/microsoft/playwright/issues/23118'); const size = { width: 600, height: 400 }; const browser = await browserType.launch(); diff --git a/tests/playwright-test/playwright.fetch.spec.ts b/tests/playwright-test/playwright.fetch.spec.ts index 8401fee4b2..540413aeef 100644 --- a/tests/playwright-test/playwright.fetch.spec.ts +++ b/tests/playwright-test/playwright.fetch.spec.ts @@ -52,7 +52,6 @@ test('should use baseURL in request fixture', async ({ runInlineTest, server }) }); test('should stop tracing on requestContext.dispose()', async ({ runInlineTest, server }) => { - test.fixme(process.platform === 'darwin', 'https://github.com/microsoft/playwright/issues/23116'); server.setRoute('/slow', (req, resp) => { resp.writeHead(200, { 'Content-Type': 'text/plain; charset=utf-8', diff --git a/tests/playwright-test/ui-mode-trace.spec.ts b/tests/playwright-test/ui-mode-trace.spec.ts index ede1fabae2..d8409d7ded 100644 --- a/tests/playwright-test/ui-mode-trace.spec.ts +++ b/tests/playwright-test/ui-mode-trace.spec.ts @@ -20,7 +20,6 @@ import { test, expect, retries } from './ui-mode-fixtures'; test.describe.configure({ mode: 'parallel', retries }); test('should merge trace events', async ({ runUITest, server }) => { - test.fixme(true, 'https://github.com/microsoft/playwright/issues/23114'); const { page } = await runUITest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; @@ -52,7 +51,6 @@ test('should merge trace events', async ({ runUITest, server }) => { }); test('should merge web assertion events', async ({ runUITest }, testInfo) => { - test.fixme(process.platform === 'darwin' || process.platform === 'win32', 'https://github.com/microsoft/playwright/issues/23114'); const { page } = await runUITest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; @@ -127,7 +125,6 @@ test('should locate sync assertions in source', async ({ runUITest, server }) => }); test('should show snapshots for sync assertions', async ({ runUITest, server }) => { - test.fixme(true, 'https://github.com/microsoft/playwright/issues/23114'); const { page } = await runUITest({ 'a.test.ts': ` import { test, expect } from '@playwright/test';