From 1d09d67909a7d0e67d736e0c278715ea3e8a30ea Mon Sep 17 00:00:00 2001
From: antirez <antirez@gmail.com>
Date: Tue, 4 Mar 2025 09:21:52 +0100
Subject: [PATCH] Tests: regressios for MEMORY USAGE / DEBUG DIGEST.

---
 tests/debug_digest.py | 39 +++++++++++++++++++++++++++++++++++++++
 tests/memory_usage.py | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 75 insertions(+)
 create mode 100644 tests/debug_digest.py
 create mode 100644 tests/memory_usage.py

diff --git a/tests/debug_digest.py b/tests/debug_digest.py
new file mode 100644
index 000000000..78f06d8ef
--- /dev/null
+++ b/tests/debug_digest.py
@@ -0,0 +1,39 @@
+from test import TestCase, generate_random_vector
+import struct
+
+class DebugDigestTest(TestCase):
+    def getname(self):
+        return "[regression] DEBUG DIGEST-VALUE with attributes"
+
+    def test(self):
+        # Generate random vectors
+        vec1 = generate_random_vector(4)
+        vec2 = generate_random_vector(4)
+        vec_bytes1 = struct.pack('4f', *vec1)
+        vec_bytes2 = struct.pack('4f', *vec2)
+
+        # Add vectors to the key, one with attribute, one without
+        self.redis.execute_command('VADD', self.test_key, 'FP32', vec_bytes1, f'{self.test_key}:item:1')
+        self.redis.execute_command('VADD', self.test_key, 'FP32', vec_bytes2, f'{self.test_key}:item:2', 'SETATTR', '{"color":"red"}')
+
+        # Call DEBUG DIGEST-VALUE on the key
+        try:
+            digest1 = self.redis.execute_command('DEBUG', 'DIGEST-VALUE', self.test_key)
+            assert digest1 is not None, "DEBUG DIGEST-VALUE should return a value"
+
+            # Change attribute and verify digest changes
+            self.redis.execute_command('VSETATTR', self.test_key, f'{self.test_key}:item:2', '{"color":"blue"}')
+
+            digest2 = self.redis.execute_command('DEBUG', 'DIGEST-VALUE', self.test_key)
+            assert digest2 is not None, "DEBUG DIGEST-VALUE should return a value after attribute change"
+            assert digest1 != digest2, "Digest should change when an attribute is modified"
+
+            # Remove attribute and verify digest changes again
+            self.redis.execute_command('VSETATTR', self.test_key, f'{self.test_key}:item:2', '')
+
+            digest3 = self.redis.execute_command('DEBUG', 'DIGEST-VALUE', self.test_key)
+            assert digest3 is not None, "DEBUG DIGEST-VALUE should return a value after attribute removal"
+            assert digest2 != digest3, "Digest should change when an attribute is removed"
+
+        except Exception as e:
+            raise AssertionError(f"DEBUG DIGEST-VALUE command failed: {str(e)}")
diff --git a/tests/memory_usage.py b/tests/memory_usage.py
new file mode 100644
index 000000000..d0f3f0967
--- /dev/null
+++ b/tests/memory_usage.py
@@ -0,0 +1,36 @@
+from test import TestCase, generate_random_vector
+import struct
+
+class MemoryUsageTest(TestCase):
+    def getname(self):
+        return "[regression] MEMORY USAGE with attributes"
+
+    def test(self):
+        # Generate random vectors
+        vec1 = generate_random_vector(4)
+        vec2 = generate_random_vector(4)
+        vec_bytes1 = struct.pack('4f', *vec1)
+        vec_bytes2 = struct.pack('4f', *vec2)
+
+        # Add vectors to the key, one with attribute, one without
+        self.redis.execute_command('VADD', self.test_key, 'FP32', vec_bytes1, f'{self.test_key}:item:1')
+        self.redis.execute_command('VADD', self.test_key, 'FP32', vec_bytes2, f'{self.test_key}:item:2', 'SETATTR', '{"color":"red"}')
+
+        # Get memory usage for the key
+        try:
+            memory_usage = self.redis.execute_command('MEMORY', 'USAGE', self.test_key)
+            # If we got here without exception, the command worked
+            assert memory_usage > 0, "MEMORY USAGE should return a positive value"
+
+            # Add more attributes to increase complexity
+            self.redis.execute_command('VSETATTR', self.test_key, f'{self.test_key}:item:1', '{"color":"blue","size":10}')
+
+            # Check memory usage again
+            new_memory_usage = self.redis.execute_command('MEMORY', 'USAGE', self.test_key)
+            assert new_memory_usage > 0, "MEMORY USAGE should still return a positive value after setting attributes"
+
+            # Memory usage should be higher after adding attributes
+            assert new_memory_usage > memory_usage, "Memory usage increase after adding attributes"
+
+        except Exception as e:
+            raise AssertionError(f"MEMORY USAGE command failed: {str(e)}")