mirrors
/
redis
mirror of https://mirror.osredm.com/root/redis.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve redis.conf documentation on repl-diskless-load (#11213) 

Just noticed that there are some inaccurate, or at least confusing information about `repl-diskless-load` in `redis.conf`
It shouldn't scare away users willing to spend the extra memory.

`may mean that we have to flush the contents of the current database before the full rdb was received.`: this is likely related to the time when there was an option `always`, where content on replica was flushed before loading from master.
This commit is contained in:
Eduardo Semprebon 2022-09-11 10:22:59 +02:00 committed by GitHub
parent 5389fa62a6
commit 36abc0fa8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
redis.conf
View File

@ -629,11 +629,10 @@ repl-diskless-sync-delay 5
repl-diskless-sync-max-replicas 0 repl-diskless-sync-max-replicas 0
# ----------------------------------------------------------------------------- # -----------------------------------------------------------------------------
# WARNING: RDB diskless load is experimental. Since in this setup the replica # WARNING: Since in this setup the replica does not immediately store an RDB on
# does not immediately store an RDB on disk, it may cause data loss during # disk, it may cause data loss during failovers. RDB diskless load + Redis
# failovers. RDB diskless load + Redis modules not handling I/O reads may also # modules not handling I/O reads may cause Redis to abort in case of I/O errors
# cause Redis to abort in case of I/O errors during the initial synchronization # during the initial synchronization stage with the master.
# stage with the master. Use only if you know what you are doing.
# ----------------------------------------------------------------------------- # -----------------------------------------------------------------------------
# #
# Replica can load the RDB it reads from the replication link directly from the # Replica can load the RDB it reads from the replication link directly from the
@ -643,19 +642,22 @@ repl-diskless-sync-max-replicas 0
# In many cases the disk is slower than the network, and storing and loading # In many cases the disk is slower than the network, and storing and loading
# the RDB file may increase replication time (and even increase the master's # the RDB file may increase replication time (and even increase the master's
# Copy on Write memory and replica buffers). # Copy on Write memory and replica buffers).
# However, parsing the RDB file directly from the socket may mean that we have # However, when parsing the RDB file directly from the socket, in order to avoid
# to flush the contents of the current database before the full rdb was # data loss it's only safe to flush the current dataset when the new dataset is
# received. For this reason we have the following options: # fully loaded in memory, resulting in higher memory usage.
# For this reason we have the following options:
# #
# "disabled" - Don't use diskless load (store the rdb file to the disk first) # "disabled" - Don't use diskless load (store the rdb file to the disk first)
# "on-empty-db" - Use diskless load only when it is completely safe.
# "swapdb" - Keep current db contents in RAM while parsing the data directly # "swapdb" - Keep current db contents in RAM while parsing the data directly
# from the socket. Replicas in this mode can keep serving current # from the socket. Replicas in this mode can keep serving current
# data set while replication is in progress, except for cases where # dataset while replication is in progress, except for cases where
# they can't recognize master as having a data set from same # they can't recognize master as having a data set from same
# replication history. # replication history.
# Note that this requires sufficient memory, if you don't have it, # Note that this requires sufficient memory, if you don't have it,
# you risk an OOM kill. # you risk an OOM kill.
# "on-empty-db" - Use diskless load only when current dataset is empty. This is
# safer and avoid having old and new dataset loaded side by side
# during replication.
repl-diskless-load disabled repl-diskless-load disabled
# Master send PINGs to its replicas in a predefined interval. It's possible to # Master send PINGs to its replicas in a predefined interval. It's possible to