From 38052fd702e6925a3354e0927ff813fc16f67b08 Mon Sep 17 00:00:00 2001 From: Yossi Gottlieb Date: Tue, 8 Mar 2022 13:10:24 +0200 Subject: [PATCH] Fix redis-benchmark --cluster with IPv6. (#10393) Currently, CLUSTER NODES is parsed and was not done correctly for IPv6 addresses. --- src/redis-benchmark.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/redis-benchmark.c b/src/redis-benchmark.c index 64893ac37..9b183559d 100644 --- a/src/redis-benchmark.c +++ b/src/redis-benchmark.c @@ -1118,6 +1118,9 @@ static clusterNode **addClusterNode(clusterNode *node) { return config.cluster_nodes; } +/* TODO: This should be refactored to use CLUSTER SLOTS, the migrating/importing + * information is anyway not used. + */ static int fetchClusterConfiguration() { int success = 1; redisContext *ctx = NULL; @@ -1179,7 +1182,7 @@ static int fetchClusterConfiguration() { clusterNode *node = NULL; char *ip = NULL; int port = 0; - char *paddr = strchr(addr, ':'); + char *paddr = strrchr(addr, ':'); if (paddr != NULL) { *paddr = '\0'; ip = addr;