From 658424fc8367186181123b6f3a770786afcefc15 Mon Sep 17 00:00:00 2001 From: "debing.sun" Date: Mon, 24 Feb 2025 17:40:25 +0800 Subject: [PATCH] Revert "Update history for ban-list propagation (#13749)" (#13827) As discussed in https://github.com/redis/redis/pull/13749#issuecomment-2673612941. After #10398 we should record only the arguments and output changes in the command history, while placing all others in the redis-doc, so revert #13749. --- src/commands.def | 6 ++---- src/commands/cluster-forget.json | 6 ------ 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/commands.def b/src/commands.def index 9d70326e6..5a7545e32 100644 --- a/src/commands.def +++ b/src/commands.def @@ -533,9 +533,7 @@ struct COMMAND_ARG CLUSTER_FAILOVER_Args[] = { #ifndef SKIP_CMD_HISTORY_TABLE /* CLUSTER FORGET history */ -commandHistory CLUSTER_FORGET_History[] = { -{"7.2.0","Forgotten nodes are automatically propagated across the cluster via gossip."}, -}; +#define CLUSTER_FORGET_History NULL #endif #ifndef SKIP_CMD_TIPS_TABLE @@ -956,7 +954,7 @@ struct COMMAND_STRUCT CLUSTER_Subcommands[] = { {MAKE_CMD("delslotsrange","Sets hash slot ranges as unbound for a node.","O(N) where N is the total number of the slots between the start slot and end slot arguments.","7.0.0",CMD_DOC_NONE,NULL,NULL,"cluster",COMMAND_GROUP_CLUSTER,CLUSTER_DELSLOTSRANGE_History,0,CLUSTER_DELSLOTSRANGE_Tips,0,clusterCommand,-4,CMD_NO_ASYNC_LOADING|CMD_ADMIN|CMD_STALE,0,CLUSTER_DELSLOTSRANGE_Keyspecs,0,NULL,1),.args=CLUSTER_DELSLOTSRANGE_Args}, {MAKE_CMD("failover","Forces a replica to perform a manual failover of its master.","O(1)","3.0.0",CMD_DOC_NONE,NULL,NULL,"cluster",COMMAND_GROUP_CLUSTER,CLUSTER_FAILOVER_History,0,CLUSTER_FAILOVER_Tips,0,clusterCommand,-2,CMD_NO_ASYNC_LOADING|CMD_ADMIN|CMD_STALE,0,CLUSTER_FAILOVER_Keyspecs,0,NULL,1),.args=CLUSTER_FAILOVER_Args}, {MAKE_CMD("flushslots","Deletes all slots information from a node.","O(1)","3.0.0",CMD_DOC_NONE,NULL,NULL,"cluster",COMMAND_GROUP_CLUSTER,CLUSTER_FLUSHSLOTS_History,0,CLUSTER_FLUSHSLOTS_Tips,0,clusterCommand,2,CMD_NO_ASYNC_LOADING|CMD_ADMIN|CMD_STALE,0,CLUSTER_FLUSHSLOTS_Keyspecs,0,NULL,0)}, -{MAKE_CMD("forget","Removes a node from the nodes table.","O(1)","3.0.0",CMD_DOC_NONE,NULL,NULL,"cluster",COMMAND_GROUP_CLUSTER,CLUSTER_FORGET_History,1,CLUSTER_FORGET_Tips,0,clusterCommand,3,CMD_NO_ASYNC_LOADING|CMD_ADMIN|CMD_STALE,0,CLUSTER_FORGET_Keyspecs,0,NULL,1),.args=CLUSTER_FORGET_Args}, +{MAKE_CMD("forget","Removes a node from the nodes table.","O(1)","3.0.0",CMD_DOC_NONE,NULL,NULL,"cluster",COMMAND_GROUP_CLUSTER,CLUSTER_FORGET_History,0,CLUSTER_FORGET_Tips,0,clusterCommand,3,CMD_NO_ASYNC_LOADING|CMD_ADMIN|CMD_STALE,0,CLUSTER_FORGET_Keyspecs,0,NULL,1),.args=CLUSTER_FORGET_Args}, {MAKE_CMD("getkeysinslot","Returns the key names in a hash slot.","O(N) where N is the number of requested keys","3.0.0",CMD_DOC_NONE,NULL,NULL,"cluster",COMMAND_GROUP_CLUSTER,CLUSTER_GETKEYSINSLOT_History,0,CLUSTER_GETKEYSINSLOT_Tips,1,clusterCommand,4,CMD_STALE,0,CLUSTER_GETKEYSINSLOT_Keyspecs,0,NULL,2),.args=CLUSTER_GETKEYSINSLOT_Args}, {MAKE_CMD("help","Returns helpful text about the different subcommands.","O(1)","5.0.0",CMD_DOC_NONE,NULL,NULL,"cluster",COMMAND_GROUP_CLUSTER,CLUSTER_HELP_History,0,CLUSTER_HELP_Tips,0,clusterCommand,2,CMD_LOADING|CMD_STALE,0,CLUSTER_HELP_Keyspecs,0,NULL,0)}, {MAKE_CMD("info","Returns information about the state of a node.","O(1)","3.0.0",CMD_DOC_NONE,NULL,NULL,"cluster",COMMAND_GROUP_CLUSTER,CLUSTER_INFO_History,0,CLUSTER_INFO_Tips,1,clusterCommand,2,CMD_STALE,0,CLUSTER_INFO_Keyspecs,0,NULL,0)}, diff --git a/src/commands/cluster-forget.json b/src/commands/cluster-forget.json index 1cee7a646..6f9a25ce6 100644 --- a/src/commands/cluster-forget.json +++ b/src/commands/cluster-forget.json @@ -7,12 +7,6 @@ "arity": 3, "container": "CLUSTER", "function": "clusterCommand", - "history": [ - [ - "7.2.0", - "Forgotten nodes are automatically propagated across the cluster via gossip." - ] - ], "command_flags": [ "NO_ASYNC_LOADING", "ADMIN",