mirrors
/
redis
mirror of https://mirror.osredm.com/root/redis.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

decrby LLONG_MIN caused nagation overflow. (#9577) 

Note that this breaks compatibility because in the past doing:
DECRBY x -9223372036854775808
would succeed (and create an invalid result) and now this returns an error.
This commit is contained in:
yoav-steinberg 2021-10-03 09:38:05 +03:00 committed by GitHub
parent 93e8534713
commit 6f4f31f167
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/t_string.c
View File

@ -637,6 +637,11 @@ void decrbyCommand(client *c) {
long long incr; long long incr;
if (getLongLongFromObjectOrReply(c, c->argv[2], &incr, NULL) != C_OK) return; if (getLongLongFromObjectOrReply(c, c->argv[2], &incr, NULL) != C_OK) return;
/* Overflow check: negating LLONG_MIN will cause an overflow */
if (incr == LLONG_MIN) {
addReplyError(c, "decrement would overflow");
return;
}
incrDecrCommand(c,-incr); incrDecrCommand(c,-incr);
} }

6
tests/unit/type/incr.tcl
View File

@ -42,6 +42,12 @@ start_server {tags {"incr"}} {
format $err format $err
} {ERR*} } {ERR*}
test {DECRBY negation overflow} {
r set x 0
catch {r decrby x -9223372036854775808} err
format $err
} {ERR*}
test {INCR fails against a key holding a list} { test {INCR fails against a key holding a list} {
r rpush mylist 1 r rpush mylist 1
catch {r incr mylist} err catch {r incr mylist} err