From 8f59f131e5c26680d21e825695ef24a4fd7b99b7 Mon Sep 17 00:00:00 2001 From: Madelyn Olson <34459052+madolson@users.noreply.github.com> Date: Sat, 3 Jul 2021 10:51:53 -0500 Subject: [PATCH] Update incrDecrCommand to use addReplyLongLong (#9188) Update incrDecrCommand to use addReplyLongLong --- src/server.c | 1 - src/server.h | 2 +- src/t_string.c | 4 +--- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/server.c b/src/server.c index e73235747..dbc0a04e2 100644 --- a/src/server.c +++ b/src/server.c @@ -2479,7 +2479,6 @@ void createSharedObjects(void) { shared.queued = createObject(OBJ_STRING,sdsnew("+QUEUED\r\n")); shared.emptyscan = createObject(OBJ_STRING,sdsnew("*2\r\n$1\r\n0\r\n*0\r\n")); shared.space = createObject(OBJ_STRING,sdsnew(" ")); - shared.colon = createObject(OBJ_STRING,sdsnew(":")); shared.plus = createObject(OBJ_STRING,sdsnew("+")); /* Shared command error responses */ diff --git a/src/server.h b/src/server.h index 60d9ddf07..168fbcc87 100644 --- a/src/server.h +++ b/src/server.h @@ -1025,7 +1025,7 @@ struct sentinelConfig { struct sharedObjectsStruct { robj *crlf, *ok, *err, *emptybulk, *czero, *cone, *pong, *space, - *colon, *queued, *null[4], *nullarray[4], *emptymap[4], *emptyset[4], + *queued, *null[4], *nullarray[4], *emptymap[4], *emptyset[4], *emptyarray, *wrongtypeerr, *nokeyerr, *syntaxerr, *sameobjecterr, *outofrangeerr, *noscripterr, *loadingerr, *slowscripterr, *bgsaveerr, *masterdownerr, *roslaveerr, *execaborterr, *noautherr, *noreplicaserr, diff --git a/src/t_string.c b/src/t_string.c index 91c8b1707..d7173b53f 100644 --- a/src/t_string.c +++ b/src/t_string.c @@ -615,9 +615,7 @@ void incrDecrCommand(client *c, long long incr) { signalModifiedKey(c,c->db,c->argv[1]); notifyKeyspaceEvent(NOTIFY_STRING,"incrby",c->argv[1],c->db->id); server.dirty++; - addReply(c,shared.colon); - addReply(c,new); - addReply(c,shared.crlf); + addReplyLongLong(c, value); } void incrCommand(client *c) {