mirrors
/
redis
mirror of https://mirror.osredm.com/root/redis.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix timing issue in module defrag test (#13870) 

After #13840, the data we populate becomes more complex and slower, we
always wait for a defragmentation cycle to end before verifying that the
test is okay.
However, in some slow environments, an entire defragmentation cycle can
exceed 5 seconds, and in my local test using 'taskset -c 0' it can reach
6 seconds, so increase the threshold to avoid test failures.
This commit is contained in:
debing.sun 2025-03-20 21:22:47 +08:00 committed by GitHub
parent 951ec79654
commit cb02bd190b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/moduleapi/defrag.tcl
View File

@ -22,7 +22,7 @@ start_server {tags {"modules"} overrides {{save ""}}} {
r frag.create key1 1 1000 0 r frag.create key1 1 1000 0
r config set activedefrag yes r config set activedefrag yes
wait_for_condition 100 50 { wait_for_condition 200 50 {
[getInfoProperty [r info defragtest_stats] defragtest_defrag_ended] > 0 [getInfoProperty [r info defragtest_stats] defragtest_defrag_ended] > 0
} else { } else {
fail "Unable to wait for a complete defragmentation cycle to finish" fail "Unable to wait for a complete defragmentation cycle to finish"
@ -52,7 +52,7 @@ start_server {tags {"modules"} overrides {{save ""}}} {
r frag.create key2 10000 100 1000 r frag.create key2 10000 100 1000
r config set activedefrag yes r config set activedefrag yes
wait_for_condition 100 50 { wait_for_condition 200 50 {
[getInfoProperty [r info defragtest_stats] defragtest_defrag_ended] > 0 [getInfoProperty [r info defragtest_stats] defragtest_defrag_ended] > 0
} else { } else {
fail "Unable to wait for a complete defragmentation cycle to finish" fail "Unable to wait for a complete defragmentation cycle to finish"
@ -79,7 +79,7 @@ start_server {tags {"modules"} overrides {{save ""}}} {
r frag.create_frag_global r frag.create_frag_global
r config set activedefrag yes r config set activedefrag yes
wait_for_condition 100 50 { wait_for_condition 200 50 {
[getInfoProperty [r info defragtest_stats] defragtest_defrag_ended] > 0 [getInfoProperty [r info defragtest_stats] defragtest_defrag_ended] > 0
} else { } else {
fail "Unable to wait for a complete defragmentation cycle to finish" fail "Unable to wait for a complete defragmentation cycle to finish"