From ffbdf2f6f37e2d5c0d1dcc6db16b63faacffd705 Mon Sep 17 00:00:00 2001 From: "debing.sun" Date: Tue, 14 May 2024 20:08:32 +0800 Subject: [PATCH] Fix test failure due to differing reply format of XREADGROUP under RESP3 in MULTI (#13255) This test was introducted by #13251. Normally we auto transform the reply format of XREADGROUP to array under RESP3 (see trasformer_funcs). But when we execute XREADGROUP command in multi it can't work, which cause the new test failed. The solution is to verity the reply of XREADGROUP in advance rather than in MULTI. Failed validate schema CI: https://github.com/redis/redis/actions/runs/9025128323/job/24800285684 --------- Co-authored-by: guybe7 --- tests/unit/type/stream-cgroups.tcl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/unit/type/stream-cgroups.tcl b/tests/unit/type/stream-cgroups.tcl index 2462a25ba..d5754d42b 100644 --- a/tests/unit/type/stream-cgroups.tcl +++ b/tests/unit/type/stream-cgroups.tcl @@ -1398,11 +1398,10 @@ start_server { $master del mystream $master xadd mystream 1-0 a b c d e f $master xgroup create mystream mygroup 0 - $master xreadgroup group mygroup ryan count 1 streams mystream > + assert_equal [$master xreadgroup group mygroup ryan count 1 streams mystream >] {{mystream {{1-0 {a b c d e f}}}}} $master multi $master xreadgroup group mygroup ryan count 1 streams mystream 0 - set reply [$master exec] - assert_equal $reply {{{mystream {{1-0 {a b c d e f}}}}}} + $master exec } }