e08bf16637
Add ZINTER/ZUNION command
...
Syntax: ZINTER/ZUNION numkeys key [key ...] [WEIGHTS weight [weight ...]]
[AGGREGATE SUM|MIN|MAX] [WITHSCORES]
see #7624
2020-09-24 08:59:14 +03:00
66a13ccbdf
Add GT and LT options to ZADD for conditional score updates ( #7818 )
...
Co-authored-by: Alex Ronke <w.alex.ronke@gmail.com>
2020-09-23 21:56:16 +03:00
1c71038540
Squash merging 125 typo/grammar/comment/doc PRs ( #7773 )
...
List of squashed commits or PRs
===============================
commit 66801ea46f55db61a2aa0a5871d141eede7c303c841eb76bf1530ec2e517b31c300eff4c058a85fcaa814caca9ab2a25f612842aeddba07c8fc7bf29b2b67a0746f1092b588d1da37aa2d4ba28af347a82d4ba281a746f78599b1af38d4e8fe143fc1ab4d21ca1f70ea57c06bb8c92b59dd981ce132d7a47f44d5b8bdb0d0def46af3596fd2b928cd33aea14e282a8074d1f9aeea14070da553c7fc8fb65f46c9d321dfe1b4fb131267e0e63df1eb8267e0e630544e7337969d9f4b121423a030e504583423a03042b02b746a51cd42b02b768c0e6eb8febe6#1 from antirez/unstable
update local data
commit 714b589e23259da9359f8a12c3e4770eb11fd97fbba85522dade8007869ee39f89d158892198e8a4d780e3acef604442fb9f36880f866b4a0ebc69bb50a6207d8f34902dec7ee1efbc893327d863d361febe228d6b696e6a2ec6ae3ab769972d43ef707c958b9385b220d9230b167bfcFix #4008 small typo in comment
commit 2b78ac8b0f1cdba90b0f98430a79481a1c2586b4d3c1c4b5e1ee1a3f11a41fb5fb5d826b254bcee9869ff7b3b113fd40fc621c160d7d07d6a4dade7http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba972d42e5dd6e9573a12b232d1d03b3973b064f2e460b21667c88894c727634700847b3dbbb9e9e5ed297eedec9d6692a7afd962b0aa83af59c961896e600ef2c7d07fab25cb67ad28ca6fd2a1e71d9aaf832bfa7cb24f69c4e04082acb87732eb75b6a8249a23c020289dba47c
2020-09-10 13:43:38 +03:00
f2db379fa3
Replace usage of wrongtypeerr with helper ( #7633 )
...
* Replace usage of wrongtypeerr with helper
2020-08-11 20:04:54 -07:00
f11f26cc53
Add a ZMSCORE command returning an array of scores. ( #7593 )
...
Syntax: `ZMSCORE KEY MEMBER [MEMBER ...]`
This is an extension of #2359
amended by Tyson Andre to work with the changed unstable API,
add more tests, and consistently return an array.
- It seemed as if it would be more likely to get reviewed
after updating the implementation.
Currently, multi commands or lua scripting to call zscore multiple times
would almost definitely be less efficient than a native ZMSCORE
for the following reasons:
- Need to fetch the set from the string every time instead of reusing the C
pointer.
- Using pipelining or multi-commands would result in more bytes sent by
the client for the repeated `ZMSCORE KEY` sections.
- Need to specially encode the data and decode it from the client
for lua-based solutions.
- The fastest solution I've seen for large sets(thousands or millions)
involves lua and a variadic ZADD, then a ZINTERSECT, then a ZRANGE 0 -1,
then UNLINK of a temporary set (or lua). This is still inefficient.
Co-authored-by: Tyson Andre <tysonandre775@hotmail.com>
2020-08-04 17:49:33 +03:00
e9aba28932
STORE variants: SINTER,SUNION,SDIFF,ZUNION use setKey instead of dbDelete+dbAdd ( #7489 )
...
one of the differences (other than consistent code with SORT, GEORADIUS), is that the LFU of the old key is retained.
2020-07-11 15:52:41 +03:00
94f2e7f9f9
Tracking: NOLOOP internals implementation.
2020-04-21 10:51:46 +02:00
086c1db2d9
Fix zsetAdd() top comment spelling.
2020-04-14 11:23:44 +02:00
49ccd2a8e1
Fix function names in zslDeleteNode() top comment.
2020-04-14 10:52:40 +02:00
06d490342f
RESP3: fix cases of NULL reported instead of empty aggregate.
2019-09-02 12:50:47 +02:00
48f4cfb601
Reduce the calling stack
2019-07-24 16:22:26 +08:00
74d6af8f80
Fix ZPOP return type when COUNT=0. Related to #5799 .
2019-03-14 17:51:20 +01:00
d3cd2e9a4a
Merge pull request #4742 from guybe7/zrangebylex_leak
...
Fix zlexrangespec mem-leak in genericZrangebylexCommand
2019-03-14 11:44:56 +01:00
2502956835
ZPOP should return an empty array if COUNT=0
2019-01-23 11:11:57 +02:00
c2e5be0421
RESP3: fix zrangeGenericCommand() proto dependent array len.
2019-01-09 17:00:29 +01:00
3fd78f41e8
RESP3: restore the concept of null array for RESP2 compat.
2019-01-09 17:00:29 +01:00
317f8b9d38
RESP3: most null replies converted.
2019-01-09 17:00:29 +01:00
c7f80e4f1a
RESP3: Make WITHSCORES reply back with a flat array in RESP2.
2019-01-09 17:00:29 +01:00
470c28380f
RESP3: Use new deferred len API in t_zset.c.
2019-01-09 17:00:29 +01:00
6a6471aad5
Merge pull request #4737 from guybe7/zlexcount_fix
...
Don't call sdscmp() with shared.maxstring or shared.minstring
2018-11-28 16:53:32 +01:00
2f282aee0b
Fix zslUpdateScore() edge case.
...
When the element new score is the same of prev/next node, the
lexicographical order kicks in, so we can safely update the node in
place only when the new score is strictly between the adjacent nodes
but never equal to one of them.
Technically speaking we could do extra checks to make sure that even if the
score is the same as one of the adjacent nodes, we can still update on
place, but this rarely happens, so probably not a good deal to make it
more complex.
Related to #5179 .
2018-08-01 19:04:53 +02:00
29226a3919
More commenting of zslUpdateScore().
2018-08-01 18:54:15 +02:00
12ff0c0d79
Explain what's the point of zslUpdateScore() in top comment.
2018-08-01 18:53:09 +02:00
e3e94ec35c
Remove old commented zslUpdateScore() from source.
2018-08-01 18:50:49 +02:00
0b800c4332
Optimize zslUpdateScore() as asked in #5179 .
2018-08-01 18:50:31 +02:00
6dd0d6f7dd
zsetAdd() refactored adding zslUpdateScore().
2018-08-01 18:27:56 +02:00
93238575f7
Fix typo
2018-07-03 18:19:46 +02:00
be899b824e
Merge pull request #4519 from soloestoy/zset-int-problem
...
Zset int problem
2018-06-08 12:45:11 +02:00
0a698e499a
ZPOP: invert score-ele to match ZRANGE WITHSCORES order.
2018-06-05 17:06:25 +02:00
b9d19371e4
ZPOP: unblock multiple clients in right way
2018-05-31 23:35:47 +08:00
4e7a160b9b
ZPOP: fix the wrong keyc, should be 1
2018-05-22 21:31:22 +08:00
56bbab238a
ZPOP: change sync ZPOP to have a count argument instead of N keys.
...
Usually blocking operations make a lot of sense with multiple keys so
that we can listen to multiple queues (or whatever the app models) with
a single connection. However in the synchronous case it is more useful
to be able to ask for N elements. This is a change that I also wanted to
perform soon or later in the blocking list variant, but here it is more
natural since there is no reply type difference.
2018-05-11 18:00:32 +02:00
6efb6c1e06
ZPOP: renaming to have explicit MIN/MAX score idea.
...
This commit also adds a top comment about a subtle behavior of mixing
blocking operations of different types in the same key.
2018-05-11 17:31:53 +02:00
438125b47c
Implements [B]Z[REV]POP and the respective unit tests
...
An implementation of the
[Ze POP Redis Module](https://github.com/itamarhaber/zpop ) as core
Redis commands.
Fixes #1861 .
2018-04-30 02:10:42 +03:00
b660fc2fbe
Fix zlexrangespec mem-leak in genericZrangebylexCommand
2018-03-07 10:40:37 +07:00
290a63dc54
Don't call sdscmp() with shared.maxstring or shared.minstring
2018-03-06 20:14:35 +07:00
e8901b2fe4
zset: fix the int problem
2017-12-08 15:37:08 +08:00
adeed29a99
Use SipHash hash function to mitigate HashDos attempts.
...
This change attempts to switch to an hash function which mitigates
the effects of the HashDoS attack (denial of service attack trying
to force data structures to worst case behavior) while at the same time
providing Redis with an hash function that does not expect the input
data to be word aligned, a condition no longer true now that sds.c
strings have a varialbe length header.
Note that it is possible sometimes that even using an hash function
for which collisions cannot be generated without knowing the seed,
special implementation details or the exposure of the seed in an
indirect way (for example the ability to add elements to a Set and
check the return in which Redis returns them with SMEMBERS) may
make the attacker's life simpler in the process of trying to guess
the correct seed, however the next step would be to switch to a
log(N) data structure when too many items in a single bucket are
detected: this seems like an overkill in the case of Redis.
SPEED REGRESION TESTS:
In order to verify that switching from MurmurHash to SipHash had
no impact on speed, a set of benchmarks involving fast insertion
of 5 million of keys were performed.
The result shows Redis with SipHash in high pipelining conditions
to be about 4% slower compared to using the previous hash function.
However this could partially be related to the fact that the current
implementation does not attempt to hash whole words at a time but
reads single bytes, in order to have an output which is endian-netural
and at the same time working on systems where unaligned memory accesses
are a problem.
Further X86 specific optimizations should be tested, the function
may easily get at the same level of MurMurHash2 if a few optimizations
are performed.
2017-02-20 17:29:17 +01:00
5dc4fe1529
Verify pairs are provided after subcommands
...
Fixes https://github.com/antirez/redis/issues/3639
2016-12-02 18:19:36 +02:00
a636aeac07
Apply the new dictUnlink() where possible.
...
Optimizations suggested and originally implemented by @oranagra.
Re-applied by @antirez using the modified API.
2016-09-14 16:37:53 +02:00
68bf45fa1e
Optimize repeated keyname hashing.
...
(Change cherry-picked and modified by @antirez from a larger commit
provided by @oranagra in PR #3223 ).
2016-09-12 13:19:05 +02:00
8f3a4df775
Use const in Redis Module API where possible.
2016-06-20 23:08:06 +03:00
bafed3ddd6
Merge pull request #3222 from oranagra/more_minir_fixes
...
minor fixes - mainly signalModifiedKey, and GEORADIUS
2016-05-18 07:50:53 -07:00
db3ade22eb
Modules: zset lex iterator #2 .
2016-05-10 06:40:09 +02:00
2b04f86ae5
Modules: zset lex iterator #1 .
2016-05-10 06:40:08 +02:00
6eeeda39e9
Modules: sorted set iterators WIP #2 .
2016-05-10 06:40:08 +02:00
9682b616a2
minor fixes - mainly signalModifiedKey, and GEORADIUS
2016-05-09 12:05:33 +03:00
0b4bb502a2
Fix ZINCRBY return value.
2016-04-18 00:35:54 -03:00
dda0f37f11
ZREM refactored into proper API.
2016-04-15 15:20:57 +02:00
6f926c3e83
ZRANK refactored into proper API.
2016-04-15 12:47:03 +02:00
b73c7af0f4
zsetAdd() API exposed into server.h.
2016-04-14 16:00:08 +02:00
b1f181a736
ZADD refactored into a proper API.
2016-04-14 12:49:40 +02:00
bb75ecddfd
New options for GEORADIUS: STORE and STOREDIST.
...
Related to issue #3019 .
2016-02-18 10:24:16 +01:00
a7c5be18a8
Lazyfree: Sorted sets convereted to plain SDS. (several commits squashed)
2015-10-01 13:02:24 +02:00
32f80e2f1b
RDMF: More consistent define names.
2015-07-27 14:37:58 +02:00
40eb548a80
RDMF: REDIS_OK REDIS_ERR -> C_OK C_ERR.
2015-07-26 23:17:55 +02:00
2d9e3eb107
RDMF: redisAssert -> serverAssert.
2015-07-26 15:29:53 +02:00
14ff572482
RDMF: OBJ_ macros for object related stuff.
2015-07-26 15:28:00 +02:00
554bd0e7bd
RDMF: use client instead of redisClient, like Disque.
2015-07-26 15:20:52 +02:00
cef054e868
RDMF (Redis/Disque merge friendlyness) refactoring WIP 1.
2015-07-26 15:17:18 +02:00
5254c2d3c3
Removed useless tryObjectEncoding() call from ZRANK.
2015-07-03 09:47:08 +02:00
9fc47ddf0b
Geo: zsetScore refactoring
...
Now used both in geo.c and t_zset to provide ZSCORE.
2015-06-22 17:26:36 +02:00
7f4ac3d19c
[In-Progress] Add Geo Commands
...
Current todo:
- replace functions in zset.{c,h} with a new unified Redis
zset access API.
Once we get the zset interface fixed, we can squash
relevant commits in this branch and have one nice commit
to merge into unstable.
This commit adds:
- Geo commands
- Tests; runnable with: ./runtest --single unit/geo
- Geo helpers in deps/geohash-int/
- src/geo.{c,h} and src/geojson.{c,h} implementing geo commands
- Updated build configurations to get everything working
- TEMPORARY: src/zset.{c,h} implementing zset score and zset
range reading without writing to client output buffers.
- Modified linkage of one t_zset.c function for use in zset.c
Conflicts:
src/Makefile
src/redis.c
2015-06-22 09:07:13 +02:00
0dc6a5d497
Update t_zset.c
2015-06-02 18:12:57 +08:00
d8a8dca7fd
ZADD RETCH option renamed CH
...
From Twitter:
"@antirez that’s an awfully-named command :(
http://en.wikipedia.org/wiki/Retching "
2015-05-29 11:32:22 +02:00
c043a4e6f4
ZADD RETCH option: Return number of elements added or updated
...
Normally ZADD only returns the number of elements added to a sorted
set, using the RETCH option it returns the sum of elements added or
for which the score was updated.
2015-05-29 11:22:03 +02:00
5d32abbb9e
ZADD NX and XX options
2015-05-29 09:59:42 +02:00
382a943414
ZADD implemenation able to take options.
2015-05-28 18:10:51 +02:00
d956d809ac
Fix three simple clang analyzer warnings
2014-12-23 09:31:04 -05:00
5b3930655f
Remove redundant else/return block
...
Fixes #1741
2014-08-07 12:20:57 +02:00
d74e422b5e
Remove useless var and check in zunionInterGenericCommand().
2014-07-22 17:38:22 +02:00
119813e968
ZUNIONSTORE reimplemented for speed.
...
The user @kjmph provided excellent ideas to improve speed of ZUNIONSTORE
(in certain cases by many order of magnitude), together with an
implementation of the ideas.
While the ideas were sounding, the implementation could be improved both
in terms of speed and clearness, so that's my attempt at reimplementing
the speedup proposed, trying to improve by directly using just a
dictionary with an embedded score inside, and reusing the single-pass
aggregate + order-later approach.
Note that you can't apply this commit without applying the previous
commit in this branch that adds a double in the dictEntry value union.
Issue #1786 .
2014-07-22 17:38:22 +02:00
95b1979c32
No more trailing spaces in Redis source code.
2014-06-26 18:48:40 +02:00
dc8584696a
fix issue 1787
2014-06-01 02:23:24 +08:00
ab3afe2f4d
ZREMRANGEBYLEX memory leak removed calling zslFreeLexRange().
2014-04-18 13:01:04 +02:00
78954ca3a2
ZREMRANGEBYLEX implemented.
2014-04-17 14:49:25 +02:00
8827dc4eec
Always pass sorted set range objects by reference.
2014-04-17 14:30:12 +02:00
95098b7230
ZREMRANGE* commands refactored into a single generic function.
2014-04-17 14:19:14 +02:00
bcab07f7fc
Pass by pointer and release of lex ranges.
...
Given that the code was written with a 2 years pause... something
strange happened in the middle. So there was no function to free a
lex range min/max objects, and in some places the range was passed by
value.
2014-04-16 23:55:58 +02:00
8b5e0b213e
ZLEXCOUNT implemented.
...
Like ZCOUNT for lexicographical ranges.
2014-04-16 12:17:00 +02:00
3a6a1e42f1
ZRANGEBYLEX and ZREVRANGEBYLEX implementation.
2014-04-05 11:41:43 +02:00
11e81a1e9a
Fixed grammar: before H the article is a, not an.
2013-12-05 16:35:32 +01:00
ebcb6251e6
SCAN code refactored to parse cursor first.
...
The previous implementation of SCAN parsed the cursor in the generic
function implementing SCAN, SSCAN, HSCAN and ZSCAN.
The actual higher-level command implementation only checked for empty
keys and return ASAP in that case. The result was that inverting the
arguments of, for instance, SSCAN for example and write:
SSCAN 0 key
Instead of
SSCAN key 0
Resulted into no error, since 0 is a non-existing key name very likely.
Just the iterator returned no elements at all.
In order to fix this issue the code was refactored to extract the
function to parse the cursor and return the error. Every higher level
command implementation now parses the cursor and later checks if the key
exist or not.
2013-11-05 15:47:50 +01:00
9b2d44e63f
Aesthetic fix (missing space) into HSCAN and ZSCAN implementations.
...
Thanks to @badboy for reporting.
2013-10-28 13:20:11 +01:00
2c643ffa8d
ZSCAN implemented.
2013-10-28 11:36:42 +01:00
3039e806d8
Fix comments for correctness in zunionInterGenericCommand().
...
Related to issue #1240 .
2013-08-19 15:01:05 +02:00
cfb9d025c6
Properly init/release iterators in zunionInterGenericCommand().
...
This commit does mainly two things:
1) It fixes zunionInterGenericCommand() by removing mass-initialization
of all the iterators used, so that we don't violate the unsafe iterator
API of dictionaries. This fixes issue #1240 .
2) Since the zui* APIs required the allocator to be initialized in the
zsetopsrc structure in order to use non-iterator related APIs, this
commit fixes this strict requirement by accessing objects directly via
the op->subject->ptr pointer we have to the object.
2013-08-19 15:01:01 +02:00
894eba07c8
Introduction of a new string encoding: EMBSTR
...
Previously two string encodings were used for string objects:
1) REDIS_ENCODING_RAW: a string object with obj->ptr pointing to an sds
stirng.
2) REDIS_ENCODING_INT: a string object where the obj->ptr void pointer
is casted to a long.
This commit introduces a experimental new encoding called
REDIS_ENCODING_EMBSTR that implements an object represented by an sds
string that is not modifiable but allocated in the same memory chunk as
the robj structure itself.
The chunk looks like the following:
+--------------+-----------+------------+--------+----+
| robj data... | robj->ptr | sds header | string | \0 |
+--------------+-----+-----+------------+--------+----+
| ^
+-----------------------+
The robj->ptr points to the contiguous sds string data, so the object
can be manipulated with the same functions used to manipulate plan
string objects, however we need just on malloc and one free in order to
allocate or release this kind of objects. Moreover it has better cache
locality.
This new allocation strategy should benefit both the memory usage and
the performances. A performance gain between 60 and 70% was observed
during micro-benchmarks, however there is more work to do to evaluate
the performance impact and the memory usage behavior.
2013-07-22 10:31:38 +02:00
ad297a1a67
Z*STORE event fixed: generate del only if resulting sorted set is empty.
2013-01-29 13:50:01 +01:00
fce016d31b
Keyspace events: it is now possible to select subclasses of events.
...
When keyspace events are enabled, the overhead is not sever but
noticeable, so this commit introduces the ability to select subclasses
of events in order to avoid to generate events the user is not
interested in.
The events can be selected using redis.conf or CONFIG SET / GET.
2013-01-28 13:15:12 +01:00
da04e6ed44
Keyspace events added for more commands.
2013-01-28 13:14:56 +01:00
9d09ce3981
Fixed many typos.
2013-01-19 10:59:44 +01:00
cceb0c5b4a
Fix integer overflow in zunionInterGenericCommand().
...
This fixes issue #761 .
2012-11-22 15:28:28 +01:00
4365e5b2d3
BSD license added to every C source and header file.
2012-11-08 18:31:32 +01:00
348ee1a40a
Fixed issue #516 (ZINTERSTORE mixing sets and zsets).
...
Weeks ago trying to fix an harmless GCC warning I introduced a bug in
the ziplist-encoded implementations of sorted sets.
The bug completely broke zuiNext() iterator, that is used in the
ZINTERSTORE and ZUNIONSTORE implementation, so those two commands are no
longer reliable starting from Redis version 2.4.12 and latest 2.6.0-RC
releases.
This commit fixes the problem and adds a regression test.
2012-05-23 11:12:43 +02:00
e54fe9a79f
A few compiler warnings suppressed.
2012-04-24 11:11:55 +02:00
feb282883b
zzlIsInRange() now is capable of handling empty sorted sets that may end inside the data set when loading very old RDB files produced by early-stage versions of Redis.
2012-02-22 09:52:10 +01:00
fe7be46025
bzero -> memset
2012-02-21 10:06:04 +01:00
7faa1f075b
added a comment on top of the zslRandomLevel() function
2012-01-16 09:39:04 +01:00
d8bd12f984
error in comment fixed
2012-01-11 20:25:51 +01:00
bodong.ybd