From 18b0c9a011b7569deae433fbbdf123764db2eae8 Mon Sep 17 00:00:00 2001 From: hiroki Date: Wed, 3 Feb 2021 13:09:59 -0500 Subject: [PATCH] docs(type): remove unmount parameters (#2601) --- packages/runtime-core/__tests__/apiCreateApp.spec.ts | 4 ++-- packages/runtime-core/src/apiCreateApp.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/runtime-core/__tests__/apiCreateApp.spec.ts b/packages/runtime-core/__tests__/apiCreateApp.spec.ts index 47e0eb6fa..82fd44d40 100644 --- a/packages/runtime-core/__tests__/apiCreateApp.spec.ts +++ b/packages/runtime-core/__tests__/apiCreateApp.spec.ts @@ -60,12 +60,12 @@ describe('api: createApp', () => { const app = createApp(Comp) // warning - app.unmount(root) + app.unmount() expect(`that is not mounted`).toHaveBeenWarned() app.mount(root) - app.unmount(root) + app.unmount() expect(serializeInner(root)).toBe(``) }) diff --git a/packages/runtime-core/src/apiCreateApp.ts b/packages/runtime-core/src/apiCreateApp.ts index 289693704..869e5809f 100644 --- a/packages/runtime-core/src/apiCreateApp.ts +++ b/packages/runtime-core/src/apiCreateApp.ts @@ -29,7 +29,7 @@ export interface App { rootContainer: HostElement | string, isHydrate?: boolean ): ComponentPublicInstance - unmount(rootContainer: HostElement | string): void + unmount(): void provide(key: InjectionKey | string, value: T): this // internal, but we need to expose these for the server-renderer and devtools