From 3294e50b0b6a81985d1068870e52fdbfdc2072fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=B8=B6=E8=BF=9C=E6=96=B9?= Date: Mon, 8 May 2023 14:34:24 +0800 Subject: [PATCH] chore: update tests to use expect.toBeInstanceOf (#8154) --- packages/reactivity/__tests__/collections/Map.spec.ts | 4 ++-- packages/reactivity/__tests__/collections/Set.spec.ts | 4 ++-- packages/reactivity/__tests__/collections/WeakMap.spec.ts | 4 ++-- packages/reactivity/__tests__/collections/WeakSet.spec.ts | 4 ++-- packages/reactivity/__tests__/reactive.spec.ts | 8 ++++---- packages/runtime-dom/__tests__/createApp.spec.ts | 2 +- packages/vue-compat/__tests__/filters.spec.ts | 2 +- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/reactivity/__tests__/collections/Map.spec.ts b/packages/reactivity/__tests__/collections/Map.spec.ts index aa4874014..bac581348 100644 --- a/packages/reactivity/__tests__/collections/Map.spec.ts +++ b/packages/reactivity/__tests__/collections/Map.spec.ts @@ -14,8 +14,8 @@ describe('reactivity/collections', () => { const original = new Map() const observed = reactive(original) expect(isReactive(observed)).toBe(true) - expect(original instanceof Map).toBe(true) - expect(observed instanceof Map).toBe(true) + expect(original).toBeInstanceOf(Map) + expect(observed).toBeInstanceOf(Map) }) it('should observe mutations', () => { diff --git a/packages/reactivity/__tests__/collections/Set.spec.ts b/packages/reactivity/__tests__/collections/Set.spec.ts index 4fd29876f..1632d2175 100644 --- a/packages/reactivity/__tests__/collections/Set.spec.ts +++ b/packages/reactivity/__tests__/collections/Set.spec.ts @@ -14,8 +14,8 @@ describe('reactivity/collections', () => { const original = new Set() const observed = reactive(original) expect(isReactive(observed)).toBe(true) - expect(original instanceof Set).toBe(true) - expect(observed instanceof Set).toBe(true) + expect(original).toBeInstanceOf(Set) + expect(observed).toBeInstanceOf(Set) }) it('should observe mutations', () => { diff --git a/packages/reactivity/__tests__/collections/WeakMap.spec.ts b/packages/reactivity/__tests__/collections/WeakMap.spec.ts index a8f722458..b25306335 100644 --- a/packages/reactivity/__tests__/collections/WeakMap.spec.ts +++ b/packages/reactivity/__tests__/collections/WeakMap.spec.ts @@ -7,8 +7,8 @@ describe('reactivity/collections', () => { const original = new WeakMap() const observed = reactive(original) expect(isReactive(observed)).toBe(true) - expect(original instanceof WeakMap).toBe(true) - expect(observed instanceof WeakMap).toBe(true) + expect(original).toBeInstanceOf(WeakMap) + expect(observed).toBeInstanceOf(WeakMap) }) it('should observe mutations', () => { diff --git a/packages/reactivity/__tests__/collections/WeakSet.spec.ts b/packages/reactivity/__tests__/collections/WeakSet.spec.ts index 646f1a235..5d3478f7b 100644 --- a/packages/reactivity/__tests__/collections/WeakSet.spec.ts +++ b/packages/reactivity/__tests__/collections/WeakSet.spec.ts @@ -7,8 +7,8 @@ describe('reactivity/collections', () => { const original = new WeakSet() const observed = reactive(original) expect(isReactive(observed)).toBe(true) - expect(original instanceof WeakSet).toBe(true) - expect(observed instanceof WeakSet).toBe(true) + expect(original).toBeInstanceOf(WeakSet) + expect(observed).toBeInstanceOf(WeakSet) }) it('should observe mutations', () => { diff --git a/packages/reactivity/__tests__/reactive.spec.ts b/packages/reactivity/__tests__/reactive.spec.ts index f6fed0230..51c9ed42c 100644 --- a/packages/reactivity/__tests__/reactive.spec.ts +++ b/packages/reactivity/__tests__/reactive.spec.ts @@ -50,7 +50,7 @@ describe('reactivity/reactive', () => { class CustomMap extends Map {} const cmap = reactive(new CustomMap()) - expect(cmap instanceof Map).toBe(true) + expect(cmap).toBeInstanceOf(Map) expect(isReactive(cmap)).toBe(true) cmap.set('key', {}) @@ -60,7 +60,7 @@ describe('reactivity/reactive', () => { class CustomSet extends Set {} const cset = reactive(new CustomSet()) - expect(cset instanceof Set).toBe(true) + expect(cset).toBeInstanceOf(Set) expect(isReactive(cset)).toBe(true) let dummy @@ -77,7 +77,7 @@ describe('reactivity/reactive', () => { class CustomMap extends WeakMap {} const cmap = reactive(new CustomMap()) - expect(cmap instanceof WeakMap).toBe(true) + expect(cmap).toBeInstanceOf(WeakMap) expect(isReactive(cmap)).toBe(true) const key = {} @@ -88,7 +88,7 @@ describe('reactivity/reactive', () => { class CustomSet extends WeakSet {} const cset = reactive(new CustomSet()) - expect(cset instanceof WeakSet).toBe(true) + expect(cset).toBeInstanceOf(WeakSet) expect(isReactive(cset)).toBe(true) let dummy diff --git a/packages/runtime-dom/__tests__/createApp.spec.ts b/packages/runtime-dom/__tests__/createApp.spec.ts index 471dcfc7c..b8432f472 100644 --- a/packages/runtime-dom/__tests__/createApp.spec.ts +++ b/packages/runtime-dom/__tests__/createApp.spec.ts @@ -11,7 +11,7 @@ describe('createApp for dom', () => { } }).mount(root) expect(root.children.length).toBe(1) - expect(root.children[0] instanceof SVGElement).toBe(true) + expect(root.children[0]).toBeInstanceOf(SVGElement) }) // #4398 diff --git a/packages/vue-compat/__tests__/filters.spec.ts b/packages/vue-compat/__tests__/filters.spec.ts index 22f1cac64..c1acbd899 100644 --- a/packages/vue-compat/__tests__/filters.spec.ts +++ b/packages/vue-compat/__tests__/filters.spec.ts @@ -116,7 +116,7 @@ describe('FILTERS', () => { } } }).$mount() as any - expect(vm.$refs.test.pattern instanceof RegExp).toBe(true) + expect(vm.$refs.test.pattern).toBeInstanceOf(RegExp) expect(vm.$refs.test.pattern.toString()).toBe('/a|b\\//') expect(CompilerDeprecationTypes.COMPILER_FILTERS).toHaveBeenWarned() })