fix(hydration): should not warn on falsy bindings of non-property keys
This commit is contained in:
parent
9636357c89
commit
3907c87ce2
|
@ -1516,5 +1516,10 @@ describe('SSR hydration', () => {
|
|||
mountWithHydration(`<input />`, () => h('input', { from: {} }))
|
||||
expect(`Hydration attribute mismatch`).not.toHaveBeenWarned()
|
||||
})
|
||||
|
||||
test('should not warn on falsy bindings of non-property keys', () => {
|
||||
mountWithHydration(`<button />`, () => h('button', { href: undefined }))
|
||||
expect(`Hydration attribute mismatch`).not.toHaveBeenWarned()
|
||||
})
|
||||
})
|
||||
})
|
||||
|
|
|
@ -759,18 +759,18 @@ function propHasMismatch(
|
|||
actual = el.hasAttribute(key)
|
||||
expected = includeBooleanAttr(clientValue)
|
||||
} else {
|
||||
// #10000 some attrs such as textarea.value can't be get by `hasAttribute`
|
||||
if (el.hasAttribute(key)) {
|
||||
actual = el.getAttribute(key)
|
||||
} else if (key in el) {
|
||||
} else {
|
||||
// #10000 some attrs such as textarea.value can't be retrieved by `hasAttribute`
|
||||
const serverValue = el[key as keyof typeof el]
|
||||
if (!isObject(serverValue)) {
|
||||
actual = serverValue == null ? '' : String(serverValue)
|
||||
}
|
||||
}
|
||||
if (!isObject(clientValue)) {
|
||||
expected = clientValue == null ? '' : String(clientValue)
|
||||
actual =
|
||||
isObject(serverValue) || serverValue == null
|
||||
? ''
|
||||
: String(serverValue)
|
||||
}
|
||||
expected =
|
||||
isObject(clientValue) || clientValue == null ? '' : String(clientValue)
|
||||
}
|
||||
if (actual !== expected) {
|
||||
mismatchType = `attribute`
|
||||
|
|
Loading…
Reference in New Issue