From ad97bbab851ac69f115e018761ceb76abc5df56a Mon Sep 17 00:00:00 2001 From: Evan You Date: Fri, 16 Apr 2021 12:26:17 -0400 Subject: [PATCH] wip: invert compiler compat behavior default during tests --- packages/compiler-core/src/compat/compatConfig.ts | 4 +++- packages/compiler-core/src/errors.ts | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/compiler-core/src/compat/compatConfig.ts b/packages/compiler-core/src/compat/compatConfig.ts index f5acca1b6..91acbbd87 100644 --- a/packages/compiler-core/src/compat/compatConfig.ts +++ b/packages/compiler-core/src/compat/compatConfig.ts @@ -102,7 +102,9 @@ export function checkCompatEnabled( loc: SourceLocation | null, ...args: any[] ): boolean { - const enabled = getCompatValue(key, context) !== false + const value = getCompatValue(key, context) + // during tests, only enable when value is explicitly true + const enabled = __TEST__ ? value === true : value !== false if (__DEV__ && enabled) { warnDeprecation(key, context, loc, ...args) } diff --git a/packages/compiler-core/src/errors.ts b/packages/compiler-core/src/errors.ts index d1f1e0a8c..ae9da226a 100644 --- a/packages/compiler-core/src/errors.ts +++ b/packages/compiler-core/src/errors.ts @@ -13,9 +13,9 @@ export function defaultOnError(error: CompilerError) { throw error } -export function defaultOnWarn(msg: string | CompilerError) { - __DEV__ && - console.warn(`[Vue warn]`, typeof msg === 'string' ? msg : msg.message) +export function defaultOnWarn(msg: CompilerError) { + throw new Error('foo') + __DEV__ && console.warn(`[Vue warn]`, msg.message) } export function createCompilerError(