From b04be6a561be1bd974e7ab283442066eec344e81 Mon Sep 17 00:00:00 2001
From: Evan You <yyx990803@gmail.com>
Date: Mon, 23 Sep 2019 07:57:56 -0400
Subject: [PATCH] wip: fix transform order

---
 packages/compiler-core/src/codegen.ts               | 4 +++-
 packages/compiler-core/src/index.ts                 | 2 +-
 packages/compiler-core/src/transforms/expression.ts | 8 +-------
 packages/compiler-core/src/transforms/vFor.ts       | 1 +
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/packages/compiler-core/src/codegen.ts b/packages/compiler-core/src/codegen.ts
index 820b1d971..f66245adf 100644
--- a/packages/compiler-core/src/codegen.ts
+++ b/packages/compiler-core/src/codegen.ts
@@ -318,7 +318,9 @@ function genIfBranch(
   if (condition) {
     // v-if or v-else-if
     const { push, indent, deindent, newline } = context
-    push(`(${condition.content})`, condition)
+    push(`(`)
+    genExpression(condition, context)
+    push(`)`)
     indent()
     context.indentLevel++
     push(`? `)
diff --git a/packages/compiler-core/src/index.ts b/packages/compiler-core/src/index.ts
index 5af9df194..a3a3e7117 100644
--- a/packages/compiler-core/src/index.ts
+++ b/packages/compiler-core/src/index.ts
@@ -21,9 +21,9 @@ export function compile(
   transform(ast, {
     ...options,
     nodeTransforms: [
+      ...(!__BROWSER__ && options.useWith === false ? [rewriteExpression] : []),
       transformIf,
       transformFor,
-      ...(!__BROWSER__ && options.useWith === false ? [rewriteExpression] : []),
       prepareElementForCodegen,
       ...(options.nodeTransforms || []) // user transforms
     ],
diff --git a/packages/compiler-core/src/transforms/expression.ts b/packages/compiler-core/src/transforms/expression.ts
index 943cb5ace..d365091ab 100644
--- a/packages/compiler-core/src/transforms/expression.ts
+++ b/packages/compiler-core/src/transforms/expression.ts
@@ -31,9 +31,6 @@ export const rewriteExpression: NodeTransform = (node, context) => {
         }
       }
     }
-  } else if (node.type === NodeTypes.IF) {
-    for (let i = 0; i < node.branches.length; i++) {}
-  } else if (node.type === NodeTypes.FOR) {
   }
 }
 
@@ -102,10 +99,7 @@ function convertExpression(
   })
 
   return {
-    type: NodeTypes.EXPRESSION,
-    content: '',
-    isStatic: false,
-    loc: node.loc,
+    ...node,
     children
   }
 }
diff --git a/packages/compiler-core/src/transforms/vFor.ts b/packages/compiler-core/src/transforms/vFor.ts
index 8c293ea99..ed42fa698 100644
--- a/packages/compiler-core/src/transforms/vFor.ts
+++ b/packages/compiler-core/src/transforms/vFor.ts
@@ -17,6 +17,7 @@ export const transformFor = createStructuralDirectiveTransform(
 
       if (aliases) {
         // TODO inject identifiers to context
+        // and remove on exit
         context.replaceNode({
           type: NodeTypes.FOR,
           loc: node.loc,