openkylin
/
device_google_redfin
mirror of https://gitee.com/openkylin/device_google_redfin.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

dumpstate: Include Citadel status in all bugreports 

Gather Citadel's firmware version, uptime stats, and motherboard type in all
bug reports. None of this can be used to identify a specific phone, so it's
safe to run in production builds.

Previously we were running --id and --selftest. Because these could be used
to indentify a specific Citadel chip, we only gathered it on userdebug and
test builds. We used that to isolate problems with early Citadel samples in
prototype phones, which we've done, fixed, and replaced. We don't need that
info anymore.

Bug: 141235263
Test: manual
Change-Id: Ie8bbf818bca5bfda3905cbef9e103854dc0abaef
Merged-In: Ie8bbf818bca5bfda3905cbef9e103854dc0abaef
Signed-off-by: Bill Richardson <wfrichar@google.com>
(cherry picked from commit cbb9211b88ad75d17835579b3af31daa76910bc0)
This commit is contained in:
Bill Richardson 2020-01-10 17:28:21 -08:00 committed by Cyan_Hsieh
parent 6860324a4e
commit 7c81f10e1b
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dumpstate/DumpstateDevice.cpp
View File

@ -539,12 +539,10 @@ Return<void> DumpstateDevice::dumpstateBoard(const hidl_handle& handle) {
dumpModem(fd, fdModem);
}
// Citadel info (only enabled on -eng and -userdebug builds)
if (!PropertiesHelper::IsUserBuild()) {
RunCommandToFd(fd, "Citadel ID", {"/vendor/bin/hw/citadel_updater", "--id"});
RunCommandToFd(fd, "Citadel VER", {"/vendor/bin/hw/citadel_updater", "-lv"});
RunCommandToFd(fd, "Citadel SELFTEST", {"/vendor/bin/hw/citadel_updater", "--selftest"});
}
// Citadel info
RunCommandToFd(fd, "Citadel VERSION", {"/vendor/bin/hw/citadel_updater", "-lv"});
RunCommandToFd(fd, "Citadel STATS", {"/vendor/bin/hw/citadel_updater", "--stats"});
RunCommandToFd(fd, "Citadel BOARDID", {"/vendor/bin/hw/citadel_updater", "--board_id"});
DumpVibrator(fd);