openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
libvirt/tests/vmwarevertest.c

104 lines
2.4 KiB
C
Raw Normal View History

VMware: Make version parsing testable and add tests This splits up the version parsing code into a callable API like QEMU help/version string parsing so that we can test it as we need to add additional patterns for newer versions/products.
2013-09-18 22:30:35 +08:00
/*
* Copyright (c) 2013. Doug Goldstein <cardoe@cardoe.com>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*/
#include <config.h>
#include "testutils.h"
#ifdef WITH_VMWARE
# include "vmware/vmware_conf.h"
//# define VIR_FROM_THIS VIR_FROM_NONE
struct testInfo {
const char *vmware_type;
const char *name;
unsigned long version;
};
static int
testVerStrParse(const void *data)
{
const struct testInfo *info = data;
int ret = -1;
char *path = NULL;
char *databuf = NULL;
unsigned long version;
int vmware_type;
tests: Use g_strdup_printf() instead of virAsprintf() Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
2019-10-22 21:26:14 +08:00
path = g_strdup_printf("%s/vmwareverdata/%s.txt", abs_srcdir, info->name);
VMware: Make version parsing testable and add tests This splits up the version parsing code into a callable API like QEMU help/version string parsing so that we can test it as we need to add additional patterns for newer versions/products.
2013-09-18 22:30:35 +08:00
Rename virtTestLoadFile to virTestLoadFile. This function doesn't follow our convention of naming functions.
2016-05-26 23:01:52 +08:00
if (virTestLoadFile(path, &databuf) < 0)
VMware: Make version parsing testable and add tests This splits up the version parsing code into a callable API like QEMU help/version string parsing so that we can test it as we need to add additional patterns for newer versions/products.
2013-09-18 22:30:35 +08:00
goto cleanup;
if ((vmware_type = vmwareDriverTypeFromString(info->vmware_type)) < 0)
goto cleanup;
if (vmwareParseVersionStr(vmware_type, databuf, &version) < 0)
goto cleanup;
if (version != info->version) {
fprintf(stderr, "%s: parsed versions do not match: got %lu, "
"expected %lu\n", info->name, version, info->version);
goto cleanup;
}
ret = 0;
Indent top-level labels by one space in tests/
2014-03-25 14:53:44 +08:00
cleanup:
VMware: Make version parsing testable and add tests This splits up the version parsing code into a callable API like QEMU help/version string parsing so that we can test it as we need to add additional patterns for newer versions/products.
2013-09-18 22:30:35 +08:00
VIR_FREE(path);
VIR_FREE(databuf);
return ret;
}
static int
mymain(void)
{
int ret = 0;
Remove backslash alignment attempts Right-aligning backslashes when defining macros or using complex commands in Makefiles looks cute, but as soon as any changes is required to the code you end up with either distractingly broken alignment or unnecessarily big diffs where most of the changes are just pushing all backslashes a few characters to one side. Generated using $ git grep -El '[[:blank:]][[:blank:]]\\$' | \ grep -E '*\.([chx]|am|mk)$$' | \ while read f; do \ sed -Ei 's/[[:blank:]]*[[:blank:]]\\$/ \\/g' "$f"; \ done Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2017-11-03 20:09:47 +08:00
# define DO_TEST(vmware_type, name, version) \
do { \
struct testInfo info = { \
vmware_type, name, version \
}; \
if (virTestRun("VMware Version String Parsing " name, \
testVerStrParse, &info) < 0) \
ret = -1; \
VMware: Make version parsing testable and add tests This splits up the version parsing code into a callable API like QEMU help/version string parsing so that we can test it as we need to add additional patterns for newer versions/products.
2013-09-18 22:30:35 +08:00
} while (0)
DO_TEST("ws", "workstation-7.0.0", 7000000);
vmware: make version parsing more robust Since commit d69415d4, vmware version is parsed from both stdout and stderr. This patch makes version parsing work even if there is garbage (libvirt debug messages for example) in the command output. Add test data for this case.
2014-04-09 17:59:53 +08:00
DO_TEST("ws", "workstation-7.0.0-with-garbage", 7000000);
VMware: Add Fusion version test This adds a test for the version string of VMware Fusion.
2013-10-01 05:58:37 +08:00
DO_TEST("fusion", "fusion-5.0.3", 5000003);
VMware: Make version parsing testable and add tests This splits up the version parsing code into a callable API like QEMU help/version string parsing so that we can test it as we need to add additional patterns for newer versions/products.
2013-09-18 22:30:35 +08:00
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}
tests: Rename VIRT_TEST_* macros to VIR_TEST_* We use the "vir" prefix pretty consistently in our APIs, both external and internal, which made these macros stood out.
2017-03-29 22:45:42 +08:00
VIR_TEST_MAIN(mymain)
VMware: Make version parsing testable and add tests This splits up the version parsing code into a callable API like QEMU help/version string parsing so that we can test it as we need to add additional patterns for newer versions/products.
2013-09-18 22:30:35 +08:00
#else
int
main(void)
{
return EXIT_AM_SKIP;
}
#endif /* WITH_VMWARE */