From 08379dbd45c2078b0e5641e625f250370d5ddd11 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Fri, 7 Dec 2012 12:12:56 +0100 Subject: [PATCH] qemu: reuse qemuMigrationIsAllowed when doing save and managedsave Save and managedsave both use migration to file. This patch reuses qemuMigrationIsAllowed to check if the migration could happen before trying. --- src/qemu/qemu_driver.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9a449bfbeb..2fda44e3e7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3006,16 +3006,8 @@ qemuDomainSaveInternal(virQEMUDriverPtr driver, virDomainPtr dom, virDomainEventPtr event = NULL; qemuDomainObjPrivatePtr priv = vm->privateData; - if (qemuProcessAutoDestroyActive(driver, vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is marked for auto destroy")); + if (!qemuMigrationIsAllowed(driver, vm, vm->def, false)) goto cleanup; - } - if (virDomainHasDiskMirror(vm)) { - virReportError(VIR_ERR_BLOCK_COPY_ACTIVE, "%s", - _("domain has active block copy job")); - goto cleanup; - } if (qemuDomainObjBeginAsyncJobWithDriver(driver, vm, QEMU_ASYNC_JOB_SAVE) < 0)