From 0d4cdc0569a172c9ad42c04ddaf6af0000be2b3b Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 7 Nov 2008 16:43:23 +0000 Subject: [PATCH] always compile iptables.c Avoid a build error when configuring --without-xen --without-qemu. * src/iptables.c [WITH_QEMU]: Don't #ifdef-out. * src/iptables.h [WITH_QEMU]: Don't #ifdef-out. * src/util.c (virRun) [__MINGW32__]: Define a stub that always fails. --- ChangeLog | 8 ++++++++ src/iptables.c | 4 ---- src/iptables.h | 6 +----- src/util.c | 12 ++++++++++++ 4 files changed, 21 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3449df768e..59a4fbb441 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +Thu Nov 6 20:45:42 CET 2008 Jim Meyering + + always compile iptables.c + Avoid a build error when configuring --without-xen --without-qemu. + * src/iptables.c [WITH_QEMU]: Don't #ifdef-out. + * src/iptables.h [WITH_QEMU]: Don't #ifdef-out. + * src/util.c (virRun) [__MINGW32__]: Define a stub that always fails. + Thu Nov 6 17:33:34 CET 2008 Daniel Veillard * src/logging.c src/logging.h proxy/Makefile.am proxy/libvirt_proxy.c diff --git a/src/iptables.c b/src/iptables.c index 53e0f4130e..ad7fddf1bf 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -21,8 +21,6 @@ #include -#if WITH_QEMU - #include #include #include @@ -1120,5 +1118,3 @@ iptablesRemoveForwardMasquerade(iptablesContext *ctx, { return iptablesForwardMasquerade(ctx, network, physdev, REMOVE); } - -#endif /* WITH_QEMU */ diff --git a/src/iptables.h b/src/iptables.h index 95f07de7b5..fbe9b5d599 100644 --- a/src/iptables.h +++ b/src/iptables.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2007 Red Hat, Inc. + * Copyright (C) 2007, 2008 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -22,8 +22,6 @@ #ifndef __QEMUD_IPTABLES_H__ #define __QEMUD_IPTABLES_H__ -#if WITH_QEMU - typedef struct _iptablesContext iptablesContext; iptablesContext *iptablesContextNew (void); @@ -95,6 +93,4 @@ int iptablesRemoveForwardMasquerade (iptablesContext *ctx, const char *network, const char *physdev); -#endif /* WITH_QEMU */ - #endif /* __QEMUD_IPTABLES_H__ */ diff --git a/src/util.c b/src/util.c index abc86d6ea2..6141847a2c 100644 --- a/src/util.c +++ b/src/util.c @@ -579,6 +579,18 @@ virRun(virConnectPtr conn, #else /* __MINGW32__ */ +int +virRun(virConnectPtr conn, + const char *const *argv ATTRIBUTE_UNUSED, + int *status) +{ + if (status) + *status = ENOTSUP; + else + ReportError (conn, VIR_ERR_INTERNAL_ERROR, __FUNCTION__); + return -1; +} + int virExec(virConnectPtr conn, const char *const*argv ATTRIBUTE_UNUSED,