From 0df2f0404fdc87691c940565e42fbde83ce71679 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 18 Feb 2015 18:05:21 +0100 Subject: [PATCH] qemu: Exit job on error path of qemuDomainSetVcpusFlags() Commit e105dc981438bc33fa771bd67cece6234dbf6c8d moved some code but didn't adjust the jump labels so that the job would be terminated. --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1bbbe9bc87..8f0cf2bd5a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4716,13 +4716,13 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus, if (flags & VIR_DOMAIN_AFFECT_LIVE && !(flags & VIR_DOMAIN_VCPU_GUEST)) { if (virCgroupNewEmulator(priv->cgroup, false, &cgroup_temp) < 0) - goto cleanup; + goto endjob; if (!(all_nodes = virNumaGetHostNodeset())) - goto cleanup; + goto endjob; if (!(all_nodes_str = virBitmapFormat(all_nodes))) - goto cleanup; + goto endjob; if (virCgroupGetCpusetMems(cgroup_temp, &mem_mask) < 0 || virCgroupSetCpusetMems(cgroup_temp, all_nodes_str) < 0)