From 10823b78bba083c5379a2c40cb6f8a206c8d4a5f Mon Sep 17 00:00:00 2001 From: Sukrit Bhatnagar Date: Tue, 17 Apr 2018 04:26:24 +0530 Subject: [PATCH] qemu: Escape commas for qemuBuildFSStr and qemuBuildFSDevStr Add comma escaping for fs->src->path and fs->dst. Signed-off-by: Sukrit Bhatnagar Reviewed-by: John Ferlan --- src/qemu/qemu_command.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c2ea28bc76..920c48a11a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2351,7 +2351,8 @@ qemuBuildFSStr(virDomainFSDefPtr fs) virBufferAsprintf(&opt, ",writeout=%s", wrpolicy); virBufferAsprintf(&opt, ",id=%s%s", QEMU_FSDEV_HOST_PREFIX, fs->info.alias); - virBufferAsprintf(&opt, ",path=%s", fs->src->path); + virBufferAddLit(&opt, ",path="); + virQEMUBuildBufferEscapeComma(&opt, fs->src->path); if (fs->readonly) virBufferAddLit(&opt, ",readonly"); @@ -2388,7 +2389,8 @@ qemuBuildFSDevStr(const virDomainDef *def, virBufferAsprintf(&opt, ",id=%s", fs->info.alias); virBufferAsprintf(&opt, ",fsdev=%s%s", QEMU_FSDEV_HOST_PREFIX, fs->info.alias); - virBufferAsprintf(&opt, ",mount_tag=%s", fs->dst); + virBufferAddLit(&opt, ",mount_tag="); + virQEMUBuildBufferEscapeComma(&opt, fs->dst); if (qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps) < 0) goto error;