From 188de4f52979fbd5ef4f6895a8ba354b5104e3ac Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 18 Jul 2019 18:31:43 +0200 Subject: [PATCH] qemu: driver: Remove semi-stale comment about asynchronous job abort MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Now that we track the job separately we watch only for the abort of the one single block job so the comment is no longer accurate. Also describing asynchronous operation is not really necessary. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e85485a012..5f14b92a81 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17218,12 +17218,6 @@ qemuDomainBlockJobAbort(virDomainPtr dom, ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps)); - /* - * With the ABORT_ASYNC flag we don't need to do anything, the event will - * come from qemu and will update the XML as appropriate, but without the - * ABORT_ASYNC flag, we must block to guarantee synchronous operation. We - * do the waiting while still holding the VM job, to prevent newly - * scheduled block jobs from confusing us. */ if (!async) { qemuBlockJobUpdate(vm, job, QEMU_ASYNC_JOB_NONE); while (qemuBlockJobIsRunning(job)) {