openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

src: stop using O_DIRECTORY in resctrl 

The O_DIRECTORY flag causes open() to return an error
if the filename is a directory. There's no obvious
reason why resctrl needs to use this, while the rest of
libvirt code does not. Removing it avoids build issues
on platforms where O_DIRECTORY is not defined, once we
remove GNULIB.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2020-01-22 11:42:18 +00:00
parent 5c455d9081
commit 18dca21a32
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/util/virresctrl.c
View File

@ -455,7 +455,7 @@ VIR_ONCE_GLOBAL_INIT(virResctrl);
static int static int
virResctrlLockWrite(void) virResctrlLockWrite(void)
{ {
int fd = open(SYSFS_RESCTRL_PATH, O_DIRECTORY | O_CLOEXEC); int fd = open(SYSFS_RESCTRL_PATH, O_RDWR | O_CLOEXEC);
if (fd < 0) { if (fd < 0) {
virReportSystemError(errno, "%s", _("Cannot open resctrl")); virReportSystemError(errno, "%s", _("Cannot open resctrl"));