openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

virsh: Resolve possible NULL dereference 

Coverity found that commit '41b5e845' had a possible NULL dereference on
arg->data processing
This commit is contained in:
John Ferlan 2013-02-13 07:49:29 -05:00
parent 277aaeeebf
commit 1d816219eb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/virsh.c
View File

@ -1,7 +1,7 @@
/* /*
* virsh.c: a shell to exercise the libvirt API * virsh.c: a shell to exercise the libvirt API
* *
* Copyright (C) 2005, 2007-2012 Red Hat, Inc. * Copyright (C) 2005, 2007-2013 Red Hat, Inc.
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public * modify it under the terms of the GNU Lesser General Public
@ -1475,7 +1475,7 @@ vshCommandOptStringReq(vshControl *ctl,
if (!arg->data) if (!arg->data)
error = N_("Programming error: Requested option is a boolean"); error = N_("Programming error: Requested option is a boolean");
if (!*arg->data && !(arg->def->flags & VSH_OFLAG_EMPTY_OK)) if (arg->data && !*arg->data && !(arg->def->flags & VSH_OFLAG_EMPTY_OK))
error = N_("Option argument is empty"); error = N_("Option argument is empty");
if (error) { if (error) {