mirror of https://gitee.com/openkylin/libvirt.git
storage: Cleanup virStorageFileBackendGlusterReadlinkCallback
Rather than having two exit paths, let's use a @retval value and VIR_STEAL_PTR in order to unite the exit path through the error label. Signed-off-by: John Ferlan <jferlan@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
9916f2a3c8
commit
1ee7294bed
|
@ -262,6 +262,7 @@ virStorageFileBackendGlusterReadlinkCallback(const char *path,
|
||||||
size_t bufsiz = 0;
|
size_t bufsiz = 0;
|
||||||
ssize_t ret;
|
ssize_t ret;
|
||||||
struct stat st;
|
struct stat st;
|
||||||
|
int retval = -1;
|
||||||
|
|
||||||
*linkpath = NULL;
|
*linkpath = NULL;
|
||||||
|
|
||||||
|
@ -291,13 +292,13 @@ virStorageFileBackendGlusterReadlinkCallback(const char *path,
|
||||||
|
|
||||||
buf[ret] = '\0';
|
buf[ret] = '\0';
|
||||||
|
|
||||||
*linkpath = buf;
|
VIR_STEAL_PTR(*linkpath, buf);
|
||||||
|
|
||||||
return 0;
|
retval = 0;
|
||||||
|
|
||||||
error:
|
error:
|
||||||
VIR_FREE(buf);
|
VIR_FREE(buf);
|
||||||
return -1;
|
return retval;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue