openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

qemu: Avoid entering monitor with locked driver 

This avoids possible deadlock of the qemu driver in case a domain is
begin migrated (in Begin phase) and unrelated connection to qemu driver
is closed at the right time.

I checked all callers of qemuDomainCheckEjectableMedia() and they are
calling this function with qemu driver locked.
This commit is contained in:
Jiri Denemark 2012-03-27 13:32:43 +02:00
parent ecb4d92d57
commit 2067e31bf9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_hotplug.c
View File

@ -160,9 +160,9 @@ qemuDomainCheckEjectableMedia(struct qemud_driver *driver,
int ret = -1; int ret = -1;
int i; int i;
qemuDomainObjEnterMonitor(driver, vm); qemuDomainObjEnterMonitorWithDriver(driver, vm);
table = qemuMonitorGetBlockInfo(priv->mon); table = qemuMonitorGetBlockInfo(priv->mon);
qemuDomainObjExitMonitor(driver, vm); qemuDomainObjExitMonitorWithDriver(driver, vm);
if (!table) if (!table)
goto cleanup; goto cleanup;