From 217d2656a552cf079fa26154121774d6dd7f0249 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Tue, 17 Apr 2018 12:44:56 -0400 Subject: [PATCH] conf: Add a comment warning about boolean feature XML This is the old style and we really shouldn't be adding any more examples like this. Add a comment to warn devs away Reviewed-by: John Ferlan Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c92725dd25..4e2de46d45 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26894,6 +26894,8 @@ virDomainDefFormatInternal(virDomainDefPtr def, case VIR_DOMAIN_FEATURE_PAE: case VIR_DOMAIN_FEATURE_VIRIDIAN: case VIR_DOMAIN_FEATURE_PRIVNET: + /* NOTE: This is for old style booleans. New XML + * should use the explicit state=on|off output below */ switch ((virTristateSwitch) def->features[i]) { case VIR_TRISTATE_SWITCH_ABSENT: break;