From 2ab95531ca675048ac60bca323f0bc06dd4991fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Fri, 5 Feb 2016 17:40:51 +0100 Subject: [PATCH] vboxDumpDisplay: use VIR_APPEND_ELEMENT Instead of open-coding it. --- src/vbox/vbox_common.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index a5f0beb560..e0f28d097f 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -3363,14 +3363,9 @@ vboxDumpDisplay(virDomainDefPtr def, vboxGlobalData *data, IMachine *machine) goto cleanup; } - if (graphics) { - if (VIR_ALLOC_N(def->graphics, 1) < 0) - goto cleanup; - - def->graphics[def->ngraphics] = graphics; - graphics = NULL; - def->ngraphics++; - } + if (graphics && + VIR_APPEND_ELEMENT(def->graphics, def->ngraphics, graphics) < 0) + goto cleanup; gVBoxAPI.UIMachine.GetVRDxServer(machine, &VRDxServer); if (VRDxServer) @@ -3407,12 +3402,8 @@ vboxDumpDisplay(virDomainDefPtr def, vboxGlobalData *data, IMachine *machine) if (reuseSingleConnection) graphics->data.rdp.replaceUser = true; - if (VIR_REALLOC_N(def->graphics, def->ngraphics + 1) < 0) + if (VIR_APPEND_ELEMENT(def->graphics, def->ngraphics, graphics) < 0) goto cleanup; - - def->graphics[def->ngraphics] = graphics; - graphics = NULL; - def->ngraphics++; } ret = 0;